Skip to content

next: Tailwind v4#1770

Merged
AdrianGonz97 merged 76 commits into
nextfrom
next-tailwind-4
May 18, 2025
Merged

next: Tailwind v4#1770
AdrianGonz97 merged 76 commits into
nextfrom
next-tailwind-4

Conversation

@huntabyte
Copy link
Copy Markdown
Owner

@huntabyte huntabyte commented Mar 18, 2025

We'll use this branch to work towards Tailwind v4 support before merging into @next.

In addition to Tailwind 4 support, we can also bring the CLI up to parity with the original, supporting external components, updated docs, etc. 😁

Due Outs

CLI

  • shadcn-svelte registry build tests
  • shadcn-svelte add <external_x_y_or_z_types> tests
  • Backward compatibility for existing projects that have a components.json with Tailwind v3 and Svelte v5
  • Gracefully handle shadcn-svelte init for projects that have Tailwind v3 and Svelte 5
  • Handle optional peer dependencies
  • Handle @types/<dep> with registry build script
  • Update specific pinned tailwind v3/svelte 5 init CLI version (the version right before we merge this branch)

Docs

  • Accurately document the registry additions
  • Update CLI docs with new commands/args
  • Update components.json docs
  • Charts docs page(s)
  • Update blocks
  • Pin layerchart@next to the latest version before merge
  • Scrub all install commands for proper versions (like sv)
  • Improve handling of chart themes/themes for copying?

Components

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 18, 2025

🦋 Changeset detected

Latest commit: ad4cd6b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
shadcn-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 18, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
shadcn-svelte ✅ Ready (View Log) Visit Preview ad4cd6b

@bitaccesscomau
Copy link
Copy Markdown

Do we have a list of what is currently broken/requiring review? I just finished migrating to Tailwind 4 on Svelte 4 and despite some initial config issues with the border-border css class and converting to the new HSL value syntax it all seems to be working well!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data-[orientation='horizontal'] doesn't need single quotes: data-[orientation=horizontal]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup none of the components have been touched yet all the work so far is on the CLI.

Copy link
Copy Markdown
Contributor

@Wombosvideo Wombosvideo Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I've noticed a weird issue when using the vertical slider in a modal or drawer on mobile: The SliderPrimitive.Range is moved to the right, making only about half of it visible.

image

This can be fixed by adding the class data-[orientation=vertical]:left-0

@enqqi enqqi mentioned this pull request Mar 20, 2025
1 task
* ts-blank-space issues

* fix blank space

* format and lint

* fix update
Co-authored-by: AdrianGonz97 <31664583+AdrianGonz97@users.noreply.github.com>
@shyakadavis shyakadavis mentioned this pull request May 17, 2025
1 task
huntabyte and others added 9 commits May 17, 2025 12:14
Co-authored-by: AdrianGonz97 <31664583+AdrianGonz97@users.noreply.github.com>
Co-authored-by: Hunter Johnston <johnstonhuntera@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@huntabyte
Copy link
Copy Markdown
Owner Author

Later today (5/18) - we ship 🚀

@p-arndt
Copy link
Copy Markdown

p-arndt commented May 18, 2025

Later today (5/18) - we ship 🚀

Today is almost over ? Can't wait 👍🏼

@laGameTV
Copy link
Copy Markdown

Later today (5/18) - we ship 🚀

Today is almost over ? Can't wait 👍🏼

It's only 16:09 for him 😄

@p-arndt
Copy link
Copy Markdown

p-arndt commented May 18, 2025

Later today (5/18) - we ship 🚀

Today is almost over ? Can't wait 👍🏼

It's only 16:09 for him 😄

oh damn - well makes sense haha 😄

huntabyte and others added 2 commits May 18, 2025 16:35
Co-authored-by: CokaKoala <31664583+AdrianGonz97@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.