tw4: cleanup/improve error messaging#1919
Conversation
|
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
There was a problem hiding this comment.
Pull Request Overview
This PR refines error messaging and cleans up outdated TODO comments related to error handling and UI behavior.
- Update error messages in CLI preflight checks.
- Remove outdated or confusing TODO comments in pagination and charts components.
- Enhance test expectations to match the updated error outputs.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| v4/src/lib/registry/ui/pagination/pagination-next-button.svelte | Removed outdated TODO comment referencing complex union types. |
| v4/src/lib/registry/ui/pagination/pagination-link.svelte | Removed outdated TODO comment referencing complex union types. |
| v4/src/lib/registry/charts/chart-radar-lines-only.svelte | Removed a TODO comment prompting for a hexagon drawing feature. |
| v4/src/lib/registry/charts/chart-line-dots.svelte | Removed a TODO comment regarding active dot styling. |
| v4/src/lib/registry/charts/chart-bar-negative.svelte | Removed a TODO comment regarding month labels and custom colors on bars. |
| packages/cli/test/utils/preflight-init.test.ts | Updated test expectations to reflect new error messages with highlighted text and links. |
| packages/cli/src/commands/init/preflight.ts | Improved error message consistency and detail in CLI preflight checks. |
Comments suppressed due to low confidence (1)
packages/cli/test/utils/preflight-init.test.ts:47
- The error message contains a double period ('supported..'). Consider using a single period for clarity.
`Initializing a project with Tailwind v3 and Svelte v4 is not supported..\n\n` +
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.