Skip to content

tw4: cleanup/improve error messaging#1919

Merged
huntabyte merged 5 commits into
next-tailwind-4from
tw-4-version-stuff
May 17, 2025
Merged

tw4: cleanup/improve error messaging#1919
huntabyte merged 5 commits into
next-tailwind-4from
tw-4-version-stuff

Conversation

@huntabyte
Copy link
Copy Markdown
Owner

No description provided.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 17, 2025

⚠️ No Changeset found

Latest commit: 20aeaf9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 17, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
scn-svelte-v4 ✅ Ready (View Log) Visit Preview 2c650d1
shadcn-svelte ✅ Ready (View Log) Visit Preview 2c650d1

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines error messaging and cleans up outdated TODO comments related to error handling and UI behavior.

  • Update error messages in CLI preflight checks.
  • Remove outdated or confusing TODO comments in pagination and charts components.
  • Enhance test expectations to match the updated error outputs.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
v4/src/lib/registry/ui/pagination/pagination-next-button.svelte Removed outdated TODO comment referencing complex union types.
v4/src/lib/registry/ui/pagination/pagination-link.svelte Removed outdated TODO comment referencing complex union types.
v4/src/lib/registry/charts/chart-radar-lines-only.svelte Removed a TODO comment prompting for a hexagon drawing feature.
v4/src/lib/registry/charts/chart-line-dots.svelte Removed a TODO comment regarding active dot styling.
v4/src/lib/registry/charts/chart-bar-negative.svelte Removed a TODO comment regarding month labels and custom colors on bars.
packages/cli/test/utils/preflight-init.test.ts Updated test expectations to reflect new error messages with highlighted text and links.
packages/cli/src/commands/init/preflight.ts Improved error message consistency and detail in CLI preflight checks.
Comments suppressed due to low confidence (1)

packages/cli/test/utils/preflight-init.test.ts:47

  • The error message contains a double period ('supported..'). Consider using a single period for clarity.
`Initializing a project with Tailwind v3 and Svelte v4 is not supported..\n\n` +

Comment thread packages/cli/src/commands/init/preflight.ts Outdated
huntabyte and others added 2 commits May 17, 2025 18:12
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@huntabyte huntabyte merged commit 80e29f6 into next-tailwind-4 May 17, 2025
7 checks passed
@huntabyte huntabyte deleted the tw-4-version-stuff branch May 23, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants