Skip to content

feat(v4): Strip types through the CLI#1778

Merged
huntabyte merged 5 commits into
huntabyte:next-tailwind-4from
ieedan:javascript-registry-removal
Mar 20, 2025
Merged

feat(v4): Strip types through the CLI#1778
huntabyte merged 5 commits into
huntabyte:next-tailwind-4from
ieedan:javascript-registry-removal

Conversation

@ieedan
Copy link
Copy Markdown
Collaborator

@ieedan ieedan commented Mar 19, 2025

This PR removes the JS registry in favor of stripping the types with the CLI.

  • Updates build-registry to only build a typescript registry under /registry/
  • Updates the CLI to strip types at the same time as it updates the imports
  • We now use sv-strip to give us better test coverage and remove some complexity

This is some pre-work for remote components as this will simplify things and also give users more features for their registries.

CLI

We have to add a few dependencies to make this work obviously

  • ts-blank-space
  • sv-strip
  • prettier
  • prettier-plugin-svelte

It's worth noting that you could try and eliminate prettier-plugin-svelte and instead load the users config but you will run into issues when operating out of the current working directory. (I have this problem in jsrepo) Basically prettier uses a process.cwd() instead of letting you provide one so it won't work when --cwd is passed.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 19, 2025

⚠️ No Changeset found

Latest commit: 9e9f812

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 19, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
shadcn-svelte ✅ Ready (View Log) Visit Preview 9e9f812

@ieedan ieedan changed the title feat: Strip types through the CLI feat(v4): Strip types through the CLI Mar 19, 2025
@ieedan
Copy link
Copy Markdown
Collaborator Author

ieedan commented Mar 19, 2025

This should be good to go

@huntabyte huntabyte merged commit 80ea4a2 into huntabyte:next-tailwind-4 Mar 20, 2025
@ieedan ieedan deleted the javascript-registry-removal branch March 20, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants