Skip to content

fix(v4): Generate correct code on /theme#1797

Merged
huntabyte merged 10 commits into
huntabyte:next-tailwind-4from
ieedan:theme-page
Mar 27, 2025
Merged

fix(v4): Generate correct code on /theme#1797
huntabyte merged 10 commits into
huntabyte:next-tailwind-4from
ieedan:theme-page

Conversation

@ieedan
Copy link
Copy Markdown
Collaborator

@ieedan ieedan commented Mar 26, 2025

This doesn't add the missing themes to themes.css but I think we are waiting on the original for those...

This consolidates the code for generating the themes so that we use the same methods for building the registry as we do for generating the code to copy.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 26, 2025

⚠️ No Changeset found

Latest commit: b065f5c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 26, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
shadcn-svelte ✅ Ready (View Log) Visit Preview b065f5c

@ieedan
Copy link
Copy Markdown
Collaborator Author

ieedan commented Mar 26, 2025

@huntabyte not sure what the issue is but it seems like the themes page just refuses to work in preview. It can get the themes that we have configured to work locally though...

@ieedan
Copy link
Copy Markdown
Collaborator Author

ieedan commented Mar 26, 2025

I set it up to build the other themes I still don't understand why some of them aren't showing up though...

@huntabyte
Copy link
Copy Markdown
Owner

Nice looking theme 😂
CleanShot 2025-03-27 at 13 00 45@2x

@huntabyte
Copy link
Copy Markdown
Owner

Yeah we'll see what shad ends up doing because right now it seems he's just supporting the gray variants on the v4 site.

@huntabyte huntabyte merged commit 821013f into huntabyte:next-tailwind-4 Mar 27, 2025
@ieedan
Copy link
Copy Markdown
Collaborator Author

ieedan commented Mar 27, 2025

Nice looking theme 😂

CleanShot 2025-03-27 at 13 00 45@2x

I made it myself do you like it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants