Skip to content

Add weekday to time contidion editor#6786

Closed
Misiu wants to merge 58 commits intohome-assistant:devfrom
Misiu:weekday
Closed

Add weekday to time contidion editor#6786
Misiu wants to merge 58 commits intohome-assistant:devfrom
Misiu:weekday

Conversation

@Misiu
Copy link
Contributor

@Misiu Misiu commented Sep 4, 2020

Breaking change

Proposed change

image

This is the first step to add weekdays support to time condition.
Next will be ha-expand-panel (#6726) that will allow us to hide (collapse) parts that aren't filled

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration



Additional information




Checklist



    

  •  The code change is tested and works locally.
    • 

  •  There is no commented out code in this PR.
    • 

  •  Tests have been added to verify that the new code works.
    • 



If user exposed functionality or configuration variables are added/changed:



    

  
  



      


          

          
  
  

    
  
    
    

  

  

  



                    

          
        





  





    



      

  
        





      

  
            







      

  
        

    

  
  

  
          bramkragten
  
and others
        added 2 commits
        September 4, 2020 15:18


  

      

  
  

  
          

  

    

      


  

      
        @bramkragten
  




      

        
          Fix gauge editor (home-assistant#6783)
        

      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          faee2c3
        
      

    

  







      

  
  

  
          

  

    

      


  

      
        @bramkragten
      
        @ludeeus
  




      

        
          Add person badge (home-assistant#6785)
        

          
                        
      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          d1a9cb4
        
      

    

  

    

      
* Add person badge

* Update src/components/user/ha-person-badge.ts

Co-authored-by: Joakim Sørensen <joasoe@gmail.com>

* Revert screwup by @ludeeus

Co-authored-by: Joakim Sørensen <joasoe@gmail.com>
Co-authored-by: Ludeeus <ludeeus@ludeeus.dev>

    







  








      

  
        





      

  
        





      

  
        





      

  
        





      

  
        

  

      

  
  

  
          

  

    

      


  

      
        @Misiu
      
        @zsarnett
  




      

        
          remove quote
        

          
                        
      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          f7eb824
        
      

    

  

    

      
Co-authored-by: Zack Arnett <arnett.zackary@gmail.com>

    







  








      

  
        





      

  
        





      

  
        





      

  
        





      

  
        

  

      

  
  

  
          

  

    

      


  

      
        @Misiu
      
        @zsarnett
  




      

        
          code readability
        

          
                        
      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          93ed135
        
      

    

  

    

      
Co-authored-by: Zack Arnett <arnett.zackary@gmail.com>

    







  








      

  
        





      

  
        





      

  
        





      

  
        





      

  
        





      

  
          

  

    
  


  

      


    @Misiu
Misiu



    mentioned this pull request
    
      Sep 4, 2020
    





  


  

      
   Merged

  





  
  

      
        
      
      


  
    
    
  


    9 tasks
  





  









      

  
        






  

    

      

        

          
          
        

      


   


        

  
        





        

  
      



  

  @zsarnett






  



    

      

  

    

      

          
    
    

  


        
            
  
      
              Copy link

  

        
      

    


    

        

  
    Contributor


        

    

  


  

    

      
          
      

      
            zsarnett
  

      

      

      commented


        Sep 7, 2020


      
    


  





      


        



  
    

      
          
Needs to be rebased


      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












        

  
        





        

  
        





        

  
        

    

  
  

  
          homeassistant
  
and others
        added 18 commits
        September 8, 2020 00:32


  

      

  
  

  
          

  

    

      


  

      
        @homeassistant
  




      

        
          [ci skip] Translation update
        

      


      

        

    
    
    

  

      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          0889f42
        
      

    

  







      

  
  

  
          

  

    

      


  

      
        @zsarnett
  




      

        
          fix more info content
        

      


      

        

    
    
    

  

      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          30c47a6
        
      

    

  







      

  
  

  
          

  

    

      


  

      
        @bramkragten
  




      

        
          Merge pull request home-assistant#6835 from home-assistant/fix-more-info
        

          
                        
      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          01a4d57
        
      

    

  

    

      
Fix More info content from having space on right

    







      

  
  

  
          

  

    

      


  

      
        @zsarnett
  




      

        
          Fix header on media browser in safari (home-assistant#6838)
        

      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          8b1801f
        
      

    

  







      

  
  

  
          

  

    

      


  

      
        @zsarnett
  




      

        
          Fix Calendar Card in Add Card dialog (home-assistant#6833)
        

      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          d7448ec
        
      

    

  







      

  
  

  
          

  

    

      


  

      
        @Misiu
      
        @zsarnett
  




      

        
          simplify
        

          
                        
      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          327f6ba
        
      

    

  

    

      
Co-authored-by: Zack Barett <zackbarett@hey.com>

    







      

  
  

  
          

  

    

      


  

      
        @Misiu
  




      

        
          add weekday to time contidion
        

      


      

        

    
    
    

  

      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          9349f34
        
      

    

  







      

  
  

  
          

  

    

      


  

      
        @Misiu
  




      

        
          review fixes part1
        

      


      

        

    
    
    

  

      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          313a764
        
      

    

  







      

  
  

  
          

  

    

      


  

      
        @Misiu
  




      

        
          review fixes part2
        

      


      

        

    
    
    

  

      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          dea7734
        
      

    

  







      

  
  

  
          

  

    

      


  

      
        @Misiu
  




      

        
          review fixes part3
        

      


      

        

    
    
    

  

      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          b26062e
        
      

    

  







      

  
  

  
          

  

    

      


  

      
        @Misiu
  




      

        
          review fixes part4
        

      


      

        

    
    
    

  

      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          77d2ec9
        
      

    

  







      

  
  

  
          

  

    

      


  

      
        @Misiu
      
        @zsarnett
  




      

        
          simplify
        

          
                        
      


      

        

    
    
    

  

      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          112b72f
        
      

    

  

    

      
Co-authored-by: Zack Barett <zackbarett@hey.com>

    







      

  
  

  
          

  

    

      


  

      
        @Misiu
  




      

        
          rebase + comments
        

      


      

        

    
    
    

  

      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          abdb4d9
        
      

    

  







      

  
  

  
          

  

    

      


  

      
        @Misiu
  




      

        
          Merge branch 'weekday' of https://github.com/Misiu/frontend into weekday
        

      


      

        

    
    
    

  

      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          de5cab3
        
      

    

  







      

  
  

  
          

  

    

      


  

      
        @Misiu
  




      

        
          remove duplicate interface
        

      


      

        

    
    
    

  

      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          48ec0b6
        
      

    

  







      

  
  

  
          

  

    

      


  

      
        @Misiu
  




      

        
          Revert "remove duplicate interface"
        

          
                        
      


      

        

    
    
    

  

      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          3d4358c
        
      

    

  

    

      
This reverts commit 48ec0b6.

    







      

  
  

  
          

  

    

      


  

      
        @Misiu
  




      

        
          Revert "Merge branch 'weekday' of https://github.com/Misiu/frontend i…
        

          
                        
      


      

        

    
    
    

  

      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          72ca9c9
        
      

    

  

    

      
…nto weekday"

This reverts commit de5cab3, reversing
changes made to abdb4d9.

    







      

  
  

  
          

  

    

      


  

      
        @Misiu
  




      

        
          Revert "rebase + comments"
        

          
                        
      


      

        

    
    
    

  

      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          6960c25
        
      

    

  

    

      
This reverts commit abdb4d9.

    







  








        

  
          

  

    
  


  

      


    @Misiu
Misiu



    mentioned this pull request
    
      Sep 8, 2020
    





  


  

      
   Merged

  





  
  

      
        
      
      


  
    
    
  


    9 tasks
  





  









        

  
      



  

  @Misiu






  



    

      

  

    

      

          
    
    

  


        
            
  
      
              Copy link

  

        
      

    


    

        

  
    Contributor


        

  Author


    

  


  

    

      
          
      

      
            Misiu
  

      

      

      commented


        Sep 8, 2020


      
    


  





      


        



  
    

      
          
Replaced by #6848


      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












        

  
            

    

      
    

    


      


          @Misiu
Misiu




          closed this


      Sep 8, 2020

    

  


    


    

    

      
    

    


      


          @github-actions
github-actions
bot



        locked and limited conversation to collaborators


      Jul 5, 2022

    

  










  
  

    

      

  










  








  
     

  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.


  









      

  

    
    

    

  

    Reviewers
  


    


      

  

    


  
      @zsarnett
  
    zsarnett


    
      
        
      
    
    zsarnett left review comments




      






    
    
    

    

  


      
  

    Assignees
  



        


    No one assigned







      


  


  

    Labels
  



    

      

    cla-signed









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
  

    Development
  



            


Successfully merging this pull request may close these issues.



  
          
      Automations condition.weekday missing in Automation GUI



  
  



      
    

  




      

    

  
        

  

    

      10 participants
    

    

        
          @Misiu 
        
          @zsarnett 
        
          @homeassistant 
        
          @bramkragten 
        
          @spacegaier 
        
          @cgarwood 
        
          @donkawechico 
        
          @pszafer 
        
          @ludeeus 
        
          @SeanPM5