Add basic nodes list & node metadata to OZW config panel#6719
Merged
bramkragten merged 16 commits intohome-assistant:devfrom Sep 4, 2020
Merged
Add basic nodes list & node metadata to OZW config panel#6719bramkragten merged 16 commits intohome-assistant:devfrom
bramkragten merged 16 commits intohome-assistant:devfrom
Conversation
zsarnett
reviewed
Aug 28, 2020
src/panels/config/integrations/integration-panels/ozw/ozw-config-network.ts
Outdated
Show resolved
Hide resolved
zsarnett
reviewed
Aug 28, 2020
src/panels/config/integrations/integration-panels/ozw/ozw-config-network.ts
Outdated
Show resolved
Hide resolved
zsarnett
reviewed
Aug 28, 2020
src/panels/config/integrations/integration-panels/ozw/ozw-config-node.ts
Outdated
Show resolved
Hide resolved
zsarnett
reviewed
Aug 28, 2020
src/panels/config/integrations/integration-panels/ozw/ozw-config-node.ts
Outdated
Show resolved
Hide resolved
zsarnett
reviewed
Aug 28, 2020
src/panels/config/integrations/integration-panels/ozw/ozw-network-dashboard.ts
Outdated
Show resolved
Hide resolved
zsarnett
reviewed
Aug 28, 2020
src/panels/config/integrations/integration-panels/ozw/ozw-network-dashboard.ts
Outdated
Show resolved
Hide resolved
zsarnett
reviewed
Aug 28, 2020
src/panels/config/integrations/integration-panels/ozw/ozw-network-dashboard.ts
Outdated
Show resolved
Hide resolved
zsarnett
reviewed
Aug 28, 2020
src/panels/config/integrations/integration-panels/ozw/ozw-network-dashboard.ts
Outdated
Show resolved
Hide resolved
zsarnett
reviewed
Aug 28, 2020
src/panels/config/integrations/integration-panels/ozw/ozw-network-nodes.ts
Outdated
Show resolved
Hide resolved
zsarnett
reviewed
Aug 28, 2020
src/panels/config/integrations/integration-panels/ozw/ozw-network-nodes.ts
Outdated
Show resolved
Hide resolved
zsarnett
reviewed
Aug 28, 2020
src/panels/config/integrations/integration-panels/ozw/ozw-network-nodes.ts
Outdated
Show resolved
Hide resolved
zsarnett
reviewed
Aug 28, 2020
src/panels/config/integrations/integration-panels/ozw/ozw-network-nodes.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Aug 28, 2020
src/panels/config/integrations/integration-panels/ozw/ozw-config-network.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Aug 28, 2020
src/panels/config/integrations/integration-panels/ozw/ozw-config-network.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Aug 28, 2020
src/panels/config/integrations/integration-panels/ozw/ozw-config-network.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Aug 29, 2020
src/panels/config/integrations/integration-panels/ozw/ozw-config-network.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Aug 29, 2020
src/panels/config/integrations/integration-panels/ozw/ozw-config-node.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Aug 29, 2020
src/panels/config/integrations/integration-panels/ozw/ozw-config-network.ts
Outdated
Show resolved
Hide resolved
Member
Author
bramkragten
reviewed
Sep 2, 2020
src/panels/config/integrations/integration-panels/ozw/ozw-network-dashboard.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Sep 2, 2020
src/panels/config/integrations/integration-panels/ozw/ozw-network-dashboard.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Sep 3, 2020
src/panels/config/integrations/integration-panels/ozw/ozw-network-router.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Sep 3, 2020
src/panels/config/integrations/integration-panels/ozw/ozw-node-dashboard.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Sep 3, 2020
src/panels/config/integrations/integration-panels/ozw/ozw-node-dashboard.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Sep 3, 2020
src/panels/config/integrations/integration-panels/ozw/ozw-node-dashboard.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Sep 3, 2020
Comment on lines
+138
to
+147
| this._node = await fetchOZWNodeStatus( | ||
| this.hass!, | ||
| this.ozwInstance, | ||
| this.nodeId | ||
| ); | ||
| this._metadata = await fetchOZWNodeMetadata( | ||
| this.hass!, | ||
| this.ozwInstance, | ||
| this.nodeId | ||
| ); |
Member
There was a problem hiding this comment.
What will happen when we request a node that no longer/not exists?
Member
There was a problem hiding this comment.
So this will not error but return None?
Member
Author
There was a problem hiding this comment.
Updated to catch a not_found error and show the error page. I used a separate _not_found property to prevent a quick flash of the not found page on initial load before it finishes fetching the node data initially.
bramkragten
reviewed
Sep 4, 2020
src/panels/config/integrations/integration-panels/ozw/ozw-node-dashboard.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Sep 4, 2020
src/panels/config/integrations/integration-panels/ozw/ozw-node-dashboard.ts
Outdated
Show resolved
Hide resolved
bramkragten
approved these changes
Sep 4, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Proposed change
I'm currently having some issues I haven't been able to figure out with the
ozw-network-nodespage and<ha-tabs-subpage-data-table>giving an error thatResizeObserver loop limit exceeded.I'd also love some tips on centrally managing the navigation tags (basically anything under ozw-network-router should have the same tabs, anything under ozw-node-router should have a separate set of tabs).
I'm also not fully convinced I'm managing the routers correctly... let me know if there's a better way to optimize or handle those.
Type of change
Checklist