Skip to content

Media Browser Panel#6772

Merged
bramkragten merged 41 commits intodevfrom
media-browser-panel
Sep 4, 2020
Merged

Media Browser Panel#6772
bramkragten merged 41 commits intodevfrom
media-browser-panel

Conversation

@zsarnett
Copy link
Contributor

@zsarnett zsarnett commented Sep 2, 2020

Proposed change

image
image
image
image
image
image

Type of change

  • New feature (thank you!)

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Comment on lines +38 to +40
// @ts-ignore
@LocalStorage("mediaBrowseEntityId")
private _entityId?: string;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need help from Bram on this decorator so that InternalProperty can be use at the same time

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mediaSources: this._browseMediaSources(this.hass),
sourceSelectedCallback: (entityId) => {
this._entityId = entityId;
this.requestUpdate();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be removed

@zsarnett zsarnett marked this pull request as draft September 2, 2020 20:33
zsarnett and others added 2 commits September 4, 2020 13:41
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
@bramkragten bramkragten merged commit e63a78b into dev Sep 4, 2020
@bramkragten bramkragten deleted the media-browser-panel branch September 4, 2020 21:01
@bramkragten bramkragten mentioned this pull request Sep 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants