Add node details shortcut to OZW device pages#6791
Merged
bramkragten merged 4 commits intohome-assistant:devfrom Sep 4, 2020
Merged
Add node details shortcut to OZW device pages#6791bramkragten merged 4 commits intohome-assistant:devfrom
bramkragten merged 4 commits intohome-assistant:devfrom
Conversation
Member
Author
|
|
bramkragten
reviewed
Sep 4, 2020
Comment on lines
88
to
93
| <mwc-button @click=${this._nodeDetailsClicked}> | ||
| ${this.hass.localize("ui.panel.config.ozw.node.button")} | ||
| </mwc-button> | ||
| <mwc-button @click=${this._refreshNodeClicked}> | ||
| Refresh Node | ||
| ${this.hass.localize("ui.panel.config.ozw.refresh_node.button")} | ||
| </mwc-button> |
Member
There was a problem hiding this comment.
This should be in device actions, so it is styled correctly. Check zha for example.
bramkragten
approved these changes
Sep 4, 2020
bramkragten
reviewed
Sep 4, 2020
src/panels/config/devices/device-detail/integration-elements/ozw/ha-device-actions-ozw.ts
Outdated
Show resolved
Hide resolved
…zw/ha-device-actions-ozw.ts
bramkragten
reviewed
Sep 4, 2020
src/panels/config/devices/device-detail/integration-elements/ozw/ha-device-actions-ozw.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Sep 4, 2020
src/panels/config/devices/device-detail/integration-elements/ozw/ha-device-actions-ozw.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds a "Node Details" button to the device pages for OZW devices that takes you to the details page for that node in the OZW config panel. Also fixes a translation for the Refresh Node button.
Type of change
Example configuration
Checklist
If user exposed functionality or configuration variables are added/changed: