Skip to content

Automation editor tweaks#6713

Merged
bramkragten merged 10 commits intodevfrom
automation-editor-tweaks
Sep 7, 2020
Merged

Automation editor tweaks#6713
bramkragten merged 10 commits intodevfrom
automation-editor-tweaks

Conversation

@bramkragten
Copy link
Member

@bramkragten bramkragten commented Aug 26, 2020

Proposed change

  • Attribute triggers/conditions
  • Copy automation
  • Add input_datetime option for time trigger and condition
  • Wait for trigger action

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@zsarnett
Copy link
Contributor

We should make attribute fields disabled or hidden until an entity is selected

@zsarnett
Copy link
Contributor

Sorry I know this a draft. But I was looking over it :)

@bramkragten bramkragten force-pushed the automation-editor-tweaks branch from a1903e7 to 0464065 Compare September 6, 2020 19:24
@bramkragten bramkragten marked this pull request as ready for review September 6, 2020 20:39
@bramkragten bramkragten requested a review from ludeeus September 7, 2020 06:59
>
<paper-input
.autofocus=${this.autofocus}
.label=${this.label ??
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not know ?? existed, nice one!

@bramkragten bramkragten requested a review from ludeeus September 7, 2020 14:44
@ludeeus ludeeus added the WTH Issues & PRs generated from the "Month of What the Heck?" label Sep 7, 2020
@ludeeus
Copy link
Member

ludeeus commented Sep 7, 2020

…-wait_template.ts

Co-authored-by: Joakim Sørensen <joasoe@gmail.com>
@bramkragten bramkragten merged commit de7ffb1 into dev Sep 7, 2020
@bramkragten bramkragten deleted the automation-editor-tweaks branch September 7, 2020 17:53
@bramkragten bramkragten mentioned this pull request Sep 7, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed WTH Issues & PRs generated from the "Month of What the Heck?"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants