Skip to content

Add support for firmware target in zwave_js FirmwareUploadView#88523

Merged
balloob merged 9 commits into
home-assistant:devfrom
raman325:target
Feb 23, 2023
Merged

Add support for firmware target in zwave_js FirmwareUploadView#88523
balloob merged 9 commits into
home-assistant:devfrom
raman325:target

Conversation

@raman325
Copy link
Copy Markdown
Contributor

@raman325 raman325 commented Feb 20, 2023 •
edited
Loading

Proposed change

As part of the PR to add support for zwave-js 10.3 (see all linked PRs here: home-assistant/frontend#15425), we removed the target parameter when we shouldn't have. We have added it back upstream and have a corresponding frontend change to re-add it into the UI: home-assistant/frontend#15517

Dependent on #88520

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Feb 20, 2023

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zwave_js can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign zwave_js Removes the current integration label and assignees on the issue, add the integration domain after the command.

@raman325 raman325 mentioned this pull request Feb 21, 2023
Merged
9 tasks
@raman325 raman325 marked this pull request as ready for review February 21, 2023 06:44
@raman325 raman325 requested a review from a team as a code owner February 21, 2023 06:44
MartinHjelmare
MartinHjelmare requested changes Feb 21, 2023
View reviewed changes
Comment thread tests/components/zwave_js/test_api.py Outdated
Comment thread tests/components/zwave_js/test_api.py Outdated
Comment thread tests/components/zwave_js/test_api.py Outdated
Comment thread tests/components/zwave_js/test_api.py Outdated
@home-assistant home-assistant Bot marked this pull request as draft February 21, 2023 08:12
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Feb 21, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

raman325 and others added 5 commits February 21, 2023 19:11
@raman325 @MartinHjelmare
Update tests/components/zwave_js/test_api.py
3593171 
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@raman325 @MartinHjelmare
Update tests/components/zwave_js/test_api.py
abc7cf1 
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@raman325 @MartinHjelmare
Update tests/components/zwave_js/test_api.py
14d5e19 
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@raman325 @MartinHjelmare
Update tests/components/zwave_js/test_api.py
83724b9 
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@raman325
fix types
8207b57
@raman325 raman325 marked this pull request as ready for review February 22, 2023 01:07
@raman325 raman325 marked this pull request as draft February 22, 2023 01:07
@raman325
Merge branch 'dev' into target
5a6744c 
* dev: (60 commits)
  Update frontend to 20230222.0 (home-assistant#88615)
  Add controller support to `zwave_js/subscribe_firmware_update_status` (home-assistant#87348)
  Bump Freebox to 1.1.0 (home-assistant#88609)
  Always include platform in `config/entity_registry/list_for_display` (home-assistant#88601)
  Add dsk option to zwave_js/add_node WS command (home-assistant#87823)
  Update zwave_js FirmwareUploadView to support controller updates (home-assistant#87239)
  Add new zwave_js WS command to parse DSK from QR code (home-assistant#87237)
  Diagnostics report for Thread networks (home-assistant#88541)
  Set default for `hass_config_yaml` fixture to "" (home-assistant#88608)
  Bump reolink-aio to 0.5.0 (home-assistant#88594)
  Bump intents package version; hassil==1.0.5; home-assistant-intents==2023.2.22 (home-assistant#88605)
  Add Reolink update entity (home-assistant#87865)
  Fix cover template: optimistic mode is ignored (home-assistant#87925)
  Fix 500 error when getting calendar events (home-assistant#88276)
  Add clarifying comment about unit of elevation (home-assistant#88489)
  Add ZHA "consumer connected" binary sensor for Xiaomi EU plugs (home-assistant#88194)
  Bump Insteon dependencies (home-assistant#88514)
  Use load_json_object in ecobee (home-assistant#88584)
  Use load_json_object in html5 (home-assistant#88586)
  Improve type hint in homeassistant trigger (home-assistant#88596)
  ...
@raman325 raman325 marked this pull request as ready for review February 22, 2023 18:42
@raman325 raman325 added this to the 2023.3.0 milestone Feb 22, 2023
@balloob balloob merged commit 5739782 into home-assistant:dev Feb 23, 2023
balloob pushed a commit that referenced this pull request Feb 23, 2023
@raman325 @MartinHjelmare @balloob
Add support for firmware target in zwave_js FirmwareUploadView (#88523)
0d2006b 
* Add support for firmware target in zwave_js FirmwareUploadView

fix

* Update tests/components/zwave_js/test_api.py

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

* Update tests/components/zwave_js/test_api.py

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

* Update tests/components/zwave_js/test_api.py

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

* Update tests/components/zwave_js/test_api.py

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

* fix types

* Switch back to using Any

---------

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@raman325 raman325 deleted the target branch February 24, 2023 01:48
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@balloob balloob balloob approved these changes

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

No one assigned

Labels

bugfix cherry-picked cla-signed has-tests integration: zwave_js Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

2023.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@raman325 @balloob @MartinHjelmare