Add new zwave_js WS command to parse DSK from QR code#87237
Conversation
|
Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
EDIT: Per @AlCalzone we do not need to do any upfront validation for the DSK check, we should just send it to the function which will do the validation for us. |
|
yep, if the method doesn't return a DSK, the QR code is not a DSK-only QR and the existing logic applies. |
MartinHjelmare
left a comment
There was a problem hiding this comment.
We should wait with merging here until there's a linked and approved frontend PR.
* dev: (60 commits) Update frontend to 20230222.0 (home-assistant#88615) Add controller support to `zwave_js/subscribe_firmware_update_status` (home-assistant#87348) Bump Freebox to 1.1.0 (home-assistant#88609) Always include platform in `config/entity_registry/list_for_display` (home-assistant#88601) Add dsk option to zwave_js/add_node WS command (home-assistant#87823) Update zwave_js FirmwareUploadView to support controller updates (home-assistant#87239) Add new zwave_js WS command to parse DSK from QR code (home-assistant#87237) Diagnostics report for Thread networks (home-assistant#88541) Set default for `hass_config_yaml` fixture to "" (home-assistant#88608) Bump reolink-aio to 0.5.0 (home-assistant#88594) Bump intents package version; hassil==1.0.5; home-assistant-intents==2023.2.22 (home-assistant#88605) Add Reolink update entity (home-assistant#87865) Fix cover template: optimistic mode is ignored (home-assistant#87925) Fix 500 error when getting calendar events (home-assistant#88276) Add clarifying comment about unit of elevation (home-assistant#88489) Add ZHA "consumer connected" binary sensor for Xiaomi EU plugs (home-assistant#88194) Bump Insteon dependencies (home-assistant#88514) Use load_json_object in ecobee (home-assistant#88584) Use load_json_object in html5 (home-assistant#88586) Improve type hint in homeassistant trigger (home-assistant#88596) ...
Proposed change
Updates the zwave_js integration to support features introduced in zwave-js 10.4.0 and zwave-js-server-python 0.45.0:
try_parse_dsk_from_qr_code_stringAPI command which allows users to scan a DSK QR code. This just adds support for more provisioning methodsTo implement this in the frontend, we need to:
null, provision the node using S2 security and thedskparameter optionType of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: