Skip to content

Update zwave_js FirmwareUploadView to support controller updates#87239

Merged
raman325 merged 3 commits into
home-assistant:devfrom
raman325:firmware_upload_view
Feb 22, 2023
Merged

Update zwave_js FirmwareUploadView to support controller updates#87239
raman325 merged 3 commits into
home-assistant:devfrom
raman325:firmware_upload_view

Conversation

@raman325
Copy link
Copy Markdown
Contributor

@raman325 raman325 commented Feb 3, 2023 •
edited
Loading

Proposed change

Updates the zwave_js integration to support features introduced in zwave-js 10.4.0 and zwave-js-server-python 0.45.0:

  • Updates the firmware upload view to support OTW updates on the controller. The view automatically determines what type of update to apply based on the device ID that the view is called for. This allows the frontend to follow a single code path to upload firmware, regardless of the device in the config entry.

Should be merged with #87348 and home-assistant/frontend#15515

@kpine tested all three PRs E2E and everything looks functional!

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@raman325 raman325 requested a review from a team as a code owner February 3, 2023 03:55
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Feb 3, 2023

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zwave_js can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign zwave_js Removes the current integration label and assignees on the issue, add the integration domain after the command.

MartinHjelmare
MartinHjelmare approved these changes Feb 5, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't merge here until there's a linked and approved frontend PR that uses the view for OTW updates.

@MartinHjelmare MartinHjelmare marked this pull request as draft February 5, 2023 00:48
@raman325 raman325 mentioned this pull request Feb 20, 2023
Merged
9 tasks
@raman325 raman325 force-pushed the firmware_upload_view branch from f4829f5 to a44022f Compare February 21, 2023 07:16
@raman325 raman325 marked this pull request as ready for review February 22, 2023 00:03
@raman325 raman325 mentioned this pull request Feb 22, 2023
Merged
19 tasks
@raman325 raman325 marked this pull request as draft February 22, 2023 01:07
@raman325 raman325 marked this pull request as ready for review February 22, 2023 01:07
@raman325 raman325 merged commit 1f9f6ab into home-assistant:dev Feb 22, 2023
@raman325 raman325 deleted the firmware_upload_view branch February 22, 2023 16:52
raman325 added a commit to raman325/home-assistant that referenced this pull request Feb 22, 2023
@raman325
Merge branch 'dev' into target
5a6744c 
* dev: (60 commits)
  Update frontend to 20230222.0 (home-assistant#88615)
  Add controller support to `zwave_js/subscribe_firmware_update_status` (home-assistant#87348)
  Bump Freebox to 1.1.0 (home-assistant#88609)
  Always include platform in `config/entity_registry/list_for_display` (home-assistant#88601)
  Add dsk option to zwave_js/add_node WS command (home-assistant#87823)
  Update zwave_js FirmwareUploadView to support controller updates (home-assistant#87239)
  Add new zwave_js WS command to parse DSK from QR code (home-assistant#87237)
  Diagnostics report for Thread networks (home-assistant#88541)
  Set default for `hass_config_yaml` fixture to "" (home-assistant#88608)
  Bump reolink-aio to 0.5.0 (home-assistant#88594)
  Bump intents package version; hassil==1.0.5; home-assistant-intents==2023.2.22 (home-assistant#88605)
  Add Reolink update entity (home-assistant#87865)
  Fix cover template: optimistic mode is ignored (home-assistant#87925)
  Fix 500 error when getting calendar events (home-assistant#88276)
  Add clarifying comment about unit of elevation (home-assistant#88489)
  Add ZHA "consumer connected" binary sensor for Xiaomi EU plugs (home-assistant#88194)
  Bump Insteon dependencies (home-assistant#88514)
  Use load_json_object in ecobee (home-assistant#88584)
  Use load_json_object in html5 (home-assistant#88586)
  Improve type hint in homeassistant trigger (home-assistant#88596)
  ...
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

No one assigned

Labels

cla-signed has-tests integration: zwave_js new-feature Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@raman325 @MartinHjelmare