Re-add target option to zwave-js firmware upload#15517
Merged
Merged
Conversation
This was referenced Feb 21, 2023
bramkragten
reviewed
Feb 21, 2023
bramkragten
reviewed
Feb 22, 2023
bramkragten
reviewed
Feb 22, 2023
bramkragten
previously approved these changes
Feb 22, 2023
bramkragten
approved these changes
Feb 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR was a mistake: #15425
We should have never removed this option but I misunderstood the implications of a new zwave-js release and learned about this issue recently so it's been readded everywhere else upstream, including in core here: home-assistant/core#88523
I made some slight modifications to the things I removed in the original PR. Mainly I changed the intro text because it was not accurate, and the target is now undefined by default. This means that if the user doesn't make a change, we send undefined upstream to the zwave-js-server and let zwave-js decide how to handle it.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: