Skip to content

Re-add target option to zwave-js firmware upload#15517

Merged
bramkragten merged 4 commits into
home-assistant:devfrom
raman325:target
Feb 23, 2023
Merged

Re-add target option to zwave-js firmware upload#15517
bramkragten merged 4 commits into
home-assistant:devfrom
raman325:target

Conversation

@raman325
Copy link
Copy Markdown
Contributor

@raman325 raman325 commented Feb 21, 2023

Proposed change

This PR was a mistake: #15425

We should have never removed this option but I misunderstood the implications of a new zwave-js release and learned about this issue recently so it's been readded everywhere else upstream, including in core here: home-assistant/core#88523

I made some slight modifications to the things I removed in the original PR. Mainly I changed the intro text because it was not accurate, and the target is now undefined by default. This means that if the user doesn't make a change, we send undefined upstream to the zwave-js-server and let zwave-js decide how to handle it.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@raman325 raman325 marked this pull request as draft February 22, 2023 01:08
bramkragten
bramkragten previously approved these changes Feb 22, 2023
@raman325 raman325 requested a review from bramkragten February 22, 2023 18:42
@raman325 raman325 marked this pull request as ready for review February 22, 2023 18:42
@raman325 raman325 added this to the 2023.3 milestone Feb 22, 2023
@bramkragten bramkragten merged commit f786539 into home-assistant:dev Feb 23, 2023
@raman325 raman325 deleted the target branch February 24, 2023 01:46
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants