Add Reolink update entity#87865
Merged
Merged
Conversation
8 tasks
frenck
requested changes
Feb 12, 2023
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Contributor
Author
|
@frenck I have adressed the changes you requested, could you review again? |
frenck
approved these changes
Feb 22, 2023
Member
frenck
left a comment
frenck
left a comment
There was a problem hiding this comment.
Thanks, @starkillerOG 👍
../Frenck
raman325
added a commit
to raman325/home-assistant
that referenced
this pull request
Feb 22, 2023
* dev: (60 commits) Update frontend to 20230222.0 (home-assistant#88615) Add controller support to `zwave_js/subscribe_firmware_update_status` (home-assistant#87348) Bump Freebox to 1.1.0 (home-assistant#88609) Always include platform in `config/entity_registry/list_for_display` (home-assistant#88601) Add dsk option to zwave_js/add_node WS command (home-assistant#87823) Update zwave_js FirmwareUploadView to support controller updates (home-assistant#87239) Add new zwave_js WS command to parse DSK from QR code (home-assistant#87237) Diagnostics report for Thread networks (home-assistant#88541) Set default for `hass_config_yaml` fixture to "" (home-assistant#88608) Bump reolink-aio to 0.5.0 (home-assistant#88594) Bump intents package version; hassil==1.0.5; home-assistant-intents==2023.2.22 (home-assistant#88605) Add Reolink update entity (home-assistant#87865) Fix cover template: optimistic mode is ignored (home-assistant#87925) Fix 500 error when getting calendar events (home-assistant#88276) Add clarifying comment about unit of elevation (home-assistant#88489) Add ZHA "consumer connected" binary sensor for Xiaomi EU plugs (home-assistant#88194) Bump Insteon dependencies (home-assistant#88514) Use load_json_object in ecobee (home-assistant#88584) Use load_json_object in html5 (home-assistant#88586) Improve type hint in homeassistant trigger (home-assistant#88596) ...
| """Initialize a Netgear device.""" | ||
| super().__init__(reolink_data, reolink_data.firmware_coordinator) | ||
|
|
||
| self._attr_unique_id = f"{self._host.unique_id}_update" |
Member
There was a problem hiding this comment.
We don't need to add the platform domain to the unique_id. The entity registry is aware of both the integration domain and the platform domain. It's good to add a unique suffix if we're planning to add more than one entity type for the platform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Add Reolink update entity
Also implements the Base class for NVR entities that is used by the update entity.
(that do not have a channel and do not controll a camera connected to a channel but settings of the NVR itself).
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: