Add config flow to qBittorrent#82560
Merged
Merged
Conversation
home-assistant
Bot
added
cla-signed
config-flow
Contributor
|
Hey there @geoffreylagaisse, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
8 tasks
MartinHjelmare
changed the title
chrisx8
requested review from
Danielhiversen,
Ernst79,
Jc2k,
MartinHjelmare,
allenporter,
bdraco and
marcelveldt
as code owners
chrisx8
force-pushed
the
qbittorrent
branch
2 times, most recently
from
209c731 to
c247aa9
Compare
chrisx8
force-pushed
the
qbittorrent
branch
2 times, most recently
from
5a29ae6 to
334b50a
Compare
epenet
requested changes
Mar 22, 2023
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
20 tasks
epenet
requested changes
Mar 27, 2023
Co-authored-by: epenet <epenet@users.noreply.github.com>
Co-authored-by: epenet <epenet@users.noreply.github.com>
epenet
requested changes
Mar 28, 2023
20 tasks
epenet
reviewed
Mar 29, 2023
Contributor
epenet
left a comment
epenet
left a comment
There was a problem hiding this comment.
Please address these two recommendations in follow-up PRs
| ) | ||
| except LoginRequired as err: | ||
| _LOGGER.error("Invalid credentials") | ||
| raise ConfigEntryNotReady from err |
Contributor
There was a problem hiding this comment.
Time to implement reauth flow...
|
|
||
| self._attr_name = f"{client_name} {description.name}" | ||
| self._attr_unique_id = f"{config_entry.entry_id}-{description.key}" | ||
| self._attr_name = f"{config_entry.title} {description.name}" |
Contributor
There was a problem hiding this comment.
You should now look at adding DeviceInfo and set _attr_has_entity_name accordingly
Contributor
Author
|
@epenet Thanks a lot for the help ❤️ FYI, the doc PR is still awaiting: home-assistant/home-assistant.io#25028 |
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Please address the comments in a new PR. Thanks!
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
The YAML configuration has been deprecated. Existing YAML configuration will imported into the UI automatically. Once the import succeeds, it's safe to remove the qBittorrent YAML configuration from your
configuration.yamlfile.Proposed change
qbittorrentintegration and add support forconfig_flow.config_flow.CONF_VERIFY_SSLoption defaults toTrue, to preserve the old behavior.CONF_NAMEis optional in YAML. IfCONF_NAMEdoesn't exist in YAML, default to theDEFAULT_NAMEType of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: