Skip to content

Add config flow to qbittorrent#25028

Merged
frenck merged 2 commits into
home-assistant:nextfrom
chrisx8:qbittorrent
Apr 3, 2023
Merged

Add config flow to qbittorrent#25028
frenck merged 2 commits into
home-assistant:nextfrom
chrisx8:qbittorrent

Conversation

@chrisx8
Copy link
Copy Markdown
Contributor

@chrisx8 chrisx8 commented Nov 23, 2022

Proposed change

  • Refactor qbittorrent integration and add support for config_flow.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase: #82560

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant Bot added current This PR goes into the current branch has-parent This PR has a parent PR in another repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Nov 23, 2022
@home-assistant
Copy link
Copy Markdown

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

@chrisx8 chrisx8 changed the base branch from current to next November 23, 2022 04:55
@home-assistant home-assistant Bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch current This PR goes into the current branch labels Nov 23, 2022
@home-assistant home-assistant Bot added the next This PR goes into the next branch label Nov 23, 2022
@thecode thecode removed the request for review from chemelli74 November 25, 2022 18:31
@chrisx8 chrisx8 marked this pull request as draft December 1, 2022 15:51
@chrisx8 chrisx8 marked this pull request as ready for review December 1, 2022 15:51
frenck
frenck previously approved these changes Jan 16, 2023
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

Signed-off-by: Chris Xiao <30990835+chrisx8@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants