Skip to content

Move qbittorrent constants to const.py#90201

Merged
epenet merged 2 commits into
home-assistant:devfrom
chrisx8:qbittorrent_move_consts
Mar 24, 2023
Merged

Move qbittorrent constants to const.py#90201
epenet merged 2 commits into
home-assistant:devfrom
chrisx8:qbittorrent_move_consts

Conversation

@chrisx8
Copy link
Copy Markdown
Contributor

@chrisx8 chrisx8 commented Mar 23, 2023

Proposed change

Move constants used by the qbittorrent integration from sensors.py to consts.py

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @geoffreylagaisse, mind taking a look at this pull request as it has been labeled with an integration (qbittorrent) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of qbittorrent can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign qbittorrent Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@chrisx8 chrisx8 marked this pull request as ready for review March 23, 2023 22:26
@chrisx8 chrisx8 mentioned this pull request Mar 23, 2023
19 tasks
Copy link
Copy Markdown
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate note (for another PR): whilst looking at the use of the constants, I stumbled on format_speed and I think that should be dropped and adjusted in favor of suggested_unit_of_measurement/suggested_display_precision on the entity descriptions.

Separate note 2 (for yet another PR): I think the current_status sensor should be adjusted to use device_class ENUM to enable translations

Comment thread homeassistant/components/qbittorrent/const.py Outdated
@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant Bot marked this pull request as draft March 24, 2023 06:35
@chrisx8 chrisx8 force-pushed the qbittorrent_move_consts branch from 38b6024 to 3bf1ac4 Compare March 24, 2023 13:18
@chrisx8 chrisx8 marked this pull request as ready for review March 24, 2023 13:18
@home-assistant home-assistant Bot requested a review from epenet March 24, 2023 13:18
Copy link
Copy Markdown
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@epenet epenet merged commit 8149652 into home-assistant:dev Mar 24, 2023
@chrisx8 chrisx8 deleted the qbittorrent_move_consts branch March 24, 2023 13:22
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants