Move qbittorrent constants to const.py#90201
Conversation
|
Hey there @geoffreylagaisse, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
epenet
left a comment
There was a problem hiding this comment.
Separate note (for another PR): whilst looking at the use of the constants, I stumbled on format_speed and I think that should be dropped and adjusted in favor of suggested_unit_of_measurement/suggested_display_precision on the entity descriptions.
Separate note 2 (for yet another PR): I think the current_status sensor should be adjusted to use device_class ENUM to enable translations
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
38b6024 to
3bf1ac4
Compare
Proposed change
Move constants used by the
qbittorrentintegration fromsensors.pytoconsts.pyType of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: