Skip to content

qBittorrent: Support disabling ssl verification#82506

Closed
chrisx8 wants to merge 1 commit into
home-assistant:devfrom
chrisx8:qbittorrent_verify_ssl
Closed

qBittorrent: Support disabling ssl verification#82506
chrisx8 wants to merge 1 commit into
home-assistant:devfrom
chrisx8:qbittorrent_verify_ssl

Conversation

@chrisx8
Copy link
Copy Markdown
Contributor

@chrisx8 chrisx8 commented Nov 21, 2022

Proposed change

  • Add optional verify_ssl config option to qbittorrent integration.
  • When verify_ssl: false, SSL certificate verification will be disabled.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hi chrisx8

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @geoffreylagaisse, mind taking a look at this pull request as it has been labeled with an integration (qbittorrent) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of qbittorrent can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign qbittorrent Removes the current integration label and assignees on the issue, add the integration domain after the command.

Add `verify_ssl` config option. When set to False, SSL certificate
verification will be disabled.

Signed-off-by: Chris Xiao <30990835+chrisx8@users.noreply.github.com>
@chrisx8 chrisx8 force-pushed the qbittorrent_verify_ssl branch from e225e88 to 866db1e Compare November 21, 2022 20:57
@chrisx8 chrisx8 marked this pull request as ready for review November 21, 2022 21:03
vol.Required(CONF_USERNAME): cv.string,
vol.Required(CONF_PASSWORD): cv.string,
vol.Optional(CONF_NAME, default=DEFAULT_NAME): cv.string,
vol.Optional(CONF_VERIFY_SSL, default=True): cv.boolean,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer allow integrations to add or change a platform YAML configuration.

More information on this can be found in Architecture Decision Record:

Please note that this integration connects to a device or service and another Architecture Decision Record applies that disallows the use of YAML configuration in favor of a configuration flow via the UI:

See our developer documentation on how to get started creating a configuration flow for this integration:

https://developers.home-assistant.io/docs/config_entries_config_flow_handler

As these changes often involve a bit of work and some significant shift in the current code, we will close this PR for now.

We (and our community!) would really appreciate it if you could start on the refactoring of this integration in a new PR.

Thanks already! 👍

@frenck frenck closed this Nov 21, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

qBittorrent ignore SSL verification

2 participants