qBittorrent: Support disabling ssl verification#82506
Conversation
|
Hi chrisx8 It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
|
Hey there @geoffreylagaisse, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
b8d2830 to
e225e88
Compare
Add `verify_ssl` config option. When set to False, SSL certificate verification will be disabled. Signed-off-by: Chris Xiao <30990835+chrisx8@users.noreply.github.com>
e225e88 to
866db1e
Compare
| vol.Required(CONF_USERNAME): cv.string, | ||
| vol.Required(CONF_PASSWORD): cv.string, | ||
| vol.Optional(CONF_NAME, default=DEFAULT_NAME): cv.string, | ||
| vol.Optional(CONF_VERIFY_SSL, default=True): cv.boolean, |
There was a problem hiding this comment.
We no longer allow integrations to add or change a platform YAML configuration.
More information on this can be found in Architecture Decision Record:
Please note that this integration connects to a device or service and another Architecture Decision Record applies that disallows the use of YAML configuration in favor of a configuration flow via the UI:
See our developer documentation on how to get started creating a configuration flow for this integration:
https://developers.home-assistant.io/docs/config_entries_config_flow_handler
As these changes often involve a bit of work and some significant shift in the current code, we will close this PR for now.
We (and our community!) would really appreciate it if you could start on the refactoring of this integration in a new PR.
Thanks already! 👍
Proposed change
verify_sslconfig option toqbittorrentintegration.verify_ssl: false, SSL certificate verification will be disabled.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: