Skip to content

Simplify qbittorrent sensor class init #90411

Merged
emontnemery merged 1 commit into
home-assistant:devfrom
chrisx8:qbittorrent_sensor_cleanup
Mar 28, 2023
Merged

Simplify qbittorrent sensor class init #90411
emontnemery merged 1 commit into
home-assistant:devfrom
chrisx8:qbittorrent_sensor_cleanup

Conversation

@chrisx8
Copy link
Copy Markdown
Contributor

@chrisx8 chrisx8 commented Mar 28, 2023

Proposed change

Catch LoginException directly in QBittorrentSensor.__init__.

The exception arg in QBittorrentSensor __init__ is always LoginException, so the arg serves no purpose. Simply catching LoginException directly in __init__ instead achieves the same result.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Since the `exception` arg in QBittorrentSensor `__init__` is always
LoginException, we catch LoginException directly in `__init__` instead
of passing LoginException as an argument.
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @geoffreylagaisse, mind taking a look at this pull request as it has been labeled with an integration (qbittorrent) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of qbittorrent can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign qbittorrent Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@chrisx8 chrisx8 mentioned this pull request Mar 28, 2023
19 tasks
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Mar 28, 2023
@emontnemery emontnemery merged commit 048d309 into home-assistant:dev Mar 28, 2023
@chrisx8 chrisx8 deleted the qbittorrent_sensor_cleanup branch March 28, 2023 15:06
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed code-quality integration: qbittorrent Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants