Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish EntityDescription implementation for RainMachine #55180

Merged
merged 5 commits into from
Aug 25, 2021
Merged

Finish EntityDescription implementation for RainMachine #55180

merged 5 commits into from
Aug 25, 2021

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Aug 24, 2021

Proposed change

Following up on #55021, this PR finishes implementing EntityDescription for the remainder of RainMachine's platforms.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bachya bachya self-assigned this Aug 24, 2021
@bachya bachya force-pushed the rainmachine-entity-description branch from 6ed456f to 252f1be Compare August 24, 2021 21:01
cdce8p
cdce8p reviewed Aug 24, 2021
View reviewed changes
Copy link
Member

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Thanks for picking this up after my initial PR!
Some small comments and I believe a pylint error, after that it should be good.

homeassistant/components/rainmachine/const.py Outdated Show resolved Hide resolved
homeassistant/components/rainmachine/switch.py Outdated Show resolved Hide resolved
homeassistant/components/rainmachine/switch.py Outdated Show resolved Hide resolved
homeassistant/components/rainmachine/switch.py Outdated Show resolved Hide resolved
@bachya bachya force-pushed the rainmachine-entity-description branch from 252f1be to 97ca1c7 Compare August 25, 2021 01:35
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Aug 25, 2021
@cdce8p
Copy link
Member

cdce8p commented Aug 25, 2021

Merged upstream to deal with the CI issues

frenck
frenck requested changes Aug 25, 2021
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really small comment, otherwise 👍

homeassistant/components/rainmachine/switch.py Outdated Show resolved Hide resolved
@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Aug 25, 2021
@cdce8p cdce8p added the smash Indicator this PR is close to finish for merging or closing label Aug 25, 2021
frenck
frenck approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bachya 👍

ludeeus
ludeeus requested changes Aug 25, 2021
View reviewed changes
homeassistant/components/rainmachine/model.py
@@ -0,0 +1,9 @@
"""Define RainMachine data models."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is new and needs to be excluded in.coveragerc

frenck
frenck requested changes Aug 25, 2021
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh one small change needed still...

homeassistant/components/rainmachine/model.py needs to be put into .coveragerc

@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Aug 25, 2021
@bachya bachya added the smash Indicator this PR is close to finish for merging or closing label Aug 25, 2021
@bachya bachya merged commit 6bc5c1c into home-assistant:dev Aug 25, 2021
@bachya bachya deleted the rainmachine-entity-description branch August 25, 2021 14:36
raman325 added a commit to raman325/home-assistant that referenced this pull request Aug 25, 2021
@raman325
Merge remote-tracking branch 'upstream/dev' into template_number
118e37b 
* upstream/dev: (588 commits)
  Add select platform to template integration (home-assistant#54835)
  Honeywell Lyric - Entity Descriptions (home-assistant#54956)
  Add tests for Rituals init, sensor and switch (home-assistant#52406)
  Support for EnergyStorageTrait for vacuum cleaners (home-assistant#55134)
  Add support for Xiaomi Miio pedestal fans (home-assistant#55114)
  Sonos add bass & treble EQ option (home-assistant#53978)
  Address review of Nanoleaf Config Flow (home-assistant#55215)
  Implement color_mode support for mysensors (home-assistant#52068)
  Change logging to do rollover() instead of rotate() (home-assistant#55177)
  Support device triggers in HomeKit (home-assistant#53869)
  Remove temperature conversion - sht31 (home-assistant#55213)
  Finish EntityDescription implementation for RainMachine (home-assistant#55180)
  Remove temperature conversion - synology_dsm (home-assistant#55214)
  Report average of position and tilt_position for cover groups (home-assistant#52713)
  Ignore unsupported MeasureType-s from Withings (home-assistant#55205)
  Prevent setting _attr_unit_of_measurement in subclasses of SensorEntity (home-assistant#55211)
  Fix Fjäråskupan RSSI sensor unit (home-assistant#55210)
  ESPHome sensor use total_increasing state class (home-assistant#55208)
  Remove should poll property from Xiaomi Miio fan platform (home-assistant#55201)
  Fix last_reset in utility_meter (home-assistant#55209)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2021
@cdce8p cdce8p added the project-code_style PRs related to #53201 - pylint CodeStyle update label Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdce8p cdce8p cdce8p left review comments

@frenck frenck frenck approved these changes

@ludeeus ludeeus ludeeus approved these changes

Assignees

@bachya bachya

Labels
by-code-owner cla-signed code-quality integration: rainmachine project-code_style PRs related to #53201 - pylint CodeStyle update smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bachya @cdce8p @frenck @ludeeus @homeassistant