Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add select platform to template integration #54835

Merged
merged 10 commits into from
Aug 25, 2021
Merged

Add select platform to template integration #54835

merged 10 commits into from
Aug 25, 2021

Conversation

raman325
Copy link
Contributor

@raman325 raman325 commented Aug 18, 2021 •
edited
Loading

Proposed change

Adds the select platform to the template integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@raman325 raman325 requested a review from a team as a code owner August 18, 2021 15:04
@probot-home-assistant
Copy link

Hey there @PhracturedBlue, @tetienne, @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (template) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck marked this pull request as draft August 18, 2021 16:06
@frenck
Copy link
Member

frenck commented Aug 18, 2021

Converting to draft, as there are todo's listed

@raman325 raman325 marked this pull request as ready for review August 23, 2021 19:05
@raman325 raman325 mentioned this pull request Aug 23, 2021
Merged
8 tasks
@raman325 raman325 added the smash Indicator this PR is close to finish for merging or closing label Aug 23, 2021
@raman325
Copy link
Contributor Author

Note that because the options parameter is a list, we need to use render_complex. As a result I modified the TriggerEntity class to support both simple and complex rendering

balloob
balloob approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok when guarded for platform config

@balloob balloob merged commit 8407ad0 into home-assistant:dev Aug 25, 2021
@raman325 raman325 deleted the template_select branch August 25, 2021 18:23
raman325 added a commit to raman325/home-assistant that referenced this pull request Aug 25, 2021
@raman325
Merge remote-tracking branch 'upstream/dev' into template_number
118e37b 
* upstream/dev: (588 commits)
  Add select platform to template integration (home-assistant#54835)
  Honeywell Lyric - Entity Descriptions (home-assistant#54956)
  Add tests for Rituals init, sensor and switch (home-assistant#52406)
  Support for EnergyStorageTrait for vacuum cleaners (home-assistant#55134)
  Add support for Xiaomi Miio pedestal fans (home-assistant#55114)
  Sonos add bass & treble EQ option (home-assistant#53978)
  Address review of Nanoleaf Config Flow (home-assistant#55215)
  Implement color_mode support for mysensors (home-assistant#52068)
  Change logging to do rollover() instead of rotate() (home-assistant#55177)
  Support device triggers in HomeKit (home-assistant#53869)
  Remove temperature conversion - sht31 (home-assistant#55213)
  Finish EntityDescription implementation for RainMachine (home-assistant#55180)
  Remove temperature conversion - synology_dsm (home-assistant#55214)
  Report average of position and tilt_position for cover groups (home-assistant#52713)
  Ignore unsupported MeasureType-s from Withings (home-assistant#55205)
  Prevent setting _attr_unit_of_measurement in subclasses of SensorEntity (home-assistant#55211)
  Fix Fjäråskupan RSSI sensor unit (home-assistant#55210)
  ESPHome sensor use total_increasing state class (home-assistant#55208)
  Remove should poll property from Xiaomi Miio fan platform (home-assistant#55201)
  Fix last_reset in utility_meter (home-assistant#55209)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck left review comments

@bdraco bdraco bdraco left review comments

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
cla-signed has-tests integration: template new-feature new-platform smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@raman325 @frenck @bdraco @balloob @homeassistant