Add tests for Rituals init, sensor and switch #52406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
code-quality
has-tests
integration: rituals_perfume_genie
small-pr
MartinHjelmare
changed the title
milanmeu
force-pushed
the
rituals-test-part1
branch
from
26c5a3d to
0197f24
Compare
bdraco
reviewed
Aug 24, 2021
bdraco
requested changes
Aug 24, 2021
milanmeu
force-pushed
the
rituals-test-part1
branch
from
66d5516 to
98be99f
Compare
milanmeu
force-pushed
the
rituals-test-part1
branch
from
98be99f to
b422204
Compare
bdraco
approved these changes
Aug 25, 2021
raman325
added a commit
to raman325/home-assistant
that referenced
this pull request
Aug 25, 2021
* upstream/dev: (588 commits) Add select platform to template integration (home-assistant#54835) Honeywell Lyric - Entity Descriptions (home-assistant#54956) Add tests for Rituals init, sensor and switch (home-assistant#52406) Support for EnergyStorageTrait for vacuum cleaners (home-assistant#55134) Add support for Xiaomi Miio pedestal fans (home-assistant#55114) Sonos add bass & treble EQ option (home-assistant#53978) Address review of Nanoleaf Config Flow (home-assistant#55215) Implement color_mode support for mysensors (home-assistant#52068) Change logging to do rollover() instead of rotate() (home-assistant#55177) Support device triggers in HomeKit (home-assistant#53869) Remove temperature conversion - sht31 (home-assistant#55213) Finish EntityDescription implementation for RainMachine (home-assistant#55180) Remove temperature conversion - synology_dsm (home-assistant#55214) Report average of position and tilt_position for cover groups (home-assistant#52713) Ignore unsupported MeasureType-s from Withings (home-assistant#55205) Prevent setting _attr_unit_of_measurement in subclasses of SensorEntity (home-assistant#55211) Fix Fjäråskupan RSSI sensor unit (home-assistant#55210) ESPHome sensor use total_increasing state class (home-assistant#55208) Remove should poll property from Xiaomi Miio fan platform (home-assistant#55201) Fix last_reset in utility_meter (home-assistant#55209) ...
| diffuser = mock_diffuser_v1_battery_cartridge() | ||
| await init_integration(hass, config_entry, [diffuser]) | ||
| await async_setup_component(hass, "homeassistant", {}) | ||
| coordinator = hass.data[DOMAIN][config_entry.entry_id][COORDINATORS]["lot123v1"] |
There was a problem hiding this comment.
Please don't access integration details like hass.data in the tests. Avoiding that will make the tests more robust.
https://developers.home-assistant.io/docs/development_testing#writing-tests-for-integrations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add tests for
__init__.py,sensor.pyandswitch.py.Also added a file
common.pyfor test helpers.Removed tested files from
.coveragerc.This is my first time writing test for an integration init and platforms.
So I didn't write test for all of them yet (so I can learn from this PR).
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: