Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EntityDescription - rainmachine #55021

Merged
merged 2 commits into from
Aug 23, 2021
Merged

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Aug 22, 2021

Proposed change

Update rainmachine to use EntityDescription for sensor metadata.
-> #53201

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

@probot-home-assistant
Copy link

Hey there @bachya, mind taking a look at this pull request as it has been labeled with an integration (rainmachine) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@cdce8p cdce8p added the project-code_style PRs related to #53201 - pylint CodeStyle update label Aug 22, 2021
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Aug 22, 2021
Copy link
Contributor

@bachya bachya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not as familiar with the architecture rationale for this change, so I'll leave that to someone else. Functionally, the integration works fine with this change. 👍🏻

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a production install 👍

@bdraco bdraco merged commit 8522538 into home-assistant:dev Aug 23, 2021
@cdce8p cdce8p deleted the cs_04_rainmachine branch August 23, 2021 19:43
@cdce8p
Copy link
Member Author

cdce8p commented Aug 23, 2021

Thank you both for testing it!

@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed code-quality integration: rainmachine project-code_style PRs related to #53201 - pylint CodeStyle update smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants