Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honeywell Lyric - Entity Descriptions #54956

Merged

Conversation

timmo001
Copy link
Contributor

Proposed change

Converts sensors and climate platform to use entity descriptions.

Type of change

  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • 🥈 Silver

To help with the load of incoming pull requests:

@@ -189,6 +173,6 @@ def device_info(self) -> DeviceInfo:
return {
"connections": {(dr.CONNECTION_NETWORK_MAC, self._mac_id)},
"manufacturer": "Honeywell",
"model": self._device_model,
"name": self._device_name,
"model": self.device.deviceModel,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see self.device defined.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's here:

@property
def device(self) -> LyricDevice:
"""Get the Lyric Device."""
return self.location.devices_dict[self._mac_id]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The coordinator holds the location, which again holds the device, there is no need to pass location or device to the class when the coordinator is passed to it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are multipe locations

image

@timmo001 timmo001 force-pushed the honeywell-lyric-entity-descriptions branch from e646a35 to d8a4dd4 Compare August 21, 2021 12:36
@timmo001 timmo001 force-pushed the honeywell-lyric-entity-descriptions branch from 1ac2d84 to 22c716b Compare August 21, 2021 14:24
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Aug 21, 2021
@balloob balloob merged commit e062d7a into home-assistant:dev Aug 25, 2021
@timmo001 timmo001 deleted the honeywell-lyric-entity-descriptions branch August 25, 2021 17:33
raman325 added a commit to raman325/home-assistant that referenced this pull request Aug 25, 2021
* upstream/dev: (588 commits)
  Add select platform to template integration (home-assistant#54835)
  Honeywell Lyric - Entity Descriptions (home-assistant#54956)
  Add tests for Rituals init, sensor and switch (home-assistant#52406)
  Support for EnergyStorageTrait for vacuum cleaners (home-assistant#55134)
  Add support for Xiaomi Miio pedestal fans (home-assistant#55114)
  Sonos add bass & treble EQ option (home-assistant#53978)
  Address review of Nanoleaf Config Flow (home-assistant#55215)
  Implement color_mode support for mysensors (home-assistant#52068)
  Change logging to do rollover() instead of rotate() (home-assistant#55177)
  Support device triggers in HomeKit (home-assistant#53869)
  Remove temperature conversion - sht31 (home-assistant#55213)
  Finish EntityDescription implementation for RainMachine (home-assistant#55180)
  Remove temperature conversion - synology_dsm (home-assistant#55214)
  Report average of position and tilt_position for cover groups (home-assistant#52713)
  Ignore unsupported MeasureType-s from Withings (home-assistant#55205)
  Prevent setting _attr_unit_of_measurement in subclasses of SensorEntity (home-assistant#55211)
  Fix Fjäråskupan RSSI sensor unit (home-assistant#55210)
  ESPHome sensor use total_increasing state class (home-assistant#55208)
  Remove should poll property from Xiaomi Miio fan platform (home-assistant#55201)
  Fix last_reset in utility_meter (home-assistant#55209)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cla-signed code-quality integration: lyric smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants