-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Honeywell Lyric - Entity Descriptions #54956
Honeywell Lyric - Entity Descriptions #54956
Conversation
@@ -189,6 +173,6 @@ def device_info(self) -> DeviceInfo: | |||
return { | |||
"connections": {(dr.CONNECTION_NETWORK_MAC, self._mac_id)}, | |||
"manufacturer": "Honeywell", | |||
"model": self._device_model, | |||
"name": self._device_name, | |||
"model": self.device.deviceModel, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see self.device
defined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's here:
core/homeassistant/components/lyric/__init__.py
Lines 161 to 164 in 531c6be
@property | |
def device(self) -> LyricDevice: | |
"""Get the Lyric Device.""" | |
return self.location.devices_dict[self._mac_id] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The coordinator holds the location, which again holds the device, there is no need to pass location or device to the class when the coordinator is passed to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e646a35
to
d8a4dd4
Compare
1ac2d84
to
22c716b
Compare
* upstream/dev: (588 commits) Add select platform to template integration (home-assistant#54835) Honeywell Lyric - Entity Descriptions (home-assistant#54956) Add tests for Rituals init, sensor and switch (home-assistant#52406) Support for EnergyStorageTrait for vacuum cleaners (home-assistant#55134) Add support for Xiaomi Miio pedestal fans (home-assistant#55114) Sonos add bass & treble EQ option (home-assistant#53978) Address review of Nanoleaf Config Flow (home-assistant#55215) Implement color_mode support for mysensors (home-assistant#52068) Change logging to do rollover() instead of rotate() (home-assistant#55177) Support device triggers in HomeKit (home-assistant#53869) Remove temperature conversion - sht31 (home-assistant#55213) Finish EntityDescription implementation for RainMachine (home-assistant#55180) Remove temperature conversion - synology_dsm (home-assistant#55214) Report average of position and tilt_position for cover groups (home-assistant#52713) Ignore unsupported MeasureType-s from Withings (home-assistant#55205) Prevent setting _attr_unit_of_measurement in subclasses of SensorEntity (home-assistant#55211) Fix Fjäråskupan RSSI sensor unit (home-assistant#55210) ESPHome sensor use total_increasing state class (home-assistant#55208) Remove should poll property from Xiaomi Miio fan platform (home-assistant#55201) Fix last_reset in utility_meter (home-assistant#55209) ...
Proposed change
Converts sensors and climate platform to use entity descriptions.
Type of change
Checklist
black --fast homeassistant tests
)If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: