Deduplicate code in MQTT basic light#50530
Closed
emontnemery wants to merge 1 commit intohome-assistant:devfrom
Closed
Deduplicate code in MQTT basic light#50530emontnemery wants to merge 1 commit intohome-assistant:devfrom
emontnemery wants to merge 1 commit intohome-assistant:devfrom
Conversation
probot-home-assistant
Bot
added
code-quality
core
has-tests
integration: mqtt
by-code-owner
labels
This was referenced May 12, 2021
thecode
reviewed
May 17, 2021
| def restore_state(attribute, condition): | ||
| """Restore a state attribute.""" | ||
| if condition and last_state and last_state.attributes.get(attribute): | ||
| setattr(self, f"_{attribute}", last_state.attributes.get(attribute)) |
Member
There was a problem hiding this comment.
Suggested change
| setattr(self, f"_{attribute}", last_state.attributes.get(attribute)) | |
| setattr(self, f"_{attribute}", last_state.attributes[attribute]) |
| and last_state.attributes.get(ATTR_HS_COLOR) | ||
| ): | ||
| self._hs = last_state.attributes.get(ATTR_HS_COLOR) | ||
| self._hs_color = last_state.attributes.get(ATTR_HS_COLOR) |
Member
There was a problem hiding this comment.
Why can't we use restore_state helper here?
| "qos": self._config[CONF_QOS], | ||
| } | ||
| add_topic(CONF_XY_STATE_TOPIC, xy_received) | ||
| restore_state(ATTR_XY_COLOR, self._optimistic_xy) |
Member
There was a problem hiding this comment.
What code did we replace with the restore helper here?
21 tasks
This was referenced May 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Deduplicate code in MQTT basic light
Replaced with 1 PR for each added helper:
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: