Skip to content

Deduplicate code in MQTT basic light pt2: Add restore_state helper#50766

Merged
emontnemery merged 2 commits intohome-assistant:devfrom
emontnemery:mqtt_basic_light_refactor_2
May 17, 2021
Merged

Deduplicate code in MQTT basic light pt2: Add restore_state helper#50766
emontnemery merged 2 commits intohome-assistant:devfrom
emontnemery:mqtt_basic_light_refactor_2

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery commented May 17, 2021

Proposed change

Deduplicate code in MQTT basic light pt2: Add restore_state helper

This is part 2 of #50530

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Comment thread homeassistant/components/mqtt/light/schema_basic.py Outdated
Comment thread homeassistant/components/mqtt/light/schema_basic.py Outdated
Co-authored-by: Shay Levy <levyshay1@gmail.com>
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@emontnemery emontnemery merged commit b36021b into home-assistant:dev May 17, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants