Skip to content

Add color_mode support to MQTT light with basic schema#50464

Merged
emontnemery merged 5 commits intohome-assistant:devfrom
emontnemery:mqtt_basic_light_color_mode
May 24, 2021
Merged

Add color_mode support to MQTT light with basic schema#50464
emontnemery merged 5 commits intohome-assistant:devfrom
emontnemery:mqtt_basic_light_color_mode

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

Proposed change

Add color_mode support to MQTT light with basic schema

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@emontnemery
Copy link
Copy Markdown
Contributor Author

Refactoring moved to #50530

@emontnemery emontnemery force-pushed the mqtt_basic_light_color_mode branch from 3330861 to 1cecddc Compare May 17, 2021 21:59
@emontnemery emontnemery marked this pull request as ready for review May 17, 2021 22:00
should_update |= set_optimistic(ATTR_RGBWW_COLOR, rgbww, COLOR_MODE_RGBWW)

if (
(xy := kwargs.get(ATTR_XY_COLOR)) # pylint: disable=invalid-name
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(xy := kwargs.get(ATTR_XY_COLOR)) # pylint: disable=invalid-name
(xy_color := kwargs.get(ATTR_XY_COLOR))

@emontnemery emontnemery merged commit 870c61a into home-assistant:dev May 24, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants