Deduplicate code in MQTT basic light pt1: Add add_topic helper#50759
Merged
emontnemery merged 1 commit intohome-assistant:devfrom May 17, 2021
Merged
Conversation
emontnemery
commented
May 17, 2021
| } | ||
| elif ( | ||
| add_topic(CONF_BRIGHTNESS_STATE_TOPIC, brightness_received) | ||
| if ( |
Contributor
Author
There was a problem hiding this comment.
The elif was not correct, we should restore the state if self._optimistic_brightness is True
| } | ||
| elif ( | ||
| add_topic(CONF_WHITE_VALUE_STATE_TOPIC, white_value_received) | ||
| if ( |
Contributor
Author
There was a problem hiding this comment.
The elif was not correct, we should restore the state if self._optimistic_white_value is True
21 tasks
thecode
approved these changes
May 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Deduplicate code in MQTT basic light pt1: Add add_topic helper
This is part 1 of #50530
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: