Refactor MQTT basic light pt5: Add RGB color helpers#50780
Merged
emontnemery merged 2 commits intohome-assistant:devfrom May 17, 2021
Merged
Refactor MQTT basic light pt5: Add RGB color helpers#50780emontnemery merged 2 commits intohome-assistant:devfrom
emontnemery merged 2 commits intohome-assistant:devfrom
Conversation
probot-home-assistant
Bot
added
code-quality
core
has-tests
integration: mqtt
by-code-owner
labels
| mqtt_mock.async_publish.assert_has_calls( | ||
| [ | ||
| call("test_light/rgb", "1,0,0", 0, False), | ||
| call("test_light/rgb", "1,1,0", 0, False), |
Contributor
Author
There was a problem hiding this comment.
It's changed because the colors channels are now rounded instead of being truncated in the helper scale_rgbx, which should be more correct.
There's however a lot of truncating going on in util/color.py, so maybe we should not change the behavior from truncation to rounding in this PR but instead consider that for a separate PR?
Member
There was a problem hiding this comment.
If you're ok with it I'm ok with it. It's just a red flag for me when tests need to change during refactors. That's why I asked.
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Refactor MQTT basic light pt5: Add RGB color helpers
Also fix some cases where we returned lists instead of tuples as specified in the base components.
This is part 5 of #50530
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: