Dynalite Integration#27621
Closed
ziv1234 wants to merge 113 commits into
Closed
Conversation
Contributor
probot-home-assistant
Bot
added
Hacktoberfest
new-integration
integration: dynalite
labels
* yandex maps api changed ("threads" in "Transport" added), ya_ma=>0.3.8 bug_fixed
* Update homeassistant/components/yandex_transport/sensor.py
Co-Authored-By: Paulus Schoutsen <paulus@home-assistant.io>
* additional fix
* reformat
* fix mistake
* move imports to top-level * modify patch path * removed unused mocks and patches
ziv1234
requested review from
a team,
Adminiuga,
Danielhiversen,
Kane610,
OttoWinter,
danielperna84,
dmulcahey,
emlove,
fabaff,
hunterjm,
pvizeli,
robbiet480,
rytilahti and
zxdavb
as code owners
Contributor
Author
|
added unit tests and now it fully goes through the CI. I know that the documentation is missing, but wanted to know if this is something that you are likely to accept since I wouldn't want to spend a lot of time on good documentation that no one will read :) Of course, if there is anything else that I can do to help, please let me know |
Member
|
It seems like you have some commits in this branch that are not yours, please clean it up. |
Contributor
Author
|
I pulled from the upstream branch, so these are all commits that were already accepted. I followed the “keeping up with reality” section in the docs.
Do you want me to create a new, clean fork? Is there any other way to cancel these pulled commits?
From: Paulus Schoutsen <notifications@github.com>
Sent: Friday, October 18, 2019 3:55 AM
To: home-assistant/home-assistant <home-assistant@noreply.github.com>
Cc: Ziv <zivk@hotmail.com>; Mention <mention@noreply.github.com>
Subject: Re: [home-assistant/home-assistant] Dynalite Integration (#27621)
It seems like you have some commits in this branch that are not yours, please clean it up.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#27621>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AD5UNS5ZN6H3TJHY5IHGLTDQPECOFANCNFSM4JAIXR5A>.
|
Contributor
Author
|
I created a new branch and a new pull request that is now clean. Will not pull more from upstream…
From: Paulus Schoutsen <notifications@github.com>
Sent: Friday, October 18, 2019 3:55 AM
To: home-assistant/home-assistant <home-assistant@noreply.github.com>
Cc: Ziv <zivk@hotmail.com>; Mention <mention@noreply.github.com>
Subject: Re: [home-assistant/home-assistant] Dynalite Integration (#27621)
It seems like you have some commits in this branch that are not yours, please clean it up.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#27621>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AD5UNS5ZN6H3TJHY5IHGLTDQPECOFANCNFSM4JAIXR5A>.
|
Contributor
Author
|
closed since there is an updated pull request, 27841 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change:
Not a breaking change. Only adds a new integration
Description:
I used Troy Kelly's library and component as a starting point, added several features to them, and am now able to control my full house which is based on Dynalite. I know that no other open-source system supports it, so will be glad if it can go into the mainstream, so others can use it as well. Will also be happy to make fixes to issues that come.
Since I am new to open-source development, wanted to understand what is needed to get this merged. One thing that is clearly lacking today is documentation, since this is something that is only worthwhile investing in if others will read it, so if you tell me that this should be integrated into HA, I will quickly document it.
I tried to follow the guidelines in the dev docs, but I am sure that there are some things that I missed. If this is interesting to add, please let me know if there is anything other than the documentation that needs fixing and i will take care of it quickly.
Best,
Ziv
Related issue (if applicable): fixes #
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: