Skip to content

Move imports to top for FFMPEG#27613

Merged
pvizeli merged 1 commit into
home-assistant:devfrom
stevendlander:Issue_#27288-move-imports-to-top-ffmpeg
Oct 14, 2019
Merged

Move imports to top for FFMPEG#27613
pvizeli merged 1 commit into
home-assistant:devfrom
stevendlander:Issue_#27288-move-imports-to-top-ffmpeg

Conversation

@stevendlander
Copy link
Copy Markdown
Contributor

@stevendlander stevendlander commented Oct 13, 2019

Description:

Related issue (if applicable):
#27288
#27284

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @stevendlander,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@MartinHjelmare MartinHjelmare changed the title Issue #27288 Move imports to top for FFMPEG Move imports to top for FFMPEG Oct 14, 2019
@home-assistant home-assistant deleted a comment from homeassistant Oct 14, 2019
@home-assistant home-assistant deleted a comment from homeassistant Oct 14, 2019
@pvizeli pvizeli merged commit b7023a9 into home-assistant:dev Oct 14, 2019
@stevendlander stevendlander deleted the Issue_#27288-move-imports-to-top-ffmpeg branch October 14, 2019 13:58
@lock lock Bot locked and limited conversation to collaborators Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants