Skip to content

Fix ViCare temperature and heating mode#27604

Merged
pvizeli merged 1 commit into
home-assistant:devfrom
crazyfx1:fix-climate-temperature
Oct 14, 2019
Merged

Fix ViCare temperature and heating mode#27604
pvizeli merged 1 commit into
home-assistant:devfrom
crazyfx1:fix-climate-temperature

Conversation

@crazyfx1
Copy link
Copy Markdown
Contributor

Description:

Fixes:

  • Missing ViCare-Mode "dhwAndHeatingCooling" for heatings which are capable of cooling
  • Set Temperature not using the actual temperature

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@probot-home-assistant
Copy link
Copy Markdown

Hey there @oischinger, mind taking a look at this pull request as its been labeled with a integration (vicare) you are listed as a codeowner for? Thanks!

@fabaff fabaff changed the title ViCare: Fix temperature and heating mode Fix ViCare temperature and heating mode Oct 13, 2019
"""Set new target temperatures."""
temp = kwargs.get(ATTR_TEMPERATURE)
if temp is not None:
self._api.setProgramTemperature(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@pvizeli pvizeli merged commit d7d7f6a into home-assistant:dev Oct 14, 2019
@crazyfx1 crazyfx1 deleted the fix-climate-temperature branch October 14, 2019 16:25
@lock lock Bot locked and limited conversation to collaborators Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants