ESPHome Fix intermediary state published#27638
Merged
pvizeli merged 1 commit intoOct 14, 2019
Merged
Conversation
pvizeli
reviewed
Oct 14, 2019
pvizeli
approved these changes
Oct 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes esphome/issues#426
Description:
There was an issue with ESPHome entities where they would publish old states when coming back online because of some internal mechanics.
Scenario:
23.0unavailable.23.0is published18.0This PR basically disables the state update scheduling in step 3. In hindsight, it's an oversight in the communication protocol that the initial state is not sent together in the packet with the entity info, but now it can't be changed that easily.
Related issue (if applicable): fixes #
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests pass