Skip to content

Move imports in config component#27641

Merged
andrewsayre merged 1 commit into
home-assistant:devfrom
Bouni:move_config_imports
Oct 14, 2019
Merged

Move imports in config component#27641
andrewsayre merged 1 commit into
home-assistant:devfrom
Bouni:move_config_imports

Conversation

@Bouni
Copy link
Copy Markdown
Contributor

@Bouni Bouni commented Oct 14, 2019

Breaking Change:

None

Description:

Moved import from function to top-level as requested in #27284

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

Note: imports sorted using isort

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (config) you are listed as a codeowner for? Thanks!

@Bouni
Copy link
Copy Markdown
Contributor Author

Bouni commented Oct 14, 2019

Not sure what to do with the importlib at line 40 of the init.py file

@andrewsayre
Copy link
Copy Markdown
Member

Not sure what to do with the importlib at line 40 of the init.py file

It's fine as is.

@andrewsayre andrewsayre merged commit 6d4e394 into home-assistant:dev Oct 14, 2019
@lock lock Bot locked and limited conversation to collaborators Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants