Revert "Revert "Update mqtt-autodiscovery.sh""#1135
Merged
jmtatsch merged 1 commit intoAug 28, 2019
Merged
Conversation
This reverts commit 54a1013.
Collaborator
|
Can you maybe open an issue with home assistant why its not working as it should? |
Contributor
Author
|
I've already opened PR to add device to mqtt camera, lets hope it will be merged soon. home-assistant/core#26238 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1131
After verification in source code, looks like mqtt camera still doesn't support device attribute ( tested on newest HA 0.97.2 ). Docs ( https://www.home-assistant.io/components/camera.mqtt/#device ) states it should be supported but it gives error about unsupported key, and can't find any info about device in mqtt.camera code in HA. I think this should be reverted for now. I will try to add device in ha mqtt camera first and then it could be reenabled. Sorry for confusion.