Skip to content

Update radiotherm to 2.0.0 and handle change in tstat error detection#19107

Merged
fabaff merged 2 commits intohome-assistant:devfrom
craftyguy:dev
Dec 9, 2018
Merged

Update radiotherm to 2.0.0 and handle change in tstat error detection#19107
fabaff merged 2 commits intohome-assistant:devfrom
craftyguy:dev

Conversation

@craftyguy
Copy link
Copy Markdown
Contributor

@craftyguy craftyguy commented Dec 7, 2018

Description:

Updates the radiotherm module version to 2.0.0 and changes how errors from the tstat are handled to be in line with the change in API in radiothermm 2.0.0.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@craftyguy
radiotherm: bump version to 2.0.0
dab74f6
@craftyguy
radiotherm: change handling of transient errors from tstat
4a48e2f 
Radiotherm 2.0.0 now throws an exception when a transient error is
detected, instead of returning -1 for the field where the error was
detected. This change supports handling the exception.
@ghost ghost added the in progress label Dec 7, 2018
@craftyguy craftyguy mentioned this pull request Dec 7, 2018
Closed
fabaff
fabaff approved these changes Dec 9, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 866c2ca into home-assistant:dev Dec 9, 2018
@ghost ghost removed the in progress label Dec 9, 2018
thibmaek added a commit to thibmaek/home-assistant that referenced this pull request Dec 10, 2018
@thibmaek
Merge branch 'dev' of https://github.com/home-assistant/home-assistant …
39a88b0 
…into feature/nmbs-sensor

* 'dev' of https://github.com/home-assistant/home-assistant: (325 commits)
  Update translations
  Updated frontend to 20181210.0
  Lovelace using storage (home-assistant#19101)
  Update pygtfs to upstream's 0.1.5 (home-assistant#19151)
  Update radiotherm to 2.0.0 and handle change in tstat error detection (home-assistant#19107)
  Upgrade sphinx-autodoc-typehints to 1.5.2 (home-assistant#19140)
  Update geizhals dependency (home-assistant#19152)
  Upgrade mypy to 0.650 (home-assistant#19150)
  Upgrade upcloud-api to 0.4.3
  Upgrade youtube_dl to 2018.12.03 (home-assistant#19139)
  Upgrade slacker to 0.12.0
  Add code support for iAlarm (home-assistant#19124)
  Fixed doorbird config without events (empty list) (home-assistant#19121)
  Remove marking device tracker stale if state is stale (home-assistant#19133)
  Update Google Assistant services description and request sync timeout (home-assistant#19113)
  update edp_redy version (home-assistant#19078)
  Add Philips Moonlight Bedside Lamp support (home-assistant#18496)
  Upgrade Mill library (home-assistant#19117)
  Don't avoid async_schedule_update_ha_state by returning false (home-assistant#19102)
  Fix the Xiaomi Aqara Cube rotate event of the LAN protocol 2.0 (Closes: home-assistant#18199) (home-assistant#19104)
  ...
thibmaek added a commit to thibmaek/home-assistant that referenced this pull request Dec 12, 2018
@thibmaek
Merge remote-tracking branch 'origin/dev' into feature/vrtnws-sensor
94a35b4 
* origin/dev: (333 commits)
  Add raw service data to event (home-assistant#19163)
  Updated frontend to 20181210.1
  Google assistant fix target temp for *F values. (home-assistant#19083)
  Fix lovelace save (home-assistant#19162)
  Drop OwnTracks bad packets (home-assistant#19161)
  Update translations
  Updated frontend to 20181210.0
  Lovelace using storage (home-assistant#19101)
  Update pygtfs to upstream's 0.1.5 (home-assistant#19151)
  Update radiotherm to 2.0.0 and handle change in tstat error detection (home-assistant#19107)
  Upgrade sphinx-autodoc-typehints to 1.5.2 (home-assistant#19140)
  Update geizhals dependency (home-assistant#19152)
  Upgrade mypy to 0.650 (home-assistant#19150)
  Upgrade upcloud-api to 0.4.3
  Upgrade youtube_dl to 2018.12.03 (home-assistant#19139)
  Upgrade slacker to 0.12.0
  Add code support for iAlarm (home-assistant#19124)
  Fixed doorbird config without events (empty list) (home-assistant#19121)
  Remove marking device tracker stale if state is stale (home-assistant#19133)
  Update Google Assistant services description and request sync timeout (home-assistant#19113)
  ...
@balloob balloob mentioned this pull request Jan 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabaff fabaff fabaff approved these changes

Assignees

No one assigned

Labels

cla-signed integration: radiotherm small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@craftyguy @fabaff @homeassistant