Conversation
ghost
assigned
balloob
added a commit
that referenced
this pull request
Dec 10, 2018
thibmaek
added a commit
to thibmaek/home-assistant
that referenced
this pull request
Dec 10, 2018
…/nmbs-sensor * 'dev' of github.com:thibmaek/home-assistant: Add raw service data to event (home-assistant#19163) Updated frontend to 20181210.1 Google assistant fix target temp for *F values. (home-assistant#19083) Fix lovelace save (home-assistant#19162) Drop OwnTracks bad packets (home-assistant#19161) home-assistant#18645: revert heat-cool -> auto change home-assistant#18645: Remove un-used constants. home-assistant#18645: Fix climate mode mapping.
Merged
thibmaek
added a commit
to thibmaek/home-assistant
that referenced
this pull request
Dec 12, 2018
* origin/dev: (333 commits) Add raw service data to event (home-assistant#19163) Updated frontend to 20181210.1 Google assistant fix target temp for *F values. (home-assistant#19083) Fix lovelace save (home-assistant#19162) Drop OwnTracks bad packets (home-assistant#19161) Update translations Updated frontend to 20181210.0 Lovelace using storage (home-assistant#19101) Update pygtfs to upstream's 0.1.5 (home-assistant#19151) Update radiotherm to 2.0.0 and handle change in tstat error detection (home-assistant#19107) Upgrade sphinx-autodoc-typehints to 1.5.2 (home-assistant#19140) Update geizhals dependency (home-assistant#19152) Upgrade mypy to 0.650 (home-assistant#19150) Upgrade upcloud-api to 0.4.3 Upgrade youtube_dl to 2018.12.03 (home-assistant#19139) Upgrade slacker to 0.12.0 Add code support for iAlarm (home-assistant#19124) Fixed doorbird config without events (empty list) (home-assistant#19121) Remove marking device tracker stale if state is stale (home-assistant#19133) Update Google Assistant services description and request sync timeout (home-assistant#19113) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
We were returning 400 to OwnTracks when receiving bad packets, which meant that OwnTracks kept trying to repost the same bad packet. Now we return 200 and hope the next packet is better!
Related issue (if applicable): #18927
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: