Skip to content

Update radiotherm to 2.0.0 and handle change in tstat error detection #19107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fabaff merged 2 commits into from
Dec 9, 2018
Merged

Update radiotherm to 2.0.0 and handle change in tstat error detection #19107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dab74f6
radiotherm: bump version to 2.0.0
craftyguy Dec 7, 2018
4a48e2f
radiotherm: change handling of transient errors from tstat
craftyguy Dec 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions homeassistant/components/climate/radiotherm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
CONF_HOST, TEMP_FAHRENHEIT, ATTR_TEMPERATURE, PRECISION_HALVES)
import homeassistant.helpers.config_validation as cv

REQUIREMENTS = ['radiotherm==1.4.1']
REQUIREMENTS = ['radiotherm==2.0.0']

_LOGGER = logging.getLogger(__name__)

Expand Down Expand Up @@ -235,13 +235,15 @@ def update(self):
self._name = self.device.name['raw']

# Request the current state from the thermostat.
data = self.device.tstat['raw']
import radiotherm
try:
data = self.device.tstat['raw']
except radiotherm.validate.RadiothermTstatError:
_LOGGER.error('%s (%s) was busy (invalid value returned)',
self._name, self.device.host)
return

current_temp = data['temp']
if current_temp == -1:
_LOGGER.error('%s (%s) was busy (temp == -1)', self._name,
self.device.host)
return

# Map thermostat values into various STATE_ flags.
self._current_temperature = current_temp
Expand Down
2 changes: 1 addition & 1 deletion requirements_all.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1352,7 +1352,7 @@ quantum-gateway==0.0.3
rachiopy==0.1.3

# homeassistant.components.climate.radiotherm
radiotherm==1.4.1
radiotherm==2.0.0

# homeassistant.components.raincloud
raincloudy==0.0.5
Expand Down