Skip to content

Google assistant fix target temp for *F values.#19083

Merged
balloob merged 5 commits intohome-assistant:devfrom
marchingphoenix:google_assistant-fix_target_temp
Dec 10, 2018
Merged

Google assistant fix target temp for *F values.#19083
balloob merged 5 commits intohome-assistant:devfrom
marchingphoenix:google_assistant-fix_target_temp

Conversation

@marchingphoenix
Copy link
Copy Markdown
Contributor

Description:

Round *F values to INT to make the GH app behave.

Related issue (if applicable): fixes #18524

Pull request in home-assistant.io with documentation (if applicable): N/A

Example entry for configuration.yaml (if applicable):

N/A

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.
    N/A

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

(thanks github editor)
@balloob balloob added this to the 0.84.0 milestone Dec 10, 2018
@balloob balloob merged commit df2f476 into home-assistant:dev Dec 10, 2018
@ghost ghost removed the in progress label Dec 10, 2018
balloob pushed a commit that referenced this pull request Dec 10, 2018
* #18524 : Add rounding to *F temps

* #18524 : Linting

* simplify round behavior

* fix trailing whitespace

(thanks github editor)
@marchingphoenix marchingphoenix deleted the google_assistant-fix_target_temp branch December 10, 2018 14:01
thibmaek added a commit to thibmaek/home-assistant that referenced this pull request Dec 10, 2018
…/nmbs-sensor

* 'dev' of github.com:thibmaek/home-assistant:
  Add raw service data to event (home-assistant#19163)
  Updated frontend to 20181210.1
  Google assistant fix target temp for *F values. (home-assistant#19083)
  Fix lovelace save (home-assistant#19162)
  Drop OwnTracks bad packets (home-assistant#19161)
  home-assistant#18645: revert heat-cool -> auto change
  home-assistant#18645: Remove un-used constants.
  home-assistant#18645: Fix climate mode mapping.
@balloob balloob mentioned this pull request Dec 12, 2018
thibmaek added a commit to thibmaek/home-assistant that referenced this pull request Dec 12, 2018
* origin/dev: (333 commits)
  Add raw service data to event (home-assistant#19163)
  Updated frontend to 20181210.1
  Google assistant fix target temp for *F values. (home-assistant#19083)
  Fix lovelace save (home-assistant#19162)
  Drop OwnTracks bad packets (home-assistant#19161)
  Update translations
  Updated frontend to 20181210.0
  Lovelace using storage (home-assistant#19101)
  Update pygtfs to upstream's 0.1.5 (home-assistant#19151)
  Update radiotherm to 2.0.0 and handle change in tstat error detection (home-assistant#19107)
  Upgrade sphinx-autodoc-typehints to 1.5.2 (home-assistant#19140)
  Update geizhals dependency (home-assistant#19152)
  Upgrade mypy to 0.650 (home-assistant#19150)
  Upgrade upcloud-api to 0.4.3
  Upgrade youtube_dl to 2018.12.03 (home-assistant#19139)
  Upgrade slacker to 0.12.0
  Add code support for iAlarm (home-assistant#19124)
  Fixed doorbird config without events (empty list) (home-assistant#19121)
  Remove marking device tracker stale if state is stale (home-assistant#19133)
  Update Google Assistant services description and request sync timeout (home-assistant#19113)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Google Assistant and Homekit sending wrong target temp values

5 participants