Skip to content

[Backport] Resolved : Wishlist icon cut on Shopping cart page in mobile view #17851#28

Merged
hitesh-wagento merged 490 commits into
2.1-developfrom
2.1-develop-PR-port-17877
Sep 4, 2018
Merged

[Backport] Resolved : Wishlist icon cut on Shopping cart page in mobile view #17851#28
hitesh-wagento merged 490 commits into
2.1-developfrom
2.1-develop-PR-port-17877

Conversation

@hitesh-wagento
Copy link
Copy Markdown
Owner

Original Pull Request

magento#17877

Summary

Wishlist icon cut on Shopping cart page in mobile view.

Issue : magento#17851

Preconditions

  1. Magento 2x - This issue reproduce in all version.

Steps to reproduce

  1. Login in your frontend.
  2. Add any product in Cart.
  3. Go to Shopping cart.
  4. Switch mobile view.

Expected result

  1. Wishlist icon should not cut in mobile view.
    screen shot 2018-08-29 at 17 16 32

Actual result

  1. Wishlist icon cut in mobile view.

wishlist-icon

magento-engcom-team and others added 30 commits July 26, 2018 23:47
…ences. magento#17157

 - Merge Pull Request magento#17157 from gelanivishal/magento2:2.1-develop-PR-port-16182
 - Merged commits:
   1. ceb9d11
   2. f8f2b20
…ontains default date "1/1/1970" instead of empty field.
…ries to register with sa magento#17182

 - Merge Pull Request magento#17182 from gelanivishal/magento2:2.1-develop-PR-port-15272
 - Merged commits:
   1. ff550b4
   2. 158e977
   3. 7359a16
   4. f49cf3d
   5. f08d932
…onfig fixture. Set the schedule for every minute so that the job is scheduled regardless of the time when you run the test.
Accepted Public Pull Requests:
 - magento#17160: [Backport] Improve "Invalid country code" error message on tax import (by @gelanivishal)
 - magento#17159: [Backport] Add Confirm Modal Width (by @gelanivishal)
 - magento#17090: [Backport] Inconsistent Redirect in Admin Notification Controller (by @mageprince)
 - magento#16992: [Backport] Refactor JavsScript for UrlRewrite module edit page. (by @chirag-wagento)


Fixed GitHub Issues:
 - magento#15356: Refactore javascript for module URL rewrite (reported by @vgelani) has been fixed in magento#16992 by @chirag-wagento in 2.1-develop branch
   Related commits:
     1. 846347d
Accepted Public Pull Requests:
 - magento#17157: [Backport] Removed double occurrence of keywords in sentences. (by @gelanivishal)
 - magento#17136: [Backport] Remove commented code (by @mage2pratik)
Uniform jquery variable to "$" as this javascript is partially using "jquery" and partially "$".

The line 62 will cause an error in Internet Explorer if $ is not declared.
Stanislav Idolov and others added 28 commits August 20, 2018 18:23
Accepted Public Pull Requests:
 - magento#17684: [Backport] Fix Custom Attribute Group can not translate in catalog/product page (by @dmytro-ch)
…agento#17682

 - Merge Pull Request magento#17682 from dmytro-ch/magento2:2.1-unit-tests-cms-models
 - Merged commits:
   1. bce1dfe
   2. 3096e64
   3. d91aa50
Accepted Public Pull Requests:
 - magento#17689: [Backport] Update time12h javascript validation rule to be compatible with js minify (by @dmytro-ch)


Fixed GitHub Issues:
 - magento#17648: UI validation rule for valid time am/pm doesn't work when js is minified (reported by @markoshust) has been fixed in magento#17689 by @dmytro-ch in 2.1-develop branch
   Related commits:
     1. d942d67
Accepted Public Pull Requests:
 - magento#17682: [Backport] CMS: Add missing unit tests for model classes (by @dmytro-ch)
…rst instead of converting to camel case, which doesn't work for models with underscores
Accepted Public Pull Requests:
 - magento#17702: [Backport] Message list component fix: the message type is always error when parameters specified (by @dmytro-ch)


Fixed GitHub Issues:
 - magento#17700: Message list component: the message type is always error when parameters specified (reported by @dmytro-ch) has been fixed in magento#17702 by @dmytro-ch in 2.1-develop branch
   Related commits:
     1. 831fe2f
magento#17774

 - Merge Pull Request magento#17774 from getjohn/magento2:2.1-develop
 - Merged commits:
   1. 96bf28b
…nto#17606

 - Merge Pull Request magento#17606 from jignesh-baldha/magento2:2.1-develop-PR-port-17561
 - Merged commits:
   1. e4e150a
   2. a8d13e5
   3. 5b68364
   4. 0bec69a
Accepted Public Pull Requests:
 - magento#17606: [Backport] Catalog: Add unit tests for Cron classes (by @jignesh-baldha)
…wyg editors. magento#17855

 - Merge Pull Request magento#17855 from eduard13/magento2:2.1-develop-bp-16733
 - Merged commits:
   1. 99eb521
Accepted Public Pull Requests:
 - magento#17855: [Backport] Fixes black background for png images in wysiwyg editors. (by @eduard13)
 - magento#17774: Fix for ProductLink - setterName was incorrectly being set (by @insanityinside)


Fixed GitHub Issues:
 - magento#14248: Transparent background becomes black for thumbnails of PNG into Wysiwyg editor... (reported by @jb-dg) has been fixed in magento#17855 by @eduard13 in 2.1-develop branch
   Related commits:
     1. 99eb521
… 2.1 back port. magento#17839

 - Merge Pull Request magento#17839 from furseyev/magento2:SynonymAnalyzer-phpunit-2.1-port
 - Merged commits:
   1. a4699c7
   2. adca29f
Accepted Public Pull Requests:
 - magento#17839: [Backport] [Search] Unit test for SynonymAnalyzer model. 2.1 back port. (by @furseyev)
@hitesh-wagento hitesh-wagento merged commit 2d05fbe into 2.1-develop Sep 4, 2018
@hitesh-wagento hitesh-wagento deleted the 2.1-develop-PR-port-17877 branch September 11, 2018 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.