Skip to content

[Backport] Fixes black background for png images in wysiwyg editors.#17855

Merged
magento-engcom-team merged 1 commit into
magento:2.1-developfrom
eduard13:2.1-develop-bp-16733
Aug 31, 2018
Merged

[Backport] Fixes black background for png images in wysiwyg editors.#17855
magento-engcom-team merged 1 commit into
magento:2.1-developfrom
eduard13:2.1-develop-bp-16733

Conversation

@eduard13
Copy link
Copy Markdown
Contributor

@eduard13 eduard13 commented Aug 29, 2018

Original Pull Request

#16733

Description

This PR fixes the black background for png images, which are uploaded in wysiwyg editors. This issue appears only for GD2 image processing library.

Fixed Issues (if relevant)

  1. Transparent background becomes black for thumbnails of PNG into Wysiwyg editor... #14248: Transparent background becomes black for thumbnails of PNG into Wysiwyg editor

Manual testing scenarios

  1. Upload a png image from any wysiwyg editor
  2. The background while previewing of this image should be transparent.
    61eb1dd578

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Component: Framework/Image Release Line: 2.1 labels Aug 29, 2018
@miguelbalparda miguelbalparda mentioned this pull request Aug 29, 2018
Closed
4 tasks
@miguelbalparda
Copy link
Copy Markdown
Contributor

miguelbalparda commented Aug 29, 2018

I just closed #17834 feel free to do the forward port too. Thanks!!!

@eduard13 eduard13 requested a review from rogyar August 30, 2018 06:55
@osrecio osrecio requested review from osrecio and removed request for rogyar August 30, 2018 07:40
@osrecio osrecio assigned osrecio and unassigned rogyar Aug 30, 2018
osrecio
osrecio approved these changes Aug 30, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@osrecio osrecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eduard13 for your Contribution. This PR will be process ASAP.

@magento-engcom-team magento-engcom-team added this to the Release: 2.1.16 milestone Aug 30, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Aug 30, 2018

Hi @osrecio, thank you for the review.
ENGCOM-2898 has been created to process this Pull Request

@sidolov sidolov mentioned this pull request Aug 31, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 99eb521 into magento:2.1-develop Aug 31, 2018
magento-engcom-team pushed a commit that referenced this pull request Aug 31, 2018
ENGCOM-2898: [Backport] Fixes black background for png images in wysi…
2f8a69b 
…wyg editors. #17855
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Aug 31, 2018

Hi @eduard13. Thank you for your contribution.
We will aim to release these changes as part of 2.1.16.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@osrecio osrecio osrecio approved these changes

Assignees

@osrecio osrecio

Labels

Component: Framework/Image Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.1

Projects

None yet

Milestone

Release: 2.1.16

Development

Successfully merging this pull request may close these issues.

5 participants

@eduard13 @miguelbalparda @magento-engcom-team @osrecio @rogyar