Skip to content

[Backport] Improve "Invalid country code" error message on tax import#17160

Merged
magento-engcom-team merged 3 commits intomagento:2.1-developfrom
gelanivishal:2.1-develop-PR-port-16873
Jul 27, 2018
Merged

[Backport] Improve "Invalid country code" error message on tax import#17160
magento-engcom-team merged 3 commits intomagento:2.1-developfrom
gelanivishal:2.1-develop-PR-port-16873

Conversation

@gelanivishal
Copy link
Copy Markdown
Contributor

@gelanivishal gelanivishal commented Jul 26, 2018

Original Pull Request

#16873

Description

This change helps when importing tax CSVs by telling the user which country is responsible for the error being thrown. Without this it is a very annoying error to get and the user just has to guess.

Before:

screen shot 2018-07-17 at 08 44 07

After:

screen shot 2018-07-17 at 08 36 48

Manual testing scenarios

Create a tax import CSV with an inavlid country code, for example:

Code Country State Zip/Post Code Rate Zip/Post is Range Range From Range To
Puerto Rico PR * * 20      

Then attempt to import the CSV by going to Magento Admin > System > Data Transfer > Import/Export Tax Rates

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.1.15.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants