Skip to content

[Backport] hide cookie notice instead of reloading site#17178

Closed
mage2pratik wants to merge 1 commit intomagento:2.1-developfrom
mage2pratik:2.1-develop-PR-port-16890
Closed

[Backport] hide cookie notice instead of reloading site#17178
mage2pratik wants to merge 1 commit intomagento:2.1-developfrom
mage2pratik:2.1-develop-PR-port-16890

Conversation

@mage2pratik
Copy link
Copy Markdown
Contributor

Original Pull Request

#16890

Description

Instead of reloading the whole site when a use accepts the cookie notice, it should be accpetable to close the cookie notice only.

Manual testing scenarios

  1. Set Cookie Restricton Mode to 'Yes'
  2. Open the Homepage and click on 'Allow Cookies'
  3. The Cookie Notice will be closed immediately

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @mage2pratik
Thank you for your contribution. This pull request has been combined (merged) with #17172 to optimize pull requests queue on magento/magento2 repository
Closing this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants