[Backport] [Search] Unit test for SynonymAnalyzer model. 2.1 back port.#17839
Merged
magento-engcom-team merged 2 commits intoSep 3, 2018
Merged
Conversation
magento-engcom-team
added
Partner: Atwix
rogyar
suggested changes
Aug 29, 2018
| /** | ||
| * Class SynonymAnalyzerTest | ||
| */ | ||
| class SynonymAnalyzerTest extends \PHPUnit\Framework\TestCase |
Contributor
There was a problem hiding this comment.
Not sure this namespace exists within a scope of 2.1. Try to use \PHPUnit_Framework_TestCase instead
Contributor
Author
There was a problem hiding this comment.
Fixed and checked on 2.1 version.
| $actual = $this->synonymAnalyzer->getSynonymsForPhrase($phrase); | ||
| $this->assertEquals($expected, $actual); | ||
| } | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
Please, add an extra empty line after the class closing bracket.
rogyar
approved these changes
Sep 2, 2018
Contributor
|
Hi @rogyar, thank you for the review. |
Contributor
|
Hi @furseyev. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A phpunit test for the \Magento\Search\Model\SynonymAnalyzer class added
Back port to 2.1 of #17801