fix(theme): hide password reveal button by wingkwong · Pull Request #5990 · heroui-inc/heroui

wingkwong · 2025-12-16T05:12:06Z

Closes #5984

📝 Description

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

Bug Fixes
- Password reveal button in input fields is now hidden for consistent rendering across browsers.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

changeset-bot · 2025-12-16T05:12:10Z

🦋 Changeset detected

Latest commit: 3170d2c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@heroui/input	Patch
@heroui/theme	Patch
@heroui/autocomplete	Patch
@heroui/react	Patch
@heroui/checkbox	Patch
@heroui/date-input	Patch
@heroui/date-picker	Patch
@heroui/form	Patch
@heroui/input-otp	Patch
@heroui/number-input	Patch
@heroui/radio	Patch
@heroui/select	Patch
@heroui/table	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2025-12-16T05:12:11Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
heroui	Ready	Preview, Comment	Dec 16, 2025 5:13am
heroui-sb	Ready	Preview, Comment	Dec 16, 2025 5:13am

coderabbitai · 2025-12-16T05:12:18Z

Walkthrough

The changes address a bug where Microsoft Edge displays duplicate password reveal icons in password input fields. The fix adds a Tailwind CSS class to hide Edge's native password reveal button, updates the input component's peer dependency version, and documents these changes in a changeset.

Changes

Cohort / File(s)	Summary
Changeset Documentation `.changeset/forty-melons-cover.md`	Documents version bumps for `@heroui/input` and `@heroui/theme` with changelog entry: "hide password reveal button (`#5984`)"
Dependency Update `packages/components/input/package.json`	Updates `@heroui/theme` peer dependency from `>=2.4.23` to `>=2.4.24`
Component Styling `packages/core/theme/src/components/input.ts`	Adds Tailwind CSS class `[&::-ms-reveal]:hidden` to hide MS Edge password reveal control in input element styles

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Styling change is a single CSS class addition addressing a specific Edge browser rendering issue
Peer dependency version bump is straightforward
Changeset is purely documentation

Possibly related PRs

fix(theme): safari autofill styling for dark mode readability in Input component #5909: Modifies the same input component styling file (packages/core/theme/src/components/input.ts) to add Safari autofill dark-mode text-color styling, suggesting ongoing refinements to cross-browser input field compatibility.

Suggested reviewers

jrgarciadev

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The PR description references issue #5984 but lacks substantive content in the description sections, with all main fields left empty as templates.	Add a brief description explaining the fix: that it hides MS Edge's default password reveal control to prevent the double icon bug reported in #5984.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: hiding the password reveal button in the theme component, matching the primary objective from issue #5984.
Linked Issues check	✅ Passed	The code changes directly address issue #5984 by adding CSS to hide the MS Edge password reveal button ([&::-ms-reveal]:hidden) in the input component theme.
Out of Scope Changes check	✅ Passed	All changes are scoped to the objective: a CSS fix for the password reveal button, a version bump in package.json, and a changeset documenting the fix.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/issue-5984

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 41fc673 and 3170d2c.

📒 Files selected for processing (3)

.changeset/forty-melons-cover.md (1 hunks)
packages/components/input/package.json (1 hunks)
packages/core/theme/src/components/input.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

GitHub Check: Build
GitHub Check: Prettier
GitHub Check: Continuous Release
GitHub Check: Tests
GitHub Check: TypeScript

🔇 Additional comments (3)

packages/components/input/package.json (1)

39-39: LGTM!

The peer dependency version bump correctly ensures that consumers receive the theme package with the password reveal button fix.

.changeset/forty-melons-cover.md (1)

1-6: LGTM!

The changeset correctly documents patch updates for both affected packages and includes a clear changelog entry referencing the issue.

packages/core/theme/src/components/input.ts (1)

53-53: The ::-ms-reveal selector is supported and works correctly in modern Chromium-based Edge.

The ::-ms-reveal pseudo-element can be used to completely remove the password reveal button in modern Edge. No further verification is needed.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

pkg-pr-new · 2025-12-16T05:18:27Z

Open in StackBlitz

@heroui/accordion

npm i https://pkg.pr.new/@heroui/accordion@5990

@heroui/alert

npm i https://pkg.pr.new/@heroui/alert@5990

@heroui/autocomplete

npm i https://pkg.pr.new/@heroui/autocomplete@5990

@heroui/avatar

npm i https://pkg.pr.new/@heroui/avatar@5990

@heroui/badge

npm i https://pkg.pr.new/@heroui/badge@5990

@heroui/breadcrumbs

npm i https://pkg.pr.new/@heroui/breadcrumbs@5990

@heroui/button

npm i https://pkg.pr.new/@heroui/button@5990

@heroui/calendar

npm i https://pkg.pr.new/@heroui/calendar@5990

@heroui/card

npm i https://pkg.pr.new/@heroui/card@5990

@heroui/checkbox

npm i https://pkg.pr.new/@heroui/checkbox@5990

@heroui/chip

npm i https://pkg.pr.new/@heroui/chip@5990

@heroui/code

npm i https://pkg.pr.new/@heroui/code@5990

@heroui/date-input

npm i https://pkg.pr.new/@heroui/date-input@5990

@heroui/date-picker

npm i https://pkg.pr.new/@heroui/date-picker@5990

@heroui/divider

npm i https://pkg.pr.new/@heroui/divider@5990

@heroui/drawer

npm i https://pkg.pr.new/@heroui/drawer@5990

@heroui/dropdown

npm i https://pkg.pr.new/@heroui/dropdown@5990

@heroui/form

npm i https://pkg.pr.new/@heroui/form@5990

@heroui/image

npm i https://pkg.pr.new/@heroui/image@5990

@heroui/input

npm i https://pkg.pr.new/@heroui/input@5990

@heroui/input-otp

npm i https://pkg.pr.new/@heroui/input-otp@5990

@heroui/kbd

npm i https://pkg.pr.new/@heroui/kbd@5990

@heroui/link

npm i https://pkg.pr.new/@heroui/link@5990

@heroui/listbox

npm i https://pkg.pr.new/@heroui/listbox@5990

@heroui/menu

npm i https://pkg.pr.new/@heroui/menu@5990

@heroui/modal

npm i https://pkg.pr.new/@heroui/modal@5990

@heroui/navbar

npm i https://pkg.pr.new/@heroui/navbar@5990

@heroui/number-input

npm i https://pkg.pr.new/@heroui/number-input@5990

@heroui/pagination

npm i https://pkg.pr.new/@heroui/pagination@5990

@heroui/popover

npm i https://pkg.pr.new/@heroui/popover@5990

@heroui/progress

npm i https://pkg.pr.new/@heroui/progress@5990

@heroui/radio

npm i https://pkg.pr.new/@heroui/radio@5990

@heroui/ripple

npm i https://pkg.pr.new/@heroui/ripple@5990

@heroui/scroll-shadow

npm i https://pkg.pr.new/@heroui/scroll-shadow@5990

@heroui/select

npm i https://pkg.pr.new/@heroui/select@5990

@heroui/skeleton

npm i https://pkg.pr.new/@heroui/skeleton@5990

@heroui/slider

npm i https://pkg.pr.new/@heroui/slider@5990

@heroui/snippet

npm i https://pkg.pr.new/@heroui/snippet@5990

@heroui/spacer

npm i https://pkg.pr.new/@heroui/spacer@5990

@heroui/spinner

npm i https://pkg.pr.new/@heroui/spinner@5990

@heroui/switch

npm i https://pkg.pr.new/@heroui/switch@5990

@heroui/table

npm i https://pkg.pr.new/@heroui/table@5990

@heroui/tabs

npm i https://pkg.pr.new/@heroui/tabs@5990

@heroui/toast

npm i https://pkg.pr.new/@heroui/toast@5990

@heroui/tooltip

npm i https://pkg.pr.new/@heroui/tooltip@5990

@heroui/user

npm i https://pkg.pr.new/@heroui/user@5990

@heroui/react

npm i https://pkg.pr.new/@heroui/react@5990

@heroui/system

npm i https://pkg.pr.new/@heroui/system@5990

@heroui/system-rsc

npm i https://pkg.pr.new/@heroui/system-rsc@5990

@heroui/theme

npm i https://pkg.pr.new/@heroui/theme@5990

@heroui/use-aria-accordion

npm i https://pkg.pr.new/@heroui/use-aria-accordion@5990

@heroui/use-aria-accordion-item

npm i https://pkg.pr.new/@heroui/use-aria-accordion-item@5990

@heroui/use-aria-button

npm i https://pkg.pr.new/@heroui/use-aria-button@5990

@heroui/use-aria-link

npm i https://pkg.pr.new/@heroui/use-aria-link@5990

@heroui/use-aria-modal-overlay

npm i https://pkg.pr.new/@heroui/use-aria-modal-overlay@5990

@heroui/use-aria-multiselect

npm i https://pkg.pr.new/@heroui/use-aria-multiselect@5990

@heroui/use-aria-overlay

npm i https://pkg.pr.new/@heroui/use-aria-overlay@5990

@heroui/use-callback-ref

npm i https://pkg.pr.new/@heroui/use-callback-ref@5990

@heroui/use-clipboard

npm i https://pkg.pr.new/@heroui/use-clipboard@5990

@heroui/use-data-scroll-overflow

npm i https://pkg.pr.new/@heroui/use-data-scroll-overflow@5990

@heroui/use-disclosure

npm i https://pkg.pr.new/@heroui/use-disclosure@5990

@heroui/use-draggable

npm i https://pkg.pr.new/@heroui/use-draggable@5990

@heroui/use-form-reset

npm i https://pkg.pr.new/@heroui/use-form-reset@5990

@heroui/use-image

npm i https://pkg.pr.new/@heroui/use-image@5990

@heroui/use-infinite-scroll

npm i https://pkg.pr.new/@heroui/use-infinite-scroll@5990

@heroui/use-intersection-observer

npm i https://pkg.pr.new/@heroui/use-intersection-observer@5990

@heroui/use-is-mobile

npm i https://pkg.pr.new/@heroui/use-is-mobile@5990

@heroui/use-is-mounted

npm i https://pkg.pr.new/@heroui/use-is-mounted@5990

@heroui/use-measure

npm i https://pkg.pr.new/@heroui/use-measure@5990

@heroui/use-pagination

npm i https://pkg.pr.new/@heroui/use-pagination@5990

@heroui/use-real-shape

npm i https://pkg.pr.new/@heroui/use-real-shape@5990

@heroui/use-ref-state

npm i https://pkg.pr.new/@heroui/use-ref-state@5990

@heroui/use-resize

npm i https://pkg.pr.new/@heroui/use-resize@5990

@heroui/use-safe-layout-effect

npm i https://pkg.pr.new/@heroui/use-safe-layout-effect@5990

@heroui/use-scroll-position

npm i https://pkg.pr.new/@heroui/use-scroll-position@5990

@heroui/use-ssr

npm i https://pkg.pr.new/@heroui/use-ssr@5990

@heroui/use-theme

npm i https://pkg.pr.new/@heroui/use-theme@5990

@heroui/use-update-effect

npm i https://pkg.pr.new/@heroui/use-update-effect@5990

@heroui/use-viewport-size

npm i https://pkg.pr.new/@heroui/use-viewport-size@5990

@heroui/aria-utils

npm i https://pkg.pr.new/@heroui/aria-utils@5990

@heroui/dom-animation

npm i https://pkg.pr.new/@heroui/dom-animation@5990

@heroui/framer-utils

npm i https://pkg.pr.new/@heroui/framer-utils@5990

@heroui/react-rsc-utils

npm i https://pkg.pr.new/@heroui/react-rsc-utils@5990

@heroui/react-utils

npm i https://pkg.pr.new/@heroui/react-utils@5990

@heroui/shared-icons

npm i https://pkg.pr.new/@heroui/shared-icons@5990

@heroui/shared-utils

npm i https://pkg.pr.new/@heroui/shared-utils@5990

@heroui/stories-utils

npm i https://pkg.pr.new/@heroui/stories-utils@5990

@heroui/test-utils

npm i https://pkg.pr.new/@heroui/test-utils@5990

commit: 3170d2c

heroui-inc/heroui#5895 heroui-inc/heroui#5940 heroui-inc/heroui#5990 heroui-inc/heroui#5999

* fix(theme): hide password reveal button (#5990) * fix(link): link overriding role (#5999) * fix(link): allow overriding role * chore(link): changeset * chore(deps): upgrade react-aria (v1.14.0) (#5996) * chore(deps): upgrade react-aria (v1.14.0) * refactor(react): group client components * fix(dropdown): keyDown test cases * chore(react): rollback * fix(theme): default transition-duration (#6011) * fix(theme): default transitionDuration * chore(deps): bump @heroui/theme peer dep * ci(changesets): version packages (#5991) Co-authored-by: Junior Garcia <jrgarciadev@gmail.com> --------- Co-authored-by: Hayato Hasegawa <hase1225hayato@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Junior Garcia <jrgarciadev@gmail.com>

* fix(theme): hide password reveal button (#5990) * fix(link): link overriding role (#5999) * fix(link): allow overriding role * chore(link): changeset * chore(deps): upgrade react-aria (v1.14.0) (#5996) * chore(deps): upgrade react-aria (v1.14.0) * refactor(react): group client components * fix(dropdown): keyDown test cases * chore(react): rollback * fix(theme): default transition-duration (#6011) * fix(theme): default transitionDuration * chore(deps): bump @heroui/theme peer dep * ci(changesets): version packages (#5991) Co-authored-by: Junior Garcia <jrgarciadev@gmail.com> * fix(use-image): resolve race condition with cached images on Firefox/Safari (#6041) * fix(use-image): resolve race condition with cached images on Firefox/Safari The bug occurred because event handlers (onload/onerror) were attached AFTER setting the image src. For cached images, browsers fire onload synchronously when src is set, causing the event to be missed and images to remain stuck at opacity-0. Changes: - Attach handlers BEFORE setting src to catch synchronous callbacks - Check both naturalWidth AND naturalHeight (per CodeRabbit review on #4523) - Handle synchronous error callbacks for failed cached images - Add comprehensive test coverage (15 tests) including: - Synchronous cached image success (Firefox/Safari race condition) - Synchronous cached image error - Dynamic src changes - All props (crossOrigin, srcSet, sizes, loading) - Callback invocation verification Reproduction and investigation performed using Claude Opus 4.5. Fixes #4534, #2259 * fix(use-image): add ignoreFallback to useCallback dependencies Address CodeRabbit review feedback: the `ignoreFallback` prop was used inside the `load` callback (line 104) but was missing from the dependency array, creating a stale closure bug. Without this fix, if `ignoreFallback` changes from `true` to `false` dynamically, the `load` callback would retain the stale `true` value, preventing the image from ever loading. Changes: - Add `ignoreFallback` to useCallback dependency array - Add tests for dynamic `ignoreFallback` changes (both directions) - Update changeset to document this fix Verification performed using Claude Opus 4.5. --------- Co-authored-by: Brian Meek <brian@current.space> * fix(docs): broken links in Form page (#6077) * fix(pagination): improve layout for large page counts (#6034) * fix(pagination): improve layout for large page counts/style of paagination compnents * fix(pagination): refine item sizing to balance small and large page numbers * ci(changesets): add pagination sizing changeset * fix(pagination): ensure cursor fully covers button without changing radius * chore(changeset): revise message and add issue numbers --------- Co-authored-by: WK Wong <wingkwong.code@gmail.com> * fix(date-picker): open date-picker when clicking border (#6084) * fix(date-picker): add pointer interaction to open date picker on wrapper click * chore: add changeset * chore(changeset): add issue number --------- Co-authored-by: WK <wingkwong.code@gmail.com> * fix(accordion): click behaviour for dynamically generated accordion items (#6133) * fix(accordion): add collection state * chore: add changeset * fix: update change set * refactor(theme): remove flat dependency (#6157) * chore(deps): remove flat library * refactor(theme): replace flatten from flat * chore: add changeset * fix(listbox): prevent option focus from start/end content slots (#6060) * fix(listbox): prevent option focus from start/end content slots * test: add test code about when clicking non-interactive slot content, and prevented focus leakage from interactive start/end content such as buttons. * docs: add changeset * chore(changeset): add issue number --------- Co-authored-by: WK <wingkwong.code@gmail.com> * fix(system-rsc): extendVariants & compound variants types (#5847) * fix(extendVariants): return component type error * fix(CompoundVariants): correct type inference for extended/compound variants and composition * test: cover compound/extend inference; enforce CP required props * fix(types): correct CompoundVariants class value inference Replaces the conditional ClassProp logic with a simpler, consistent form to fix incorrect slot value inference. Before: ClassProp<S extends undefined ? ClassValue : ClassValue | SlotsClassValue<S>> After: ClassProp<ClassValue | GetSuggestedValues<S>> This ensures GetSuggestedValues<S> is used for slot-aware variants and avoids duplicated conditional branches for undefined slots. * fix(system-rsc): correct slot detection in getSlots() * fix(types): make ExtendVariants props optional and guard V[key] with NonNullable Simplifies the return type of ExtendVariants to ensure no required props are enforced at the HOC level. This aligns with the intended API contract where extended components expose all props as optional. - All keys (CP ∪ V) are optional - Preserve CP type hints and booleanized V values - Added NonNullable<V[key]> guard to prevent undefined indexing * test(extendVariants): add compoundVariants integration test * fix(system-rsc): getSlots() brief JSDoc comment added * test(extendVariants): new styles - extended & fixed styles - original tests for slots component * test(extendVariants): fixed slot component variant styles extended test * fix(types): avoid leaking React internals by removing PropsWithoutRef Replace PropsWithoutRef with explicit Exclude<'ref'> in mapped keys and intersect with RefAttributes<InferRef<C>>. This prevents @types/react’s internal UNDEFINED_VOID_ONLY from leaking into the public .d.ts and fixes declaration emit for components like extended Autocomplete. * chore(changeset): add patch for extendVariants and CompoundVariants type fix * chore(system-rsc): add changeset for getSlots() slot detection fix * refactor(types): unify slot value inference via GetSuggestedValues<S> for consistent variant typing * fix(extendVariants): improved as-prop handling and exclude classNames from SuggestedVariants * fix(system-rsc): add polymorphic 'as' prop support to extendVariants * chore(system-rsc): add missing tests --------- Co-authored-by: doki- <1335902682@qq.com> Co-authored-by: WK Wong <wingkwong.code@gmail.com> * chore(docs): update meta (#6168) * ci(changesets): version packages (#6059) Co-authored-by: Junior Garcia <jrgarciadev@gmail.com> --------- Co-authored-by: Hayato Hasegawa <hase1225hayato@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Junior Garcia <jrgarciadev@gmail.com> Co-authored-by: brianatdetections <brian@detections.ai> Co-authored-by: Brian Meek <brian@current.space> Co-authored-by: Dominik Hryshaiev <domhryshaiev@gmail.com> Co-authored-by: creative-atish <149860680+atishkr25@users.noreply.github.com> Co-authored-by: KyZy7 <29321162+KyZy7@users.noreply.github.com> Co-authored-by: Deepansh Bhargava <deepansh940@gmail.com> Co-authored-by: KumJungMin <37934668+KumJungMin@users.noreply.github.com> Co-authored-by: Bohdan Kulinchenko <35272606+ITBoomBKStudio@users.noreply.github.com> Co-authored-by: doki- <1335902682@qq.com>

* fix(theme): hide password reveal button (#5990) * fix(link): link overriding role (#5999) * fix(link): allow overriding role * chore(link): changeset * chore(deps): upgrade react-aria (v1.14.0) (#5996) * chore(deps): upgrade react-aria (v1.14.0) * refactor(react): group client components * fix(dropdown): keyDown test cases * chore(react): rollback * fix(theme): default transition-duration (#6011) * fix(theme): default transitionDuration * chore(deps): bump @heroui/theme peer dep * ci(changesets): version packages (#5991) Co-authored-by: Junior Garcia <jrgarciadev@gmail.com> * fix(use-image): resolve race condition with cached images on Firefox/Safari (#6041) * fix(use-image): resolve race condition with cached images on Firefox/Safari The bug occurred because event handlers (onload/onerror) were attached AFTER setting the image src. For cached images, browsers fire onload synchronously when src is set, causing the event to be missed and images to remain stuck at opacity-0. Changes: - Attach handlers BEFORE setting src to catch synchronous callbacks - Check both naturalWidth AND naturalHeight (per CodeRabbit review on #4523) - Handle synchronous error callbacks for failed cached images - Add comprehensive test coverage (15 tests) including: - Synchronous cached image success (Firefox/Safari race condition) - Synchronous cached image error - Dynamic src changes - All props (crossOrigin, srcSet, sizes, loading) - Callback invocation verification Reproduction and investigation performed using Claude Opus 4.5. Fixes #4534, #2259 * fix(use-image): add ignoreFallback to useCallback dependencies Address CodeRabbit review feedback: the `ignoreFallback` prop was used inside the `load` callback (line 104) but was missing from the dependency array, creating a stale closure bug. Without this fix, if `ignoreFallback` changes from `true` to `false` dynamically, the `load` callback would retain the stale `true` value, preventing the image from ever loading. Changes: - Add `ignoreFallback` to useCallback dependency array - Add tests for dynamic `ignoreFallback` changes (both directions) - Update changeset to document this fix Verification performed using Claude Opus 4.5. --------- Co-authored-by: Brian Meek <brian@current.space> * fix(docs): broken links in Form page (#6077) * fix(pagination): improve layout for large page counts (#6034) * fix(pagination): improve layout for large page counts/style of paagination compnents * fix(pagination): refine item sizing to balance small and large page numbers * ci(changesets): add pagination sizing changeset * fix(pagination): ensure cursor fully covers button without changing radius * chore(changeset): revise message and add issue numbers --------- Co-authored-by: WK Wong <wingkwong.code@gmail.com> * fix(date-picker): open date-picker when clicking border (#6084) * fix(date-picker): add pointer interaction to open date picker on wrapper click * chore: add changeset * chore(changeset): add issue number --------- Co-authored-by: WK <wingkwong.code@gmail.com> * fix(accordion): click behaviour for dynamically generated accordion items (#6133) * fix(accordion): add collection state * chore: add changeset * fix: update change set * refactor(theme): remove flat dependency (#6157) * chore(deps): remove flat library * refactor(theme): replace flatten from flat * chore: add changeset * fix(listbox): prevent option focus from start/end content slots (#6060) * fix(listbox): prevent option focus from start/end content slots * test: add test code about when clicking non-interactive slot content, and prevented focus leakage from interactive start/end content such as buttons. * docs: add changeset * chore(changeset): add issue number --------- Co-authored-by: WK <wingkwong.code@gmail.com> * fix(system-rsc): extendVariants & compound variants types (#5847) * fix(extendVariants): return component type error * fix(CompoundVariants): correct type inference for extended/compound variants and composition * test: cover compound/extend inference; enforce CP required props * fix(types): correct CompoundVariants class value inference Replaces the conditional ClassProp logic with a simpler, consistent form to fix incorrect slot value inference. Before: ClassProp<S extends undefined ? ClassValue : ClassValue | SlotsClassValue<S>> After: ClassProp<ClassValue | GetSuggestedValues<S>> This ensures GetSuggestedValues<S> is used for slot-aware variants and avoids duplicated conditional branches for undefined slots. * fix(system-rsc): correct slot detection in getSlots() * fix(types): make ExtendVariants props optional and guard V[key] with NonNullable Simplifies the return type of ExtendVariants to ensure no required props are enforced at the HOC level. This aligns with the intended API contract where extended components expose all props as optional. - All keys (CP ∪ V) are optional - Preserve CP type hints and booleanized V values - Added NonNullable<V[key]> guard to prevent undefined indexing * test(extendVariants): add compoundVariants integration test * fix(system-rsc): getSlots() brief JSDoc comment added * test(extendVariants): new styles - extended & fixed styles - original tests for slots component * test(extendVariants): fixed slot component variant styles extended test * fix(types): avoid leaking React internals by removing PropsWithoutRef Replace PropsWithoutRef with explicit Exclude<'ref'> in mapped keys and intersect with RefAttributes<InferRef<C>>. This prevents @types/react’s internal UNDEFINED_VOID_ONLY from leaking into the public .d.ts and fixes declaration emit for components like extended Autocomplete. * chore(changeset): add patch for extendVariants and CompoundVariants type fix * chore(system-rsc): add changeset for getSlots() slot detection fix * refactor(types): unify slot value inference via GetSuggestedValues<S> for consistent variant typing * fix(extendVariants): improved as-prop handling and exclude classNames from SuggestedVariants * fix(system-rsc): add polymorphic 'as' prop support to extendVariants * chore(system-rsc): add missing tests --------- Co-authored-by: doki- <1335902682@qq.com> Co-authored-by: WK Wong <wingkwong.code@gmail.com> * chore(docs): update meta (#6168) * ci(changesets): version packages (#6059) Co-authored-by: Junior Garcia <jrgarciadev@gmail.com> * fix(system-rsc): extendVariants rendering behavior with as (#6215) * fix(system-rsc): fix components rendering with 'as' prop * fix(system-rsc): fix compoundVariants and slots inheritance in extendVariants * fix(system-rsc): extendVariants test file cleaned * chore(deps): bump RA dependencies (#6221) * chore(deps): bump RA dependencies * chore(date-picker): revise test cases * fix(button): correct disableRipple prop precedence (#6199) * ci(changesets): version packages (#6227) Co-authored-by: Junior Garcia <jrgarciadev@gmail.com> --------- Co-authored-by: Hayato Hasegawa <hase1225hayato@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Junior Garcia <jrgarciadev@gmail.com> Co-authored-by: brianatdetections <brian@detections.ai> Co-authored-by: Brian Meek <brian@current.space> Co-authored-by: Dominik Hryshaiev <domhryshaiev@gmail.com> Co-authored-by: creative-atish <149860680+atishkr25@users.noreply.github.com> Co-authored-by: KyZy7 <29321162+KyZy7@users.noreply.github.com> Co-authored-by: Deepansh Bhargava <deepansh940@gmail.com> Co-authored-by: KumJungMin <37934668+KumJungMin@users.noreply.github.com> Co-authored-by: Bohdan Kulinchenko <35272606+ITBoomBKStudio@users.noreply.github.com> Co-authored-by: doki- <1335902682@qq.com> Co-authored-by: Chris Nowak <krzysztofmareknowak@gmail.com>

fix(theme): hide password reveal button

3170d2c

wingkwong added this to the v2.8.7 milestone Dec 16, 2025

wingkwong requested a review from jrgarciadev as a code owner December 16, 2025 05:12

vercel Bot deployed to Preview – heroui-sb December 16, 2025 05:13 View deployment

vercel Bot deployed to Preview – heroui December 16, 2025 05:13 View deployment

wingkwong merged commit acc74d1 into canary Dec 16, 2025
10 checks passed

wingkwong deleted the fix/issue-5984 branch December 16, 2025 06:21

github-actions Bot mentioned this pull request Dec 16, 2025

ci(changesets): 📦 version packages #5991

Merged

AnYiEE added a commit to AnYiEE/touhou-mystia-izakaya-assistant that referenced this pull request Dec 18, 2025

fix(components): apply HeroUI patches

34abd61

heroui-inc/heroui#5895 heroui-inc/heroui#5940 heroui-inc/heroui#5990 heroui-inc/heroui#5999

coderabbitai Bot mentioned this pull request Dec 20, 2025

v2.8.7 #6022

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(theme): hide password reveal button#5990

fix(theme): hide password reveal button#5990
wingkwong merged 1 commit into
canaryfrom
fix/issue-5984

wingkwong commented Dec 16, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Dec 16, 2025

Uh oh!

vercel Bot commented Dec 16, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot commented Dec 16, 2025 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Dec 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

wingkwong commented Dec 16, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Dec 16, 2025

🦋 Changeset detected

Uh oh!

vercel Bot commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

pkg-pr-new Bot commented Dec 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

wingkwong commented Dec 16, 2025 •

edited by coderabbitai Bot

Loading

vercel Bot commented Dec 16, 2025 •

edited

Loading

coderabbitai Bot commented Dec 16, 2025 •

edited

Loading