Skip to content

fix(date-picker): open date-picker when clicking border#6084

Merged
wingkwong merged 3 commits into
heroui-inc:canaryfrom
KyZy7:fix/datepicker-border-focus
Jan 6, 2026
Merged

fix(date-picker): open date-picker when clicking border#6084
wingkwong merged 3 commits into
heroui-inc:canaryfrom
KyZy7:fix/datepicker-border-focus

Conversation

@KyZy7
Copy link
Copy Markdown

@KyZy7 KyZy7 commented Jan 5, 2026

Closes #5373

📝 Description

Opens the date-picker calendar when clicking on the edge/border of the component. It is currently focusing the previous input. Could cause end users to focus an incorrect input if they happen to click on the edge of the date-picker.

⛳️ Current behavior (updates)

When clicking on the wrapper for the date-picker, the previous input is focused.

🚀 New behavior

When clicking on the wrapper, the calendar for the date-picker is opened.

  • Added onPointerDown event handler to the wrapper

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

@KyZy7 KyZy7 requested a review from jrgarciadev as a code owner January 5, 2026 21:16
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 5, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: 40a4f57

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@heroui/date-picker Patch
@heroui/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 5, 2026

@KyZy7 is attempting to deploy a commit to the HeroUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Jan 6, 2026 •
edited
Loading

Open in StackBlitz

@heroui/accordion

npm i https://pkg.pr.new/@heroui/accordion@6084

@heroui/alert

npm i https://pkg.pr.new/@heroui/alert@6084

@heroui/autocomplete

npm i https://pkg.pr.new/@heroui/autocomplete@6084

@heroui/avatar

npm i https://pkg.pr.new/@heroui/avatar@6084

@heroui/badge

npm i https://pkg.pr.new/@heroui/badge@6084

@heroui/breadcrumbs

npm i https://pkg.pr.new/@heroui/breadcrumbs@6084

@heroui/button

npm i https://pkg.pr.new/@heroui/button@6084

@heroui/calendar

npm i https://pkg.pr.new/@heroui/calendar@6084

@heroui/card

npm i https://pkg.pr.new/@heroui/card@6084

@heroui/checkbox

npm i https://pkg.pr.new/@heroui/checkbox@6084

@heroui/chip

npm i https://pkg.pr.new/@heroui/chip@6084

@heroui/code

npm i https://pkg.pr.new/@heroui/code@6084

@heroui/date-input

npm i https://pkg.pr.new/@heroui/date-input@6084

@heroui/date-picker

npm i https://pkg.pr.new/@heroui/date-picker@6084

@heroui/divider

npm i https://pkg.pr.new/@heroui/divider@6084

@heroui/drawer

npm i https://pkg.pr.new/@heroui/drawer@6084

@heroui/dropdown

npm i https://pkg.pr.new/@heroui/dropdown@6084

@heroui/form

npm i https://pkg.pr.new/@heroui/form@6084

@heroui/image

npm i https://pkg.pr.new/@heroui/image@6084

@heroui/input

npm i https://pkg.pr.new/@heroui/input@6084

@heroui/input-otp

npm i https://pkg.pr.new/@heroui/input-otp@6084

@heroui/kbd

npm i https://pkg.pr.new/@heroui/kbd@6084

@heroui/link

npm i https://pkg.pr.new/@heroui/link@6084

@heroui/listbox

npm i https://pkg.pr.new/@heroui/listbox@6084

@heroui/menu

npm i https://pkg.pr.new/@heroui/menu@6084

@heroui/modal

npm i https://pkg.pr.new/@heroui/modal@6084

@heroui/navbar

npm i https://pkg.pr.new/@heroui/navbar@6084

@heroui/number-input

npm i https://pkg.pr.new/@heroui/number-input@6084

@heroui/pagination

npm i https://pkg.pr.new/@heroui/pagination@6084

@heroui/popover

npm i https://pkg.pr.new/@heroui/popover@6084

@heroui/progress

npm i https://pkg.pr.new/@heroui/progress@6084

@heroui/radio

npm i https://pkg.pr.new/@heroui/radio@6084

@heroui/ripple

npm i https://pkg.pr.new/@heroui/ripple@6084

@heroui/scroll-shadow

npm i https://pkg.pr.new/@heroui/scroll-shadow@6084

@heroui/select

npm i https://pkg.pr.new/@heroui/select@6084

@heroui/skeleton

npm i https://pkg.pr.new/@heroui/skeleton@6084

@heroui/slider

npm i https://pkg.pr.new/@heroui/slider@6084

@heroui/snippet

npm i https://pkg.pr.new/@heroui/snippet@6084

@heroui/spacer

npm i https://pkg.pr.new/@heroui/spacer@6084

@heroui/spinner

npm i https://pkg.pr.new/@heroui/spinner@6084

@heroui/switch

npm i https://pkg.pr.new/@heroui/switch@6084

@heroui/table

npm i https://pkg.pr.new/@heroui/table@6084

@heroui/tabs

npm i https://pkg.pr.new/@heroui/tabs@6084

@heroui/toast

npm i https://pkg.pr.new/@heroui/toast@6084

@heroui/tooltip

npm i https://pkg.pr.new/@heroui/tooltip@6084

@heroui/user

npm i https://pkg.pr.new/@heroui/user@6084

@heroui/react

npm i https://pkg.pr.new/@heroui/react@6084

@heroui/system

npm i https://pkg.pr.new/@heroui/system@6084

@heroui/system-rsc

npm i https://pkg.pr.new/@heroui/system-rsc@6084

@heroui/theme

npm i https://pkg.pr.new/@heroui/theme@6084

@heroui/use-aria-accordion

npm i https://pkg.pr.new/@heroui/use-aria-accordion@6084

@heroui/use-aria-accordion-item

npm i https://pkg.pr.new/@heroui/use-aria-accordion-item@6084

@heroui/use-aria-button

npm i https://pkg.pr.new/@heroui/use-aria-button@6084

@heroui/use-aria-link

npm i https://pkg.pr.new/@heroui/use-aria-link@6084

@heroui/use-aria-modal-overlay

npm i https://pkg.pr.new/@heroui/use-aria-modal-overlay@6084

@heroui/use-aria-multiselect

npm i https://pkg.pr.new/@heroui/use-aria-multiselect@6084

@heroui/use-aria-overlay

npm i https://pkg.pr.new/@heroui/use-aria-overlay@6084

@heroui/use-callback-ref

npm i https://pkg.pr.new/@heroui/use-callback-ref@6084

@heroui/use-clipboard

npm i https://pkg.pr.new/@heroui/use-clipboard@6084

@heroui/use-data-scroll-overflow

npm i https://pkg.pr.new/@heroui/use-data-scroll-overflow@6084

@heroui/use-disclosure

npm i https://pkg.pr.new/@heroui/use-disclosure@6084

@heroui/use-draggable

npm i https://pkg.pr.new/@heroui/use-draggable@6084

@heroui/use-form-reset

npm i https://pkg.pr.new/@heroui/use-form-reset@6084

@heroui/use-image

npm i https://pkg.pr.new/@heroui/use-image@6084

@heroui/use-infinite-scroll

npm i https://pkg.pr.new/@heroui/use-infinite-scroll@6084

@heroui/use-intersection-observer

npm i https://pkg.pr.new/@heroui/use-intersection-observer@6084

@heroui/use-is-mobile

npm i https://pkg.pr.new/@heroui/use-is-mobile@6084

@heroui/use-is-mounted

npm i https://pkg.pr.new/@heroui/use-is-mounted@6084

@heroui/use-measure

npm i https://pkg.pr.new/@heroui/use-measure@6084

@heroui/use-pagination

npm i https://pkg.pr.new/@heroui/use-pagination@6084

@heroui/use-real-shape

npm i https://pkg.pr.new/@heroui/use-real-shape@6084

@heroui/use-ref-state

npm i https://pkg.pr.new/@heroui/use-ref-state@6084

@heroui/use-resize

npm i https://pkg.pr.new/@heroui/use-resize@6084

@heroui/use-safe-layout-effect

npm i https://pkg.pr.new/@heroui/use-safe-layout-effect@6084

@heroui/use-scroll-position

npm i https://pkg.pr.new/@heroui/use-scroll-position@6084

@heroui/use-ssr

npm i https://pkg.pr.new/@heroui/use-ssr@6084

@heroui/use-theme

npm i https://pkg.pr.new/@heroui/use-theme@6084

@heroui/use-update-effect

npm i https://pkg.pr.new/@heroui/use-update-effect@6084

@heroui/use-viewport-size

npm i https://pkg.pr.new/@heroui/use-viewport-size@6084

@heroui/aria-utils

npm i https://pkg.pr.new/@heroui/aria-utils@6084

@heroui/dom-animation

npm i https://pkg.pr.new/@heroui/dom-animation@6084

@heroui/framer-utils

npm i https://pkg.pr.new/@heroui/framer-utils@6084

@heroui/react-rsc-utils

npm i https://pkg.pr.new/@heroui/react-rsc-utils@6084

@heroui/react-utils

npm i https://pkg.pr.new/@heroui/react-utils@6084

@heroui/shared-icons

npm i https://pkg.pr.new/@heroui/shared-icons@6084

@heroui/shared-utils

npm i https://pkg.pr.new/@heroui/shared-utils@6084

@heroui/stories-utils

npm i https://pkg.pr.new/@heroui/stories-utils@6084

@heroui/test-utils

npm i https://pkg.pr.new/@heroui/test-utils@6084

commit: 40a4f57

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 6, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
heroui Ready Ready Preview, Comment Jan 6, 2026 4:33pm
heroui-sb Ready Ready Preview, Comment Jan 6, 2026 4:33pm

@wingkwong wingkwong added this to the v2.8.8 milestone Jan 6, 2026
wingkwong
wingkwong requested changes Jan 6, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a changeset

@wingkwong wingkwong self-requested a review January 6, 2026 16:34
@wingkwong wingkwong merged commit d5a5c77 into heroui-inc:canary Jan 6, 2026
10 checks passed
@github-actions github-actions Bot mentioned this pull request Jan 4, 2026
Merged
wingkwong added a commit that referenced this pull request Jan 29, 2026
@wingkwong @hasegawa-101
@github-actions @jrgarciadev @brianatdetections @brianathere @domhhv @atishkr25 @KyZy7 @deepansh946 @KumJungMin @ITBoomBKStudio @IsDyh01
v2.8.8 (#6172)
1a7a85b 
* fix(theme): hide password reveal button (#5990)

* fix(link): link overriding role (#5999)

* fix(link): allow overriding role

* chore(link): changeset

* chore(deps): upgrade react-aria (v1.14.0) (#5996)

* chore(deps): upgrade react-aria (v1.14.0)

* refactor(react): group client components

* fix(dropdown): keyDown test cases

* chore(react): rollback

* fix(theme): default transition-duration (#6011)

* fix(theme): default transitionDuration

* chore(deps): bump @heroui/theme peer dep

* ci(changesets): version packages (#5991)

Co-authored-by: Junior Garcia <jrgarciadev@gmail.com>

* fix(use-image): resolve race condition with cached images on Firefox/Safari (#6041)

* fix(use-image): resolve race condition with cached images on Firefox/Safari

The bug occurred because event handlers (onload/onerror) were attached
AFTER setting the image src. For cached images, browsers fire onload
synchronously when src is set, causing the event to be missed and
images to remain stuck at opacity-0.

Changes:
- Attach handlers BEFORE setting src to catch synchronous callbacks
- Check both naturalWidth AND naturalHeight (per CodeRabbit review on #4523)
- Handle synchronous error callbacks for failed cached images
- Add comprehensive test coverage (15 tests) including:
  - Synchronous cached image success (Firefox/Safari race condition)
  - Synchronous cached image error
  - Dynamic src changes
  - All props (crossOrigin, srcSet, sizes, loading)
  - Callback invocation verification

Reproduction and investigation performed using Claude Opus 4.5.

Fixes #4534, #2259

* fix(use-image): add ignoreFallback to useCallback dependencies

Address CodeRabbit review feedback: the `ignoreFallback` prop was used
inside the `load` callback (line 104) but was missing from the dependency
array, creating a stale closure bug.

Without this fix, if `ignoreFallback` changes from `true` to `false`
dynamically, the `load` callback would retain the stale `true` value,
preventing the image from ever loading.

Changes:
- Add `ignoreFallback` to useCallback dependency array
- Add tests for dynamic `ignoreFallback` changes (both directions)
- Update changeset to document this fix

Verification performed using Claude Opus 4.5.

---------

Co-authored-by: Brian Meek <brian@current.space>

* fix(docs): broken links in Form page (#6077)

* fix(pagination): improve layout for large page counts (#6034)

* fix(pagination): improve layout for large page counts/style of paagination compnents

* fix(pagination): refine item sizing to balance small and large page numbers

* ci(changesets): add pagination sizing changeset

* fix(pagination): ensure cursor fully covers button without changing radius

* chore(changeset): revise message and add issue numbers

---------

Co-authored-by: WK Wong <wingkwong.code@gmail.com>

* fix(date-picker): open date-picker when clicking border (#6084)

* fix(date-picker): add pointer interaction to open date picker on wrapper click

* chore: add changeset

* chore(changeset): add issue number

---------

Co-authored-by: WK <wingkwong.code@gmail.com>

* fix(accordion): click behaviour for dynamically generated accordion items (#6133)

* fix(accordion): add collection state

* chore: add changeset

* fix: update change set

* refactor(theme): remove flat dependency (#6157)

* chore(deps): remove flat library

* refactor(theme): replace flatten from flat

* chore: add changeset

* fix(listbox): prevent option focus from start/end content slots (#6060)

* fix(listbox): prevent option focus from start/end content slots

* test: add test code about when clicking
non-interactive slot content, and prevented focus leakage from interactive
start/end content such as buttons.

* docs: add changeset

* chore(changeset): add issue number

---------

Co-authored-by: WK <wingkwong.code@gmail.com>

* fix(system-rsc): extendVariants & compound variants types (#5847)

* fix(extendVariants): return component type error

* fix(CompoundVariants): correct type inference for extended/compound variants and composition

* test: cover compound/extend inference; enforce CP required props

* fix(types): correct CompoundVariants class value inference

Replaces the conditional ClassProp logic with a simpler,
consistent form to fix incorrect slot value inference.

Before:
  ClassProp<S extends undefined ? ClassValue : ClassValue | SlotsClassValue<S>>

After:
  ClassProp<ClassValue | GetSuggestedValues<S>>

This ensures GetSuggestedValues<S> is used for slot-aware variants
and avoids duplicated conditional branches for undefined slots.

* fix(system-rsc): correct slot detection in getSlots()

* fix(types): make ExtendVariants props optional and guard V[key] with NonNullable

Simplifies the return type of ExtendVariants to ensure no required props
are enforced at the HOC level. This aligns with the intended API contract
where extended components expose all props as optional.

- All keys (CP ∪ V) are optional
- Preserve CP type hints and booleanized V values
- Added NonNullable<V[key]> guard to prevent undefined indexing

* test(extendVariants): add compoundVariants integration test

* fix(system-rsc): getSlots() brief JSDoc comment added

* test(extendVariants):  new styles - extended & fixed styles - original tests for slots component

* test(extendVariants): fixed slot component variant styles extended test

* fix(types): avoid leaking React internals by removing PropsWithoutRef

Replace PropsWithoutRef with explicit Exclude<'ref'> in mapped keys and
intersect with RefAttributes<InferRef<C>>. This prevents @types/react’s
internal UNDEFINED_VOID_ONLY from leaking into the public .d.ts and fixes
declaration emit for components like extended Autocomplete.

* chore(changeset): add patch for extendVariants and CompoundVariants type fix

* chore(system-rsc): add changeset for getSlots() slot detection fix

* refactor(types): unify slot value inference via GetSuggestedValues<S> for consistent variant typing

* fix(extendVariants): improved as-prop handling and exclude classNames from SuggestedVariants

* fix(system-rsc): add polymorphic 'as' prop support to extendVariants

* chore(system-rsc): add missing tests

---------

Co-authored-by: doki- <1335902682@qq.com>
Co-authored-by: WK Wong <wingkwong.code@gmail.com>

* chore(docs): update meta (#6168)

* ci(changesets): version packages (#6059)

Co-authored-by: Junior Garcia <jrgarciadev@gmail.com>

---------

Co-authored-by: Hayato Hasegawa <hase1225hayato@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Junior Garcia <jrgarciadev@gmail.com>
Co-authored-by: brianatdetections <brian@detections.ai>
Co-authored-by: Brian Meek <brian@current.space>
Co-authored-by: Dominik Hryshaiev <domhryshaiev@gmail.com>
Co-authored-by: creative-atish <149860680+atishkr25@users.noreply.github.com>
Co-authored-by: KyZy7 <29321162+KyZy7@users.noreply.github.com>
Co-authored-by: Deepansh Bhargava <deepansh940@gmail.com>
Co-authored-by: KumJungMin <37934668+KumJungMin@users.noreply.github.com>
Co-authored-by: Bohdan Kulinchenko <35272606+ITBoomBKStudio@users.noreply.github.com>
Co-authored-by: doki- <1335902682@qq.com>
jrgarciadev added a commit that referenced this pull request Feb 10, 2026
@wingkwong @hasegawa-101
@github-actions @jrgarciadev @brianatdetections @brianathere @domhhv @atishkr25 @KyZy7 @deepansh946 @KumJungMin @ITBoomBKStudio @IsDyh01
v2.8.8 (#6173)
a252e72 
* fix(theme): hide password reveal button (#5990)

* fix(link): link overriding role (#5999)

* fix(link): allow overriding role

* chore(link): changeset

* chore(deps): upgrade react-aria (v1.14.0) (#5996)

* chore(deps): upgrade react-aria (v1.14.0)

* refactor(react): group client components

* fix(dropdown): keyDown test cases

* chore(react): rollback

* fix(theme): default transition-duration (#6011)

* fix(theme): default transitionDuration

* chore(deps): bump @heroui/theme peer dep

* ci(changesets): version packages (#5991)

Co-authored-by: Junior Garcia <jrgarciadev@gmail.com>

* fix(use-image): resolve race condition with cached images on Firefox/Safari (#6041)

* fix(use-image): resolve race condition with cached images on Firefox/Safari

The bug occurred because event handlers (onload/onerror) were attached
AFTER setting the image src. For cached images, browsers fire onload
synchronously when src is set, causing the event to be missed and
images to remain stuck at opacity-0.

Changes:
- Attach handlers BEFORE setting src to catch synchronous callbacks
- Check both naturalWidth AND naturalHeight (per CodeRabbit review on #4523)
- Handle synchronous error callbacks for failed cached images
- Add comprehensive test coverage (15 tests) including:
  - Synchronous cached image success (Firefox/Safari race condition)
  - Synchronous cached image error
  - Dynamic src changes
  - All props (crossOrigin, srcSet, sizes, loading)
  - Callback invocation verification

Reproduction and investigation performed using Claude Opus 4.5.

Fixes #4534, #2259

* fix(use-image): add ignoreFallback to useCallback dependencies

Address CodeRabbit review feedback: the `ignoreFallback` prop was used
inside the `load` callback (line 104) but was missing from the dependency
array, creating a stale closure bug.

Without this fix, if `ignoreFallback` changes from `true` to `false`
dynamically, the `load` callback would retain the stale `true` value,
preventing the image from ever loading.

Changes:
- Add `ignoreFallback` to useCallback dependency array
- Add tests for dynamic `ignoreFallback` changes (both directions)
- Update changeset to document this fix

Verification performed using Claude Opus 4.5.

---------

Co-authored-by: Brian Meek <brian@current.space>

* fix(docs): broken links in Form page (#6077)

* fix(pagination): improve layout for large page counts (#6034)

* fix(pagination): improve layout for large page counts/style of paagination compnents

* fix(pagination): refine item sizing to balance small and large page numbers

* ci(changesets): add pagination sizing changeset

* fix(pagination): ensure cursor fully covers button without changing radius

* chore(changeset): revise message and add issue numbers

---------

Co-authored-by: WK Wong <wingkwong.code@gmail.com>

* fix(date-picker): open date-picker when clicking border (#6084)

* fix(date-picker): add pointer interaction to open date picker on wrapper click

* chore: add changeset

* chore(changeset): add issue number

---------

Co-authored-by: WK <wingkwong.code@gmail.com>

* fix(accordion): click behaviour for dynamically generated accordion items (#6133)

* fix(accordion): add collection state

* chore: add changeset

* fix: update change set

* refactor(theme): remove flat dependency (#6157)

* chore(deps): remove flat library

* refactor(theme): replace flatten from flat

* chore: add changeset

* fix(listbox): prevent option focus from start/end content slots (#6060)

* fix(listbox): prevent option focus from start/end content slots

* test: add test code about when clicking
non-interactive slot content, and prevented focus leakage from interactive
start/end content such as buttons.

* docs: add changeset

* chore(changeset): add issue number

---------

Co-authored-by: WK <wingkwong.code@gmail.com>

* fix(system-rsc): extendVariants & compound variants types (#5847)

* fix(extendVariants): return component type error

* fix(CompoundVariants): correct type inference for extended/compound variants and composition

* test: cover compound/extend inference; enforce CP required props

* fix(types): correct CompoundVariants class value inference

Replaces the conditional ClassProp logic with a simpler,
consistent form to fix incorrect slot value inference.

Before:
  ClassProp<S extends undefined ? ClassValue : ClassValue | SlotsClassValue<S>>

After:
  ClassProp<ClassValue | GetSuggestedValues<S>>

This ensures GetSuggestedValues<S> is used for slot-aware variants
and avoids duplicated conditional branches for undefined slots.

* fix(system-rsc): correct slot detection in getSlots()

* fix(types): make ExtendVariants props optional and guard V[key] with NonNullable

Simplifies the return type of ExtendVariants to ensure no required props
are enforced at the HOC level. This aligns with the intended API contract
where extended components expose all props as optional.

- All keys (CP ∪ V) are optional
- Preserve CP type hints and booleanized V values
- Added NonNullable<V[key]> guard to prevent undefined indexing

* test(extendVariants): add compoundVariants integration test

* fix(system-rsc): getSlots() brief JSDoc comment added

* test(extendVariants):  new styles - extended & fixed styles - original tests for slots component

* test(extendVariants): fixed slot component variant styles extended test

* fix(types): avoid leaking React internals by removing PropsWithoutRef

Replace PropsWithoutRef with explicit Exclude<'ref'> in mapped keys and
intersect with RefAttributes<InferRef<C>>. This prevents @types/react’s
internal UNDEFINED_VOID_ONLY from leaking into the public .d.ts and fixes
declaration emit for components like extended Autocomplete.

* chore(changeset): add patch for extendVariants and CompoundVariants type fix

* chore(system-rsc): add changeset for getSlots() slot detection fix

* refactor(types): unify slot value inference via GetSuggestedValues<S> for consistent variant typing

* fix(extendVariants): improved as-prop handling and exclude classNames from SuggestedVariants

* fix(system-rsc): add polymorphic 'as' prop support to extendVariants

* chore(system-rsc): add missing tests

---------

Co-authored-by: doki- <1335902682@qq.com>
Co-authored-by: WK Wong <wingkwong.code@gmail.com>

* chore(docs): update meta (#6168)

* ci(changesets): version packages (#6059)

Co-authored-by: Junior Garcia <jrgarciadev@gmail.com>

---------

Co-authored-by: Hayato Hasegawa <hase1225hayato@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Junior Garcia <jrgarciadev@gmail.com>
Co-authored-by: brianatdetections <brian@detections.ai>
Co-authored-by: Brian Meek <brian@current.space>
Co-authored-by: Dominik Hryshaiev <domhryshaiev@gmail.com>
Co-authored-by: creative-atish <149860680+atishkr25@users.noreply.github.com>
Co-authored-by: KyZy7 <29321162+KyZy7@users.noreply.github.com>
Co-authored-by: Deepansh Bhargava <deepansh940@gmail.com>
Co-authored-by: KumJungMin <37934668+KumJungMin@users.noreply.github.com>
Co-authored-by: Bohdan Kulinchenko <35272606+ITBoomBKStudio@users.noreply.github.com>
Co-authored-by: doki- <1335902682@qq.com>
jrgarciadev added a commit that referenced this pull request Feb 18, 2026
@wingkwong @hasegawa-101
@github-actions @jrgarciadev @brianatdetections @brianathere @domhhv @atishkr25 @KyZy7 @deepansh946 @KumJungMin @ITBoomBKStudio @IsDyh01 @KMNowak
v2.8.9 (#6228)
3adfef7 
* fix(theme): hide password reveal button (#5990)

* fix(link): link overriding role (#5999)

* fix(link): allow overriding role

* chore(link): changeset

* chore(deps): upgrade react-aria (v1.14.0) (#5996)

* chore(deps): upgrade react-aria (v1.14.0)

* refactor(react): group client components

* fix(dropdown): keyDown test cases

* chore(react): rollback

* fix(theme): default transition-duration (#6011)

* fix(theme): default transitionDuration

* chore(deps): bump @heroui/theme peer dep

* ci(changesets): version packages (#5991)

Co-authored-by: Junior Garcia <jrgarciadev@gmail.com>

* fix(use-image): resolve race condition with cached images on Firefox/Safari (#6041)

* fix(use-image): resolve race condition with cached images on Firefox/Safari

The bug occurred because event handlers (onload/onerror) were attached
AFTER setting the image src. For cached images, browsers fire onload
synchronously when src is set, causing the event to be missed and
images to remain stuck at opacity-0.

Changes:
- Attach handlers BEFORE setting src to catch synchronous callbacks
- Check both naturalWidth AND naturalHeight (per CodeRabbit review on #4523)
- Handle synchronous error callbacks for failed cached images
- Add comprehensive test coverage (15 tests) including:
  - Synchronous cached image success (Firefox/Safari race condition)
  - Synchronous cached image error
  - Dynamic src changes
  - All props (crossOrigin, srcSet, sizes, loading)
  - Callback invocation verification

Reproduction and investigation performed using Claude Opus 4.5.

Fixes #4534, #2259

* fix(use-image): add ignoreFallback to useCallback dependencies

Address CodeRabbit review feedback: the `ignoreFallback` prop was used
inside the `load` callback (line 104) but was missing from the dependency
array, creating a stale closure bug.

Without this fix, if `ignoreFallback` changes from `true` to `false`
dynamically, the `load` callback would retain the stale `true` value,
preventing the image from ever loading.

Changes:
- Add `ignoreFallback` to useCallback dependency array
- Add tests for dynamic `ignoreFallback` changes (both directions)
- Update changeset to document this fix

Verification performed using Claude Opus 4.5.

---------

Co-authored-by: Brian Meek <brian@current.space>

* fix(docs): broken links in Form page (#6077)

* fix(pagination): improve layout for large page counts (#6034)

* fix(pagination): improve layout for large page counts/style of paagination compnents

* fix(pagination): refine item sizing to balance small and large page numbers

* ci(changesets): add pagination sizing changeset

* fix(pagination): ensure cursor fully covers button without changing radius

* chore(changeset): revise message and add issue numbers

---------

Co-authored-by: WK Wong <wingkwong.code@gmail.com>

* fix(date-picker): open date-picker when clicking border (#6084)

* fix(date-picker): add pointer interaction to open date picker on wrapper click

* chore: add changeset

* chore(changeset): add issue number

---------

Co-authored-by: WK <wingkwong.code@gmail.com>

* fix(accordion): click behaviour for dynamically generated accordion items (#6133)

* fix(accordion): add collection state

* chore: add changeset

* fix: update change set

* refactor(theme): remove flat dependency (#6157)

* chore(deps): remove flat library

* refactor(theme): replace flatten from flat

* chore: add changeset

* fix(listbox): prevent option focus from start/end content slots (#6060)

* fix(listbox): prevent option focus from start/end content slots

* test: add test code about when clicking
non-interactive slot content, and prevented focus leakage from interactive
start/end content such as buttons.

* docs: add changeset

* chore(changeset): add issue number

---------

Co-authored-by: WK <wingkwong.code@gmail.com>

* fix(system-rsc): extendVariants & compound variants types (#5847)

* fix(extendVariants): return component type error

* fix(CompoundVariants): correct type inference for extended/compound variants and composition

* test: cover compound/extend inference; enforce CP required props

* fix(types): correct CompoundVariants class value inference

Replaces the conditional ClassProp logic with a simpler,
consistent form to fix incorrect slot value inference.

Before:
  ClassProp<S extends undefined ? ClassValue : ClassValue | SlotsClassValue<S>>

After:
  ClassProp<ClassValue | GetSuggestedValues<S>>

This ensures GetSuggestedValues<S> is used for slot-aware variants
and avoids duplicated conditional branches for undefined slots.

* fix(system-rsc): correct slot detection in getSlots()

* fix(types): make ExtendVariants props optional and guard V[key] with NonNullable

Simplifies the return type of ExtendVariants to ensure no required props
are enforced at the HOC level. This aligns with the intended API contract
where extended components expose all props as optional.

- All keys (CP ∪ V) are optional
- Preserve CP type hints and booleanized V values
- Added NonNullable<V[key]> guard to prevent undefined indexing

* test(extendVariants): add compoundVariants integration test

* fix(system-rsc): getSlots() brief JSDoc comment added

* test(extendVariants):  new styles - extended & fixed styles - original tests for slots component

* test(extendVariants): fixed slot component variant styles extended test

* fix(types): avoid leaking React internals by removing PropsWithoutRef

Replace PropsWithoutRef with explicit Exclude<'ref'> in mapped keys and
intersect with RefAttributes<InferRef<C>>. This prevents @types/react’s
internal UNDEFINED_VOID_ONLY from leaking into the public .d.ts and fixes
declaration emit for components like extended Autocomplete.

* chore(changeset): add patch for extendVariants and CompoundVariants type fix

* chore(system-rsc): add changeset for getSlots() slot detection fix

* refactor(types): unify slot value inference via GetSuggestedValues<S> for consistent variant typing

* fix(extendVariants): improved as-prop handling and exclude classNames from SuggestedVariants

* fix(system-rsc): add polymorphic 'as' prop support to extendVariants

* chore(system-rsc): add missing tests

---------

Co-authored-by: doki- <1335902682@qq.com>
Co-authored-by: WK Wong <wingkwong.code@gmail.com>

* chore(docs): update meta (#6168)

* ci(changesets): version packages (#6059)

Co-authored-by: Junior Garcia <jrgarciadev@gmail.com>

* fix(system-rsc): extendVariants rendering behavior with as (#6215)

* fix(system-rsc): fix components rendering with 'as' prop

* fix(system-rsc): fix compoundVariants and slots inheritance in extendVariants

* fix(system-rsc): extendVariants test file cleaned

* chore(deps): bump RA dependencies (#6221)

* chore(deps): bump RA dependencies

* chore(date-picker): revise test cases

* fix(button): correct disableRipple prop precedence (#6199)

* ci(changesets): version packages (#6227)

Co-authored-by: Junior Garcia <jrgarciadev@gmail.com>

---------

Co-authored-by: Hayato Hasegawa <hase1225hayato@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Junior Garcia <jrgarciadev@gmail.com>
Co-authored-by: brianatdetections <brian@detections.ai>
Co-authored-by: Brian Meek <brian@current.space>
Co-authored-by: Dominik Hryshaiev <domhryshaiev@gmail.com>
Co-authored-by: creative-atish <149860680+atishkr25@users.noreply.github.com>
Co-authored-by: KyZy7 <29321162+KyZy7@users.noreply.github.com>
Co-authored-by: Deepansh Bhargava <deepansh940@gmail.com>
Co-authored-by: KumJungMin <37934668+KumJungMin@users.noreply.github.com>
Co-authored-by: Bohdan Kulinchenko <35272606+ITBoomBKStudio@users.noreply.github.com>
Co-authored-by: doki- <1335902682@qq.com>
Co-authored-by: Chris Nowak <krzysztofmareknowak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrgarciadev jrgarciadev Awaiting requested review from jrgarciadev

@wingkwong wingkwong Awaiting requested review from wingkwong

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.8.8

Development

Successfully merging this pull request may close these issues.

[BUG] - Focus on previous entry when you click on the DatePicker border

2 participants

@KyZy7 @wingkwong