fix(accordion): Fix click behaviour for dynamically generated accordion items by deepansh946 · Pull Request #6133 · heroui-inc/heroui

deepansh946 · 2026-01-21T13:35:03Z

📝 Description

Fixed a bug where newly added dynamic accordion items don't respond to click events. The issue occurred when accordion items were dynamically added to the DOM. The newly added items would not open/close on click until other accordion items were interacted with first.

Root Cause: The values memoization in useAccordion didn't track state.collection as a dependency, causing accordion items to receive stale state references when the collection changed.

Solution: Added state.collection to the dependency array of the values useMemo hook, ensuring that when items are dynamically added or removed, all accordion items receive the updated state reference.

⛳️ Current behavior

When dynamically adding accordion items, newly added items sometimes don't respond to click events
The issue resolves if the accordion is clicked on existing items

🚀 New behavior

Newly added accordion items are immediately interactive and respond to click events
All accordion items (existing and new) maintain proper state synchronization

💣 Is this a breaking change (Yes/No):

No

Demo

Screen.Recording.2026-01-21.at.6.59.09.PM.mov

changeset-bot · 2026-01-21T13:35:08Z

🦋 Changeset detected

Latest commit: 36283cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@heroui/accordion	Patch
@heroui/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2026-01-21T13:35:09Z

@deepansh946 is attempting to deploy a commit to the HeroUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

pkg-pr-new · 2026-01-21T13:41:35Z

Open in StackBlitz

@heroui/accordion

npm i https://pkg.pr.new/@heroui/accordion@6133

@heroui/alert

npm i https://pkg.pr.new/@heroui/alert@6133

@heroui/autocomplete

npm i https://pkg.pr.new/@heroui/autocomplete@6133

@heroui/avatar

npm i https://pkg.pr.new/@heroui/avatar@6133

@heroui/badge

npm i https://pkg.pr.new/@heroui/badge@6133

@heroui/breadcrumbs

npm i https://pkg.pr.new/@heroui/breadcrumbs@6133

@heroui/button

npm i https://pkg.pr.new/@heroui/button@6133

@heroui/calendar

npm i https://pkg.pr.new/@heroui/calendar@6133

@heroui/card

npm i https://pkg.pr.new/@heroui/card@6133

@heroui/checkbox

npm i https://pkg.pr.new/@heroui/checkbox@6133

@heroui/chip

npm i https://pkg.pr.new/@heroui/chip@6133

@heroui/code

npm i https://pkg.pr.new/@heroui/code@6133

@heroui/date-input

npm i https://pkg.pr.new/@heroui/date-input@6133

@heroui/date-picker

npm i https://pkg.pr.new/@heroui/date-picker@6133

@heroui/divider

npm i https://pkg.pr.new/@heroui/divider@6133

@heroui/drawer

npm i https://pkg.pr.new/@heroui/drawer@6133

@heroui/dropdown

npm i https://pkg.pr.new/@heroui/dropdown@6133

@heroui/form

npm i https://pkg.pr.new/@heroui/form@6133

@heroui/image

npm i https://pkg.pr.new/@heroui/image@6133

@heroui/input

npm i https://pkg.pr.new/@heroui/input@6133

@heroui/input-otp

npm i https://pkg.pr.new/@heroui/input-otp@6133

@heroui/kbd

npm i https://pkg.pr.new/@heroui/kbd@6133

@heroui/link

npm i https://pkg.pr.new/@heroui/link@6133

@heroui/listbox

npm i https://pkg.pr.new/@heroui/listbox@6133

@heroui/menu

npm i https://pkg.pr.new/@heroui/menu@6133

@heroui/modal

npm i https://pkg.pr.new/@heroui/modal@6133

@heroui/navbar

npm i https://pkg.pr.new/@heroui/navbar@6133

@heroui/number-input

npm i https://pkg.pr.new/@heroui/number-input@6133

@heroui/pagination

npm i https://pkg.pr.new/@heroui/pagination@6133

@heroui/popover

npm i https://pkg.pr.new/@heroui/popover@6133

@heroui/progress

npm i https://pkg.pr.new/@heroui/progress@6133

@heroui/radio

npm i https://pkg.pr.new/@heroui/radio@6133

@heroui/ripple

npm i https://pkg.pr.new/@heroui/ripple@6133

@heroui/scroll-shadow

npm i https://pkg.pr.new/@heroui/scroll-shadow@6133

@heroui/select

npm i https://pkg.pr.new/@heroui/select@6133

@heroui/skeleton

npm i https://pkg.pr.new/@heroui/skeleton@6133

@heroui/slider

npm i https://pkg.pr.new/@heroui/slider@6133

@heroui/snippet

npm i https://pkg.pr.new/@heroui/snippet@6133

@heroui/spacer

npm i https://pkg.pr.new/@heroui/spacer@6133

@heroui/spinner

npm i https://pkg.pr.new/@heroui/spinner@6133

@heroui/switch

npm i https://pkg.pr.new/@heroui/switch@6133

@heroui/table

npm i https://pkg.pr.new/@heroui/table@6133

@heroui/tabs

npm i https://pkg.pr.new/@heroui/tabs@6133

@heroui/toast

npm i https://pkg.pr.new/@heroui/toast@6133

@heroui/tooltip

npm i https://pkg.pr.new/@heroui/tooltip@6133

@heroui/user

npm i https://pkg.pr.new/@heroui/user@6133

@heroui/react

npm i https://pkg.pr.new/@heroui/react@6133

@heroui/system

npm i https://pkg.pr.new/@heroui/system@6133

@heroui/system-rsc

npm i https://pkg.pr.new/@heroui/system-rsc@6133

@heroui/theme

npm i https://pkg.pr.new/@heroui/theme@6133

@heroui/use-aria-accordion

npm i https://pkg.pr.new/@heroui/use-aria-accordion@6133

@heroui/use-aria-accordion-item

npm i https://pkg.pr.new/@heroui/use-aria-accordion-item@6133

@heroui/use-aria-button

npm i https://pkg.pr.new/@heroui/use-aria-button@6133

@heroui/use-aria-link

npm i https://pkg.pr.new/@heroui/use-aria-link@6133

@heroui/use-aria-modal-overlay

npm i https://pkg.pr.new/@heroui/use-aria-modal-overlay@6133

@heroui/use-aria-multiselect

npm i https://pkg.pr.new/@heroui/use-aria-multiselect@6133

@heroui/use-aria-overlay

npm i https://pkg.pr.new/@heroui/use-aria-overlay@6133

@heroui/use-callback-ref

npm i https://pkg.pr.new/@heroui/use-callback-ref@6133

@heroui/use-clipboard

npm i https://pkg.pr.new/@heroui/use-clipboard@6133

@heroui/use-data-scroll-overflow

npm i https://pkg.pr.new/@heroui/use-data-scroll-overflow@6133

@heroui/use-disclosure

npm i https://pkg.pr.new/@heroui/use-disclosure@6133

@heroui/use-draggable

npm i https://pkg.pr.new/@heroui/use-draggable@6133

@heroui/use-form-reset

npm i https://pkg.pr.new/@heroui/use-form-reset@6133

@heroui/use-image

npm i https://pkg.pr.new/@heroui/use-image@6133

@heroui/use-infinite-scroll

npm i https://pkg.pr.new/@heroui/use-infinite-scroll@6133

@heroui/use-intersection-observer

npm i https://pkg.pr.new/@heroui/use-intersection-observer@6133

@heroui/use-is-mobile

npm i https://pkg.pr.new/@heroui/use-is-mobile@6133

@heroui/use-is-mounted

npm i https://pkg.pr.new/@heroui/use-is-mounted@6133

@heroui/use-measure

npm i https://pkg.pr.new/@heroui/use-measure@6133

@heroui/use-pagination

npm i https://pkg.pr.new/@heroui/use-pagination@6133

@heroui/use-real-shape

npm i https://pkg.pr.new/@heroui/use-real-shape@6133

@heroui/use-ref-state

npm i https://pkg.pr.new/@heroui/use-ref-state@6133

@heroui/use-resize

npm i https://pkg.pr.new/@heroui/use-resize@6133

@heroui/use-safe-layout-effect

npm i https://pkg.pr.new/@heroui/use-safe-layout-effect@6133

@heroui/use-scroll-position

npm i https://pkg.pr.new/@heroui/use-scroll-position@6133

@heroui/use-ssr

npm i https://pkg.pr.new/@heroui/use-ssr@6133

@heroui/use-theme

npm i https://pkg.pr.new/@heroui/use-theme@6133

@heroui/use-update-effect

npm i https://pkg.pr.new/@heroui/use-update-effect@6133

@heroui/use-viewport-size

npm i https://pkg.pr.new/@heroui/use-viewport-size@6133

@heroui/aria-utils

npm i https://pkg.pr.new/@heroui/aria-utils@6133

@heroui/dom-animation

npm i https://pkg.pr.new/@heroui/dom-animation@6133

@heroui/framer-utils

npm i https://pkg.pr.new/@heroui/framer-utils@6133

@heroui/react-rsc-utils

npm i https://pkg.pr.new/@heroui/react-rsc-utils@6133

@heroui/react-utils

npm i https://pkg.pr.new/@heroui/react-utils@6133

@heroui/shared-icons

npm i https://pkg.pr.new/@heroui/shared-icons@6133

@heroui/shared-utils

npm i https://pkg.pr.new/@heroui/shared-utils@6133

@heroui/stories-utils

npm i https://pkg.pr.new/@heroui/stories-utils@6133

@heroui/test-utils

npm i https://pkg.pr.new/@heroui/test-utils@6133

commit: 36283cf

deepansh946 · 2026-01-21T17:08:17Z

@wingkwong I have made the required changes.

vercel · 2026-01-22T02:28:26Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
heroui	Ready	Preview, Comment	Jan 22, 2026 2:30am
heroui-sb	Ready	Preview, Comment	Jan 22, 2026 2:30am

* fix(theme): hide password reveal button (#5990) * fix(link): link overriding role (#5999) * fix(link): allow overriding role * chore(link): changeset * chore(deps): upgrade react-aria (v1.14.0) (#5996) * chore(deps): upgrade react-aria (v1.14.0) * refactor(react): group client components * fix(dropdown): keyDown test cases * chore(react): rollback * fix(theme): default transition-duration (#6011) * fix(theme): default transitionDuration * chore(deps): bump @heroui/theme peer dep * ci(changesets): version packages (#5991) Co-authored-by: Junior Garcia <jrgarciadev@gmail.com> * fix(use-image): resolve race condition with cached images on Firefox/Safari (#6041) * fix(use-image): resolve race condition with cached images on Firefox/Safari The bug occurred because event handlers (onload/onerror) were attached AFTER setting the image src. For cached images, browsers fire onload synchronously when src is set, causing the event to be missed and images to remain stuck at opacity-0. Changes: - Attach handlers BEFORE setting src to catch synchronous callbacks - Check both naturalWidth AND naturalHeight (per CodeRabbit review on #4523) - Handle synchronous error callbacks for failed cached images - Add comprehensive test coverage (15 tests) including: - Synchronous cached image success (Firefox/Safari race condition) - Synchronous cached image error - Dynamic src changes - All props (crossOrigin, srcSet, sizes, loading) - Callback invocation verification Reproduction and investigation performed using Claude Opus 4.5. Fixes #4534, #2259 * fix(use-image): add ignoreFallback to useCallback dependencies Address CodeRabbit review feedback: the `ignoreFallback` prop was used inside the `load` callback (line 104) but was missing from the dependency array, creating a stale closure bug. Without this fix, if `ignoreFallback` changes from `true` to `false` dynamically, the `load` callback would retain the stale `true` value, preventing the image from ever loading. Changes: - Add `ignoreFallback` to useCallback dependency array - Add tests for dynamic `ignoreFallback` changes (both directions) - Update changeset to document this fix Verification performed using Claude Opus 4.5. --------- Co-authored-by: Brian Meek <brian@current.space> * fix(docs): broken links in Form page (#6077) * fix(pagination): improve layout for large page counts (#6034) * fix(pagination): improve layout for large page counts/style of paagination compnents * fix(pagination): refine item sizing to balance small and large page numbers * ci(changesets): add pagination sizing changeset * fix(pagination): ensure cursor fully covers button without changing radius * chore(changeset): revise message and add issue numbers --------- Co-authored-by: WK Wong <wingkwong.code@gmail.com> * fix(date-picker): open date-picker when clicking border (#6084) * fix(date-picker): add pointer interaction to open date picker on wrapper click * chore: add changeset * chore(changeset): add issue number --------- Co-authored-by: WK <wingkwong.code@gmail.com> * fix(accordion): click behaviour for dynamically generated accordion items (#6133) * fix(accordion): add collection state * chore: add changeset * fix: update change set * refactor(theme): remove flat dependency (#6157) * chore(deps): remove flat library * refactor(theme): replace flatten from flat * chore: add changeset * fix(listbox): prevent option focus from start/end content slots (#6060) * fix(listbox): prevent option focus from start/end content slots * test: add test code about when clicking non-interactive slot content, and prevented focus leakage from interactive start/end content such as buttons. * docs: add changeset * chore(changeset): add issue number --------- Co-authored-by: WK <wingkwong.code@gmail.com> * fix(system-rsc): extendVariants & compound variants types (#5847) * fix(extendVariants): return component type error * fix(CompoundVariants): correct type inference for extended/compound variants and composition * test: cover compound/extend inference; enforce CP required props * fix(types): correct CompoundVariants class value inference Replaces the conditional ClassProp logic with a simpler, consistent form to fix incorrect slot value inference. Before: ClassProp<S extends undefined ? ClassValue : ClassValue | SlotsClassValue<S>> After: ClassProp<ClassValue | GetSuggestedValues<S>> This ensures GetSuggestedValues<S> is used for slot-aware variants and avoids duplicated conditional branches for undefined slots. * fix(system-rsc): correct slot detection in getSlots() * fix(types): make ExtendVariants props optional and guard V[key] with NonNullable Simplifies the return type of ExtendVariants to ensure no required props are enforced at the HOC level. This aligns with the intended API contract where extended components expose all props as optional. - All keys (CP ∪ V) are optional - Preserve CP type hints and booleanized V values - Added NonNullable<V[key]> guard to prevent undefined indexing * test(extendVariants): add compoundVariants integration test * fix(system-rsc): getSlots() brief JSDoc comment added * test(extendVariants): new styles - extended & fixed styles - original tests for slots component * test(extendVariants): fixed slot component variant styles extended test * fix(types): avoid leaking React internals by removing PropsWithoutRef Replace PropsWithoutRef with explicit Exclude<'ref'> in mapped keys and intersect with RefAttributes<InferRef<C>>. This prevents @types/react’s internal UNDEFINED_VOID_ONLY from leaking into the public .d.ts and fixes declaration emit for components like extended Autocomplete. * chore(changeset): add patch for extendVariants and CompoundVariants type fix * chore(system-rsc): add changeset for getSlots() slot detection fix * refactor(types): unify slot value inference via GetSuggestedValues<S> for consistent variant typing * fix(extendVariants): improved as-prop handling and exclude classNames from SuggestedVariants * fix(system-rsc): add polymorphic 'as' prop support to extendVariants * chore(system-rsc): add missing tests --------- Co-authored-by: doki- <1335902682@qq.com> Co-authored-by: WK Wong <wingkwong.code@gmail.com> * chore(docs): update meta (#6168) * ci(changesets): version packages (#6059) Co-authored-by: Junior Garcia <jrgarciadev@gmail.com> --------- Co-authored-by: Hayato Hasegawa <hase1225hayato@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Junior Garcia <jrgarciadev@gmail.com> Co-authored-by: brianatdetections <brian@detections.ai> Co-authored-by: Brian Meek <brian@current.space> Co-authored-by: Dominik Hryshaiev <domhryshaiev@gmail.com> Co-authored-by: creative-atish <149860680+atishkr25@users.noreply.github.com> Co-authored-by: KyZy7 <29321162+KyZy7@users.noreply.github.com> Co-authored-by: Deepansh Bhargava <deepansh940@gmail.com> Co-authored-by: KumJungMin <37934668+KumJungMin@users.noreply.github.com> Co-authored-by: Bohdan Kulinchenko <35272606+ITBoomBKStudio@users.noreply.github.com> Co-authored-by: doki- <1335902682@qq.com>

heroui-inc/heroui#6133

* fix(theme): hide password reveal button (#5990) * fix(link): link overriding role (#5999) * fix(link): allow overriding role * chore(link): changeset * chore(deps): upgrade react-aria (v1.14.0) (#5996) * chore(deps): upgrade react-aria (v1.14.0) * refactor(react): group client components * fix(dropdown): keyDown test cases * chore(react): rollback * fix(theme): default transition-duration (#6011) * fix(theme): default transitionDuration * chore(deps): bump @heroui/theme peer dep * ci(changesets): version packages (#5991) Co-authored-by: Junior Garcia <jrgarciadev@gmail.com> * fix(use-image): resolve race condition with cached images on Firefox/Safari (#6041) * fix(use-image): resolve race condition with cached images on Firefox/Safari The bug occurred because event handlers (onload/onerror) were attached AFTER setting the image src. For cached images, browsers fire onload synchronously when src is set, causing the event to be missed and images to remain stuck at opacity-0. Changes: - Attach handlers BEFORE setting src to catch synchronous callbacks - Check both naturalWidth AND naturalHeight (per CodeRabbit review on #4523) - Handle synchronous error callbacks for failed cached images - Add comprehensive test coverage (15 tests) including: - Synchronous cached image success (Firefox/Safari race condition) - Synchronous cached image error - Dynamic src changes - All props (crossOrigin, srcSet, sizes, loading) - Callback invocation verification Reproduction and investigation performed using Claude Opus 4.5. Fixes #4534, #2259 * fix(use-image): add ignoreFallback to useCallback dependencies Address CodeRabbit review feedback: the `ignoreFallback` prop was used inside the `load` callback (line 104) but was missing from the dependency array, creating a stale closure bug. Without this fix, if `ignoreFallback` changes from `true` to `false` dynamically, the `load` callback would retain the stale `true` value, preventing the image from ever loading. Changes: - Add `ignoreFallback` to useCallback dependency array - Add tests for dynamic `ignoreFallback` changes (both directions) - Update changeset to document this fix Verification performed using Claude Opus 4.5. --------- Co-authored-by: Brian Meek <brian@current.space> * fix(docs): broken links in Form page (#6077) * fix(pagination): improve layout for large page counts (#6034) * fix(pagination): improve layout for large page counts/style of paagination compnents * fix(pagination): refine item sizing to balance small and large page numbers * ci(changesets): add pagination sizing changeset * fix(pagination): ensure cursor fully covers button without changing radius * chore(changeset): revise message and add issue numbers --------- Co-authored-by: WK Wong <wingkwong.code@gmail.com> * fix(date-picker): open date-picker when clicking border (#6084) * fix(date-picker): add pointer interaction to open date picker on wrapper click * chore: add changeset * chore(changeset): add issue number --------- Co-authored-by: WK <wingkwong.code@gmail.com> * fix(accordion): click behaviour for dynamically generated accordion items (#6133) * fix(accordion): add collection state * chore: add changeset * fix: update change set * refactor(theme): remove flat dependency (#6157) * chore(deps): remove flat library * refactor(theme): replace flatten from flat * chore: add changeset * fix(listbox): prevent option focus from start/end content slots (#6060) * fix(listbox): prevent option focus from start/end content slots * test: add test code about when clicking non-interactive slot content, and prevented focus leakage from interactive start/end content such as buttons. * docs: add changeset * chore(changeset): add issue number --------- Co-authored-by: WK <wingkwong.code@gmail.com> * fix(system-rsc): extendVariants & compound variants types (#5847) * fix(extendVariants): return component type error * fix(CompoundVariants): correct type inference for extended/compound variants and composition * test: cover compound/extend inference; enforce CP required props * fix(types): correct CompoundVariants class value inference Replaces the conditional ClassProp logic with a simpler, consistent form to fix incorrect slot value inference. Before: ClassProp<S extends undefined ? ClassValue : ClassValue | SlotsClassValue<S>> After: ClassProp<ClassValue | GetSuggestedValues<S>> This ensures GetSuggestedValues<S> is used for slot-aware variants and avoids duplicated conditional branches for undefined slots. * fix(system-rsc): correct slot detection in getSlots() * fix(types): make ExtendVariants props optional and guard V[key] with NonNullable Simplifies the return type of ExtendVariants to ensure no required props are enforced at the HOC level. This aligns with the intended API contract where extended components expose all props as optional. - All keys (CP ∪ V) are optional - Preserve CP type hints and booleanized V values - Added NonNullable<V[key]> guard to prevent undefined indexing * test(extendVariants): add compoundVariants integration test * fix(system-rsc): getSlots() brief JSDoc comment added * test(extendVariants): new styles - extended & fixed styles - original tests for slots component * test(extendVariants): fixed slot component variant styles extended test * fix(types): avoid leaking React internals by removing PropsWithoutRef Replace PropsWithoutRef with explicit Exclude<'ref'> in mapped keys and intersect with RefAttributes<InferRef<C>>. This prevents @types/react’s internal UNDEFINED_VOID_ONLY from leaking into the public .d.ts and fixes declaration emit for components like extended Autocomplete. * chore(changeset): add patch for extendVariants and CompoundVariants type fix * chore(system-rsc): add changeset for getSlots() slot detection fix * refactor(types): unify slot value inference via GetSuggestedValues<S> for consistent variant typing * fix(extendVariants): improved as-prop handling and exclude classNames from SuggestedVariants * fix(system-rsc): add polymorphic 'as' prop support to extendVariants * chore(system-rsc): add missing tests --------- Co-authored-by: doki- <1335902682@qq.com> Co-authored-by: WK Wong <wingkwong.code@gmail.com> * chore(docs): update meta (#6168) * ci(changesets): version packages (#6059) Co-authored-by: Junior Garcia <jrgarciadev@gmail.com> --------- Co-authored-by: Hayato Hasegawa <hase1225hayato@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Junior Garcia <jrgarciadev@gmail.com> Co-authored-by: brianatdetections <brian@detections.ai> Co-authored-by: Brian Meek <brian@current.space> Co-authored-by: Dominik Hryshaiev <domhryshaiev@gmail.com> Co-authored-by: creative-atish <149860680+atishkr25@users.noreply.github.com> Co-authored-by: KyZy7 <29321162+KyZy7@users.noreply.github.com> Co-authored-by: Deepansh Bhargava <deepansh940@gmail.com> Co-authored-by: KumJungMin <37934668+KumJungMin@users.noreply.github.com> Co-authored-by: Bohdan Kulinchenko <35272606+ITBoomBKStudio@users.noreply.github.com> Co-authored-by: doki- <1335902682@qq.com>

* fix(theme): hide password reveal button (#5990) * fix(link): link overriding role (#5999) * fix(link): allow overriding role * chore(link): changeset * chore(deps): upgrade react-aria (v1.14.0) (#5996) * chore(deps): upgrade react-aria (v1.14.0) * refactor(react): group client components * fix(dropdown): keyDown test cases * chore(react): rollback * fix(theme): default transition-duration (#6011) * fix(theme): default transitionDuration * chore(deps): bump @heroui/theme peer dep * ci(changesets): version packages (#5991) Co-authored-by: Junior Garcia <jrgarciadev@gmail.com> * fix(use-image): resolve race condition with cached images on Firefox/Safari (#6041) * fix(use-image): resolve race condition with cached images on Firefox/Safari The bug occurred because event handlers (onload/onerror) were attached AFTER setting the image src. For cached images, browsers fire onload synchronously when src is set, causing the event to be missed and images to remain stuck at opacity-0. Changes: - Attach handlers BEFORE setting src to catch synchronous callbacks - Check both naturalWidth AND naturalHeight (per CodeRabbit review on #4523) - Handle synchronous error callbacks for failed cached images - Add comprehensive test coverage (15 tests) including: - Synchronous cached image success (Firefox/Safari race condition) - Synchronous cached image error - Dynamic src changes - All props (crossOrigin, srcSet, sizes, loading) - Callback invocation verification Reproduction and investigation performed using Claude Opus 4.5. Fixes #4534, #2259 * fix(use-image): add ignoreFallback to useCallback dependencies Address CodeRabbit review feedback: the `ignoreFallback` prop was used inside the `load` callback (line 104) but was missing from the dependency array, creating a stale closure bug. Without this fix, if `ignoreFallback` changes from `true` to `false` dynamically, the `load` callback would retain the stale `true` value, preventing the image from ever loading. Changes: - Add `ignoreFallback` to useCallback dependency array - Add tests for dynamic `ignoreFallback` changes (both directions) - Update changeset to document this fix Verification performed using Claude Opus 4.5. --------- Co-authored-by: Brian Meek <brian@current.space> * fix(docs): broken links in Form page (#6077) * fix(pagination): improve layout for large page counts (#6034) * fix(pagination): improve layout for large page counts/style of paagination compnents * fix(pagination): refine item sizing to balance small and large page numbers * ci(changesets): add pagination sizing changeset * fix(pagination): ensure cursor fully covers button without changing radius * chore(changeset): revise message and add issue numbers --------- Co-authored-by: WK Wong <wingkwong.code@gmail.com> * fix(date-picker): open date-picker when clicking border (#6084) * fix(date-picker): add pointer interaction to open date picker on wrapper click * chore: add changeset * chore(changeset): add issue number --------- Co-authored-by: WK <wingkwong.code@gmail.com> * fix(accordion): click behaviour for dynamically generated accordion items (#6133) * fix(accordion): add collection state * chore: add changeset * fix: update change set * refactor(theme): remove flat dependency (#6157) * chore(deps): remove flat library * refactor(theme): replace flatten from flat * chore: add changeset * fix(listbox): prevent option focus from start/end content slots (#6060) * fix(listbox): prevent option focus from start/end content slots * test: add test code about when clicking non-interactive slot content, and prevented focus leakage from interactive start/end content such as buttons. * docs: add changeset * chore(changeset): add issue number --------- Co-authored-by: WK <wingkwong.code@gmail.com> * fix(system-rsc): extendVariants & compound variants types (#5847) * fix(extendVariants): return component type error * fix(CompoundVariants): correct type inference for extended/compound variants and composition * test: cover compound/extend inference; enforce CP required props * fix(types): correct CompoundVariants class value inference Replaces the conditional ClassProp logic with a simpler, consistent form to fix incorrect slot value inference. Before: ClassProp<S extends undefined ? ClassValue : ClassValue | SlotsClassValue<S>> After: ClassProp<ClassValue | GetSuggestedValues<S>> This ensures GetSuggestedValues<S> is used for slot-aware variants and avoids duplicated conditional branches for undefined slots. * fix(system-rsc): correct slot detection in getSlots() * fix(types): make ExtendVariants props optional and guard V[key] with NonNullable Simplifies the return type of ExtendVariants to ensure no required props are enforced at the HOC level. This aligns with the intended API contract where extended components expose all props as optional. - All keys (CP ∪ V) are optional - Preserve CP type hints and booleanized V values - Added NonNullable<V[key]> guard to prevent undefined indexing * test(extendVariants): add compoundVariants integration test * fix(system-rsc): getSlots() brief JSDoc comment added * test(extendVariants): new styles - extended & fixed styles - original tests for slots component * test(extendVariants): fixed slot component variant styles extended test * fix(types): avoid leaking React internals by removing PropsWithoutRef Replace PropsWithoutRef with explicit Exclude<'ref'> in mapped keys and intersect with RefAttributes<InferRef<C>>. This prevents @types/react’s internal UNDEFINED_VOID_ONLY from leaking into the public .d.ts and fixes declaration emit for components like extended Autocomplete. * chore(changeset): add patch for extendVariants and CompoundVariants type fix * chore(system-rsc): add changeset for getSlots() slot detection fix * refactor(types): unify slot value inference via GetSuggestedValues<S> for consistent variant typing * fix(extendVariants): improved as-prop handling and exclude classNames from SuggestedVariants * fix(system-rsc): add polymorphic 'as' prop support to extendVariants * chore(system-rsc): add missing tests --------- Co-authored-by: doki- <1335902682@qq.com> Co-authored-by: WK Wong <wingkwong.code@gmail.com> * chore(docs): update meta (#6168) * ci(changesets): version packages (#6059) Co-authored-by: Junior Garcia <jrgarciadev@gmail.com> * fix(system-rsc): extendVariants rendering behavior with as (#6215) * fix(system-rsc): fix components rendering with 'as' prop * fix(system-rsc): fix compoundVariants and slots inheritance in extendVariants * fix(system-rsc): extendVariants test file cleaned * chore(deps): bump RA dependencies (#6221) * chore(deps): bump RA dependencies * chore(date-picker): revise test cases * fix(button): correct disableRipple prop precedence (#6199) * ci(changesets): version packages (#6227) Co-authored-by: Junior Garcia <jrgarciadev@gmail.com> --------- Co-authored-by: Hayato Hasegawa <hase1225hayato@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Junior Garcia <jrgarciadev@gmail.com> Co-authored-by: brianatdetections <brian@detections.ai> Co-authored-by: Brian Meek <brian@current.space> Co-authored-by: Dominik Hryshaiev <domhryshaiev@gmail.com> Co-authored-by: creative-atish <149860680+atishkr25@users.noreply.github.com> Co-authored-by: KyZy7 <29321162+KyZy7@users.noreply.github.com> Co-authored-by: Deepansh Bhargava <deepansh940@gmail.com> Co-authored-by: KumJungMin <37934668+KumJungMin@users.noreply.github.com> Co-authored-by: Bohdan Kulinchenko <35272606+ITBoomBKStudio@users.noreply.github.com> Co-authored-by: doki- <1335902682@qq.com> Co-authored-by: Chris Nowak <krzysztofmareknowak@gmail.com>

fix(accordion): add collection state

dc9fb54

deepansh946 requested a review from jrgarciadev as a code owner January 21, 2026 13:35

chore: add changeset

d2dbf6f

deepansh946 changed the title ~~fix(accordion): Fix click behaviour for dynamically generated accordion~~ fix(accordion): Fix click behaviour for dynamically generated accordion items Jan 21, 2026

wingkwong requested changes Jan 21, 2026

View reviewed changes

Comment thread .changeset/silver-readers-sleep.md Outdated

Comment thread .changeset/silver-readers-sleep.md Outdated

wingkwong added this to the v2.8.8 milestone Jan 21, 2026

fix: update change set

36283cf

deepansh946 requested a review from wingkwong January 21, 2026 17:08

wingkwong self-assigned this Jan 22, 2026

vercel Bot deployed to Preview – heroui-sb January 22, 2026 02:30 View deployment

vercel Bot deployed to Preview – heroui January 22, 2026 02:30 View deployment

wingkwong approved these changes Jan 27, 2026

View reviewed changes

wingkwong merged commit 96b1f49 into heroui-inc:canary Jan 27, 2026
10 checks passed

github-actions Bot mentioned this pull request Jan 6, 2026

ci(changesets): 📦 version packages #6059

Merged

AnYiEE added a commit to AnYiEE/touhou-mystia-izakaya-assistant that referenced this pull request Jan 30, 2026

fix(components): apply HeroUI patches

6a4239f

heroui-inc/heroui#6133

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(accordion): Fix click behaviour for dynamically generated accordion items#6133

fix(accordion): Fix click behaviour for dynamically generated accordion items#6133
wingkwong merged 3 commits into
heroui-inc:canaryfrom
deepansh946:fix/dynamic-accordian-bug

deepansh946 commented Jan 21, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Jan 21, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Jan 21, 2026

Uh oh!

pkg-pr-new Bot commented Jan 21, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

deepansh946 commented Jan 21, 2026

Uh oh!

vercel Bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

deepansh946 commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description

⛳️ Current behavior

🚀 New behavior

💣 Is this a breaking change (Yes/No):

Demo

Uh oh!

changeset-bot Bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel Bot commented Jan 21, 2026

Uh oh!

pkg-pr-new Bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

deepansh946 commented Jan 21, 2026

Uh oh!

vercel Bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

deepansh946 commented Jan 21, 2026 •

edited

Loading

changeset-bot Bot commented Jan 21, 2026 •

edited

Loading

pkg-pr-new Bot commented Jan 21, 2026 •

edited

Loading

vercel Bot commented Jan 22, 2026 •

edited

Loading