v2.8.7#6022
Conversation
* fix(link): allow overriding role * chore(link): changeset
* chore(deps): upgrade react-aria (v1.14.0) * refactor(react): group client components * fix(dropdown): keyDown test cases * chore(react): rollback
* fix(theme): default transitionDuration * chore(deps): bump @heroui/theme peer dep
Co-authored-by: Junior Garcia <jrgarciadev@gmail.com>
|
WalkthroughThis PR performs a comprehensive dependency version bump across the monorepo. It updates React Aria, React Stately, and HeroUI package versions to newer patch/minor versions, adds a new client entry file, introduces a new onAction API to DropdownMenu, and implements minor styling/theme adjustments including password button hiding and transition duration fixes. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Areas requiring extra attention:
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (2 warnings, 1 inconclusive)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
♻️ Duplicate comments (1)
packages/components/image/package.json (1)
39-39: Consider version bump consistency.Similar to the kbd package, this package only updates the peer dependency without bumping its own version. Consider whether this aligns with the versioning strategy used by other packages in this PR.
🧹 Nitpick comments (4)
packages/components/input-otp/CHANGELOG.md (1)
3-11: Changelog entry is incomplete.The changelog documents the react-aria upgrade but omits several dependency updates visible in package.json:
@react-stately/utils(3.10.8 → 3.11.0)@react-aria/focus(3.21.2 → 3.21.3)- Peer dependency
@heroui/theme(≥2.4.23 → ≥2.4.24)While the react-aria monorepo version (v1.14.0) is mentioned, listing the individual package updates would provide better transparency for consumers.
packages/components/progress/CHANGELOG.md (1)
3-7: Optional: consider adding anUpdated dependenciesblock for2.2.24If
@heroui/progress’s internal or peer dependencies were updated in this release (e.g., theme/other internal packages), you may want to mirror other components and add an explicitUpdated dependenciesbullet under2.2.24for consistency with the rest of the changelog.
packages/components/kbd/package.json (1)
39-39: Consider version bump consistency across packages.This package only updates the peer dependency without bumping its own version, while other packages in this PR (menu, drawer, dropdown, spinner) do bump versions when making similar peer dependency updates. Consider establishing a consistent versioning strategy across the monorepo for peer dependency changes.
packages/components/link/src/use-link.ts (1)
113-115: The explicit href handling is intentional for ensuring proper href precedence across element types.The pattern
href: (linkProps as AnchorHTMLAttributes<HTMLAnchorElement>).hrefis not redundant. It ensures that the href fromlinkProps(provided by react-aria'suseLinkProps()) takes precedence in the merged props, overriding any href that might appear inotherProps. This is necessary to guarantee correct behavior when the component renders as different element types.The test suite confirms this is working as intended: when
as="button"is used, the rendered button element correctly has no href attribute, even though the linkProps may contain one. The type cast toAnchorHTMLAttributes<HTMLAnchorElement>is technically unsafe but functionally safe becauselinkProps.hrefwill beundefinedfor non-anchor element types.Consider adding an inline comment explaining that this explicit href handling ensures proper precedence when merging props across different element types (anchor vs. button).
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (107)
apps/docs/components/docs/components/code-demo/parse-dependencies.ts(1 hunks)apps/docs/content/docs/components/date-input.mdx(6 hunks)apps/docs/content/docs/components/date-picker.mdx(6 hunks)apps/docs/content/docs/components/date-range-picker.mdx(7 hunks)apps/docs/package.json(2 hunks)packages/components/accordion/CHANGELOG.md(1 hunks)packages/components/accordion/package.json(3 hunks)packages/components/alert/CHANGELOG.md(1 hunks)packages/components/alert/package.json(2 hunks)packages/components/autocomplete/CHANGELOG.md(1 hunks)packages/components/autocomplete/package.json(4 hunks)packages/components/avatar/CHANGELOG.md(1 hunks)packages/components/avatar/package.json(2 hunks)packages/components/badge/package.json(1 hunks)packages/components/breadcrumbs/CHANGELOG.md(1 hunks)packages/components/breadcrumbs/package.json(2 hunks)packages/components/button/CHANGELOG.md(1 hunks)packages/components/button/package.json(3 hunks)packages/components/calendar/CHANGELOG.md(1 hunks)packages/components/calendar/package.json(3 hunks)packages/components/card/CHANGELOG.md(1 hunks)packages/components/card/package.json(2 hunks)packages/components/checkbox/CHANGELOG.md(1 hunks)packages/components/checkbox/package.json(3 hunks)packages/components/chip/CHANGELOG.md(1 hunks)packages/components/chip/package.json(2 hunks)packages/components/code/package.json(1 hunks)packages/components/date-input/CHANGELOG.md(1 hunks)packages/components/date-input/package.json(2 hunks)packages/components/date-picker/CHANGELOG.md(1 hunks)packages/components/date-picker/package.json(3 hunks)packages/components/divider/package.json(1 hunks)packages/components/drawer/CHANGELOG.md(1 hunks)packages/components/drawer/package.json(2 hunks)packages/components/dropdown/CHANGELOG.md(1 hunks)packages/components/dropdown/__tests__/dropdown.test.tsx(3 hunks)packages/components/dropdown/package.json(3 hunks)packages/components/form/CHANGELOG.md(1 hunks)packages/components/form/package.json(2 hunks)packages/components/image/package.json(1 hunks)packages/components/input-otp/CHANGELOG.md(1 hunks)packages/components/input-otp/package.json(2 hunks)packages/components/input/CHANGELOG.md(1 hunks)packages/components/input/package.json(3 hunks)packages/components/kbd/package.json(1 hunks)packages/components/link/CHANGELOG.md(1 hunks)packages/components/link/__tests__/link.test.tsx(1 hunks)packages/components/link/package.json(2 hunks)packages/components/link/src/use-link.ts(2 hunks)packages/components/listbox/CHANGELOG.md(1 hunks)packages/components/listbox/package.json(3 hunks)packages/components/menu/CHANGELOG.md(1 hunks)packages/components/menu/package.json(3 hunks)packages/components/modal/CHANGELOG.md(1 hunks)packages/components/modal/package.json(3 hunks)packages/components/navbar/CHANGELOG.md(1 hunks)packages/components/navbar/package.json(3 hunks)packages/components/number-input/CHANGELOG.md(1 hunks)packages/components/number-input/package.json(3 hunks)packages/components/pagination/CHANGELOG.md(1 hunks)packages/components/pagination/package.json(3 hunks)packages/components/popover/CHANGELOG.md(1 hunks)packages/components/popover/package.json(3 hunks)packages/components/progress/CHANGELOG.md(1 hunks)packages/components/progress/package.json(2 hunks)packages/components/radio/CHANGELOG.md(1 hunks)packages/components/radio/package.json(2 hunks)packages/components/ripple/package.json(1 hunks)packages/components/scroll-shadow/package.json(1 hunks)packages/components/select/CHANGELOG.md(1 hunks)packages/components/select/package.json(3 hunks)packages/components/skeleton/package.json(1 hunks)packages/components/slider/CHANGELOG.md(1 hunks)packages/components/slider/package.json(2 hunks)packages/components/snippet/CHANGELOG.md(1 hunks)packages/components/snippet/package.json(3 hunks)packages/components/spacer/package.json(1 hunks)packages/components/spinner/CHANGELOG.md(1 hunks)packages/components/spinner/package.json(2 hunks)packages/components/switch/CHANGELOG.md(1 hunks)packages/components/switch/package.json(2 hunks)packages/components/table/CHANGELOG.md(1 hunks)packages/components/table/package.json(3 hunks)packages/components/tabs/CHANGELOG.md(1 hunks)packages/components/tabs/package.json(2 hunks)packages/components/toast/CHANGELOG.md(1 hunks)packages/components/toast/package.json(3 hunks)packages/components/tooltip/CHANGELOG.md(1 hunks)packages/components/tooltip/package.json(3 hunks)packages/components/user/CHANGELOG.md(1 hunks)packages/components/user/package.json(2 hunks)packages/core/react/CHANGELOG.md(1 hunks)packages/core/react/package.json(2 hunks)packages/core/react/src/client.ts(1 hunks)packages/core/system-rsc/package.json(1 hunks)packages/core/system/CHANGELOG.md(1 hunks)packages/core/system/package.json(2 hunks)packages/core/theme/CHANGELOG.md(1 hunks)packages/core/theme/package.json(1 hunks)packages/core/theme/src/components/input.ts(1 hunks)packages/core/theme/src/plugin.ts(0 hunks)packages/hooks/use-aria-accordion-item/CHANGELOG.md(1 hunks)packages/hooks/use-aria-accordion-item/package.json(2 hunks)packages/hooks/use-aria-accordion/CHANGELOG.md(1 hunks)packages/hooks/use-aria-accordion/package.json(2 hunks)packages/hooks/use-aria-button/CHANGELOG.md(1 hunks)packages/hooks/use-aria-button/package.json(2 hunks)
⛔ Files not processed due to max files limit (19)
- packages/hooks/use-aria-link/CHANGELOG.md
- packages/hooks/use-aria-link/package.json
- packages/hooks/use-aria-modal-overlay/CHANGELOG.md
- packages/hooks/use-aria-modal-overlay/package.json
- packages/hooks/use-aria-multiselect/CHANGELOG.md
- packages/hooks/use-aria-multiselect/package.json
- packages/hooks/use-aria-overlay/CHANGELOG.md
- packages/hooks/use-aria-overlay/package.json
- packages/hooks/use-disclosure/CHANGELOG.md
- packages/hooks/use-disclosure/package.json
- packages/hooks/use-draggable/CHANGELOG.md
- packages/hooks/use-draggable/package.json
- packages/hooks/use-pagination/CHANGELOG.md
- packages/hooks/use-pagination/package.json
- packages/utilities/aria-utils/CHANGELOG.md
- packages/utilities/aria-utils/package.json
- packages/utilities/framer-utils/CHANGELOG.md
- packages/utilities/framer-utils/package.json
- plop/component/package.json.hbs
💤 Files with no reviewable changes (1)
- packages/core/theme/src/plugin.ts
🧰 Additional context used
🧠 Learnings (4)
📚 Learning: 2025-10-25T17:08:46.283Z
Learnt from: adbjo
Repo: heroui-inc/heroui PR: 5846
File: packages/components/tabs/src/tabs.tsx:156-157
Timestamp: 2025-10-25T17:08:46.283Z
Learning: In packages/components/tabs/src/tabs.tsx, the renderTabs useMemo dependency array intentionally includes `variant` and `isVertical` to prevent potential side-effects, even though they might appear redundant based on static analysis.
Applied to files:
packages/components/menu/package.jsonpackages/components/input/package.jsonpackages/components/tabs/package.jsonpackages/components/number-input/package.jsonpackages/components/tabs/CHANGELOG.mdpackages/hooks/use-aria-button/package.jsonpackages/components/accordion/package.jsonpackages/components/navbar/package.jsonpackages/components/radio/package.jsonpackages/components/table/package.jsonpackages/components/select/package.jsonpackages/components/slider/package.jsonpackages/components/listbox/package.jsonpackages/components/checkbox/package.jsonpackages/components/switch/package.json
📚 Learning: 2025-10-25T17:11:59.338Z
Learnt from: adbjo
Repo: heroui-inc/heroui PR: 5846
File: packages/components/tabs/src/tabs.tsx:155-155
Timestamp: 2025-10-25T17:11:59.338Z
Learning: In packages/components/tabs/src/tabs.tsx, the renderTabs useMemo dependency array intentionally includes both `domRef` and `cursorRef` to maintain consistency in how ref objects are handled in dependency arrays, even though ref objects have stable identity across renders.
Applied to files:
packages/components/tabs/package.jsonpackages/components/checkbox/package.json
📚 Learning: 2025-10-27T21:48:35.308Z
Learnt from: adbjo
Repo: heroui-inc/heroui PR: 5846
File: packages/components/tabs/src/tabs.tsx:76-101
Timestamp: 2025-10-27T21:48:35.308Z
Learning: In packages/components/tabs/src/tabs.tsx, the updateCursorPosition useCallback dependency array intentionally includes `cursorRef.current` to handle the case where the cursor span element is unmounted and remounted (e.g., when `disableAnimation` or `disableCursorAnimation` toggles). This ensures the callback is recreated when the ref points to a new element, triggering a dependency chain that re-establishes the ResizeObserver and initializes the new cursor element with the data-initialized attribute.
</learning]
Applied to files:
packages/components/tabs/package.json
📚 Learning: 2025-10-27T21:52:33.324Z
Learnt from: adbjo
Repo: heroui-inc/heroui PR: 5846
File: packages/components/tabs/src/tabs.tsx:115-125
Timestamp: 2025-10-27T21:52:33.324Z
Learning: In packages/components/tabs/src/tabs.tsx, the useEffect dependency array at line 125 intentionally uses `domRef.current` rather than `domRef` because domRef.current can change between renders (when React sets it during the commit phase), whereas domRef itself has stable identity and won't change.
Applied to files:
packages/components/tabs/package.json
🔇 Additional comments (111)
packages/components/popover/CHANGELOG.md (1)
3-14: LGTM!The new version entry for 2.3.29 is properly formatted and accurately reflects the react-aria upgrade to v1.14.0 along with the corresponding dependency updates. The changelog follows the project's conventions with complete metadata and properly linked references.
packages/components/select/CHANGELOG.md (1)
3-18: Changelog entry is well-formatted and complete.The v2.4.30 entry follows the established format with correct version progression, proper PR and commit attribution, and comprehensive dependency tracking. All updated packages are listed with their corresponding versions.
packages/components/chip/CHANGELOG.md (1)
3-7: Changelog entry is well-formatted and properly documents the dependency upgrade.The new version 2.2.24 entry follows the changelog conventions, includes proper PR and commit references, and clearly documents the react-aria upgrade. The patch release classification aligns with the nature of the change.
packages/components/input/CHANGELOG.md (1)
3-12: Changelog entry for v2.4.30 is well-formatted and consistent.The new release section properly documents two patch changes (password button hiding and react-aria upgrade) with correct PR references and dependency updates. Formatting aligns with existing changelog entries.
packages/components/tooltip/CHANGELOG.md (1)
3-12: Changelog entry is properly formatted and documented.The new 2.2.26 release section follows the established pattern, includes proper PR/commit references, and clearly documents the react-aria upgrade and dependent package version bumps.
packages/components/listbox/CHANGELOG.md (1)
3-11: CHANGELOG entry is properly formatted and follows established conventions.The new 2.3.28 release entry includes the correct structure with version header, patch changes section, linked PR reference, commit attribution, and updated dependencies. The patch version bump from 2.3.27 is semantically appropriate for the react-aria upgrade scope.
packages/components/drawer/CHANGELOG.md (1)
3-9: Changelog entry is properly formatted and complete.The new version 2.2.26 entry correctly reflects the patch version bump with updated dependency versions for @heroui/modal and @heroui/framer-utils. The entry follows the established changelog format, and the commit reference allows users to inspect the detailed changes if needed. For dependency-only updates in a monorepo, this sparse description is appropriate.
packages/components/number-input/CHANGELOG.md (1)
3-11: Changelog entry verified as accurate.The commit hash
e07c969and PR #5996 reference are correct, and the dependency versions (@heroui/button@2.2.29, @heroui/form@2.1.29) are confirmed as released. The version 2.0.20 entry follows established changelog conventions and documents the react-aria upgrade appropriately.packages/components/ripple/package.json (1)
40-40: LGTM. The peer dependency update to@heroui/theme>=2.4.24 is appropriate. Version 2.4.24 is the latest version, published recently. The release includes bug fixes for table virtualization in Firefox, toast text handling, Safari autofill styling, tab cursor behavior, and label placement—all non-breaking improvements that align with the monorepo's coordinated dependency updates.packages/components/user/package.json (1)
3-3: LGTM! Coordinated version bump.The version and dependency updates align with the monorepo-wide update. The patch version increments are appropriate. @react-aria/focus version 3.21.3 is current and has no known security vulnerabilities.
packages/components/chip/package.json (3)
3-3: LGTM! Patch version bump is appropriate.The version increment from 2.2.23 to 2.2.24 follows semantic versioning and aligns with the coordinated monorepo-wide dependency updates described in the PR.
39-39: LGTM! Peer dependency constraint is properly aligned.The @heroui/theme peer dependency update from >=2.4.23 to >=2.4.24 maintains consistency across the monorepo and ensures consumers use compatible versions.
46-47: React Aria dependency versions are valid; both updates are recent releases.@react-aria/focus@3.21.3 and @react-aria/interactions@3.26.0 are confirmed in the React Aria v1.14.0 release. Both versions are legitimate, with no known security advisories affecting React Aria packages.
packages/components/input-otp/package.json (2)
3-3: LGTM!Version bump follows semantic versioning for a patch release.
39-39: Verify peer dependency availability.The updated peer dependency requirement (
@heroui/theme≥2.4.24) may require consumers to upgrade. Ensure version 2.4.24 is published and available before releasing this version.packages/components/slider/package.json (3)
3-3: LGTM: Version bump is consistent with the changelog.The patch version increment from 2.4.25 to 2.4.26 appropriately reflects the dependency updates documented in the changelog.
39-39: Peer dependency update aligns with monorepo upgrade.The
@heroui/themepeer dependency constraint was tightened from>=2.4.23to>=2.4.24, which aligns with the broader monorepo upgrade scope mentioned in the PR summary.
46-51: Verify that @react-aria/slider@3.8.3, @react-aria/visually-hidden@3.8.29, and @react-aria/interactions@3.26.0 are published versions.Three of the specified react-aria versions do not exist on npm: @react-aria/slider@3.8.3 (latest published is 3.8.2), @react-aria/visually-hidden@3.8.29 (latest published is 3.8.28), and @react-aria/interactions@3.26.0 (latest published is 3.25.3). Ensure these versions are released before deploying, or update to the latest published versions to avoid installation failures.
packages/components/slider/CHANGELOG.md (1)
3-11: LGTM: Well-documented changelog entry.The changelog entry for version 2.4.26 is properly formatted, includes appropriate references to the PR (#5996) and commit hash, and clearly documents the react-aria v1.14.0 upgrade with updated dependencies. The format is consistent with previous entries.
packages/components/radio/CHANGELOG.md (1)
3-11: LGTM! Changelog entry is well-documented.The changelog appropriately documents the patch release with the React Aria upgrade and dependency updates. The format is consistent with previous entries.
packages/components/radio/package.json (3)
3-3: LGTM! Version bump is appropriate.The patch version increment (2.3.28 → 2.3.29) is appropriate for a dependency update release.
39-39: LGTM! Peer dependency update is consistent.The peer dependency update for
@heroui/theme(>=2.4.23 → >=2.4.24) aligns with the broader monorepo dependency coordination.
46-50: Package versions are valid and aligned with React Aria v1.14.0.The React Aria and React Stately dependency updates are confirmed to exist and match the official v1.14.0 release. The minor version bump in
@react-aria/interactions(3.25.6 → 3.26.0) is part of the standard release cycle. No security advisories apply to these React Aria packages.packages/components/tooltip/package.json (3)
3-3: LGTM: Standard patch version bump.The version increment from 2.2.25 to 2.2.26 follows semantic versioning conventions for a patch release.
51-55: React Aria/Stately dependency versions are valid and stable. @react-aria/overlays 3.31.0 is the latest version, and @react-aria/tooltip demonstrates healthy maintenance with positive release cadence. These dependencies are not affected by the recent React Server Components vulnerability (CVE-2025-55182), which targets different React packages. No issues identified.
40-40: The @heroui/theme peer dependency bump to >=2.4.24 is consistent with other components.The monorepo's @heroui/theme is at version 2.4.25, which satisfies the requirement. Multiple components (button, badge, card) already use the same >=2.4.24 constraint, confirming this version bump is coordinated across the codebase.
packages/components/modal/package.json (3)
3-3: LGTM: Version bump is appropriate.The patch version increment from 2.2.25 to 2.2.26 is consistent with the dependency updates and aligns with the changelog entry.
40-40: The peer dependency constraint for@heroui/themeat>=2.4.24is consistent across all components in the monorepo and compatible with the current theme package version (2.4.25). No action required.
54-57: Three React Aria package versions confirmed; @react-stately/overlays version could not be verified.The React Aria v1.14.0 release includes @react-aria/dialog@3.5.32, @react-aria/focus@3.21.3, and @react-aria/overlays@3.31.0, confirming those versions are legitimate. @react-aria/overlays@3.31.0 is confirmed as the latest version on npm. However, @react-stately/overlays@3.6.18 is the latest published version, so the 3.6.21 version listed in this change could not be verified through the npm registry. These React Aria packages have been scanned for known vulnerabilities with no issues found.
packages/components/modal/CHANGELOG.md (1)
3-15: LGTM: Changelog entry is well-formatted.The changelog entry for version 2.2.26 is properly structured and documents the React Aria upgrade. The version matches the package.json update, and the format is consistent with previous entries.
Note: The changelog references PR #5996, while the current PR is #6022. This is acceptable if #5996 was the PR that implemented these changes and #6022 is a release/merge PR.
packages/components/switch/package.json (2)
3-3: LGTM! Version bump is consistent.The patch version bump from 2.2.25 to 2.2.26 is appropriate for dependency updates.
39-39: Dependency versions verified as legitimate and secure.The React Aria packages (3.21.3, 3.26.0, 3.7.9, 3.8.29) and @heroui/theme (>=2.4.24) are valid releases with no known security vulnerabilities. All updates are patch or minor version bumps.
packages/components/switch/CHANGELOG.md (1)
3-8: LGTM! Changelog entry is properly formatted.The new release entry follows the established format and correctly references PR #5996. The mention of "react-aria (v1.14.0)" likely refers to the monorepo release version, while individual package versions (3.x) follow their own semantic versioning.
packages/components/checkbox/CHANGELOG.md (1)
3-10: LGTM!The changelog entry for version 2.3.29 is well-structured and follows the established pattern in the file. The react-aria upgrade to v1.14.0 is properly documented with the relevant PR link and commit reference.
packages/components/alert/package.json (1)
3-3: LGTM!The version bump and dependency updates are consistent with the broader monorepo update pattern for this release. The
@react-stately/utilsbump to 3.11.0 and theme peer dependency update align with other component changes in this PR.Also applies to: 43-43, 50-50
packages/components/form/package.json (1)
3-3: LGTM!The version bump to 2.1.29 and theme peer dependency update to >=2.4.24 are consistent with the coordinated monorepo release.
Also applies to: 38-38
packages/hooks/use-aria-accordion-item/package.json (1)
3-3: LGTM!The React Aria dependency updates are patch-level bumps that align with the react-aria v1.14.0 upgrade across the monorepo. The version bump to 2.2.19 is appropriate for these dependency changes.
Also applies to: 37-40
packages/components/breadcrumbs/CHANGELOG.md (1)
3-7: LGTM!The changelog entry for version 2.2.24 properly documents the react-aria v1.14.0 upgrade with the correct PR reference and commit hash.
packages/components/card/package.json (1)
3-3: LGTM!The dependency updates align with the react-aria v1.14.0 upgrade. Note that
@react-aria/interactionshas a minor version bump (3.25.6 → 3.26.0) which may include new features or behavior changes, but this is expected as part of the coordinated React Aria upgrade across the monorepo.Also applies to: 40-40, 48-49
packages/core/theme/package.json (1)
3-3: LGTM!The version bump to 2.4.25 appropriately advances the theme package version, maintaining compatibility with the peer dependency constraints (>=2.4.24) specified in dependent packages across the monorepo.
packages/components/avatar/package.json (1)
3-3: LGTM! Routine dependency updates.The version bump and dependency updates are consistent with the broader React Aria v1.14.0 upgrade across the monorepo.
Also applies to: 39-39, 46-47
packages/components/badge/package.json (1)
39-39: LGTM! Theme peer dependency aligned.The @heroui/theme peer dependency update is consistent with the monorepo-wide theme version bump.
packages/core/system-rsc/package.json (1)
38-38: LGTM! Theme peer dependency aligned.Consistent with the coordinated @heroui/theme version bump across the monorepo.
packages/hooks/use-aria-button/CHANGELOG.md (1)
3-8: LGTM! Changelog entry properly documented.The changelog entry correctly documents the react-aria v1.14.0 upgrade with appropriate PR and commit references.
packages/components/scroll-shadow/package.json (1)
39-39: LGTM! Theme peer dependency aligned.Consistent with the coordinated @heroui/theme version bump.
packages/components/table/CHANGELOG.md (1)
3-11: LGTM! Changelog entry properly documented.The changelog entry correctly documents the react-aria v1.14.0 upgrade and the @heroui/checkbox dependency update.
packages/components/toast/CHANGELOG.md (1)
3-11: LGTM! Changelog entry properly documented.The changelog entry correctly documents the react-aria v1.14.0 upgrade and the @heroui/spinner dependency update with appropriate references.
packages/core/react/package.json (1)
3-3: Approve the version bump to 2.8.7 with @react-aria/visually-hidden@3.8.29.The update aligns with the React Aria v1.14.0 release on December 16, 2025. The @react-aria/visually-hidden package has been scanned for vulnerabilities and is safe to use.
packages/components/toast/package.json (1)
3-52: Toast manifest version/dependency bump looks consistentThe package version, theme peer range, and dependency block all stay in line with the surrounding manifest and broader PR changes. No adjustments needed here.
packages/components/code/package.json (1)
36-40: Theme peer range bump is aligned with the rest of the repoRaising
@heroui/themeto>=2.4.24for@heroui/codematches the ecosystem-wide peer range update. No issues from a manifest perspective.packages/components/pagination/CHANGELOG.md (1)
3-11: New2.2.26pagination changelog entry is well‑formedThe new section follows the existing changelog conventions (version header, Patch Changes, PR/commit links, and an
Updated dependenciesblock). Reads clearly and is consistent with prior entries.packages/components/autocomplete/CHANGELOG.md (1)
3-17: Autocomplete2.3.31changelog entry is consistent and clearThe new version block matches the established format (heading, Patch Changes, PR/link, and explicit
Updated dependencieslist). Documentation looks complete and in line with earlier entries.packages/components/tabs/CHANGELOG.md (1)
3-11: Tabs2.2.26changelog entry matches existing conventionsThe new section is formatted like prior ones, includes the PR/commit reference, and clearly calls out the dependent package bump. Looks good as written.
packages/components/user/CHANGELOG.md (1)
3-10: User2.2.24changelog entry is consistent with prior releasesThe new Patch Changes block and
Updated dependencieslist are in the expected format and clearly document the avatar bump. No changes needed.packages/components/alert/CHANGELOG.md (1)
3-11: Alert2.2.29changelog entry is well‑structuredThe new version section follows the existing pattern, with clear Patch Changes text and an
Updated dependenciesbullet referencing the button bump. Looks correct and consistent.packages/components/divider/package.json (1)
39-39: LGTM! Peer dependency update aligns with the broader theme version bump.The update to
@heroui/themefrom>=2.4.23to>=2.4.24is consistent with the coordinated version bump across the monorepo.packages/components/spacer/package.json (1)
39-39: LGTM! Consistent peer dependency update.The
@heroui/themepeer dependency update matches the coordinated version bump across the monorepo.packages/components/card/CHANGELOG.md (1)
3-12: LGTM! Changelog entry properly documents the react-aria upgrade.The new release section correctly documents the upgrade to react-aria v1.14.0 and the related dependency updates.
packages/hooks/use-aria-accordion/CHANGELOG.md (1)
3-8: LGTM! Changelog entry properly documents the upgrade.The new release section correctly documents the react-aria v1.14.0 upgrade with appropriate PR and commit references.
packages/components/avatar/CHANGELOG.md (1)
3-8: LGTM! Changelog entry is well-documented.The release section properly documents the react-aria v1.14.0 upgrade with appropriate references.
packages/hooks/use-aria-accordion-item/CHANGELOG.md (1)
3-8: LGTM! Changelog entry is consistent and properly formatted.The new release section correctly documents the react-aria v1.14.0 upgrade.
packages/core/theme/src/components/input.ts (1)
53-53: [Your rewritten review comment text here]
[Exactly ONE classification tag]packages/hooks/use-aria-accordion/package.json (1)
3-3: Version bump to v3.27.0 is confirmed and compatible with existing code.The upgrade to @react-aria/selection 3.27.0 as part of the react-aria v1.14.0 release has been verified. The codebase uses standard selection APIs (
useSelectableList,ListKeyboardDelegate,useTypeSelect,useSelectableCollection) that remain compatible with this minor version update. No API breaking changes impact the current implementation.packages/components/menu/CHANGELOG.md (1)
3-12: LGTM!The changelog entry is consistent with the package.json version bump and clearly documents the react-aria upgrade.
packages/components/drawer/package.json (1)
3-3: LGTM!Version and peer dependency bumps are consistent with the coordinated upgrade across the monorepo.
Also applies to: 39-39
packages/components/spinner/package.json (1)
3-3: LGTM!Version and peer dependency updates are consistent with the coordinated release pattern across components.
Also applies to: 41-41
packages/components/spinner/CHANGELOG.md (1)
3-10: LGTM!The changelog entry is consistent with the package.json version bump and follows the established changelog format.
packages/components/menu/package.json (1)
3-3: All React ARIA dependency versions are published and stable.@react-aria/focus@3.21.3 is published, @react-aria/interactions@3.26.0 and @react-aria/menu@3.19.4 are part of the official React Aria v1-14-0 release, and @react-stately/tree@3.9.4 is published. These versions are stable and can be safely used.
packages/components/skeleton/package.json (1)
36-41: LGTM – skeleton theme peer bumped consistentlyThe only change is widening the
@heroui/themepeer range to>=2.4.24, which matches the rest of the PR’s theme updates and keeps compatibility with the new core theme version.Please double‑check that all published packages now depend on
@heroui/themein a compatible>=2.4.24range before release.packages/components/input/package.json (1)
3-51: LGTM – input manifest aligned with theme and react-aria versionsVersion,
@heroui/themepeer, and@react-aria/*/@react-stately/utilsbumps are consistent with the rest of the monorepo and don’t change the public surface of@heroui/input.Consider running the full input suite (unit + integration/visual tests) against the new react‑aria versions to catch any subtle a11y/interaction regressions.
packages/components/button/CHANGELOG.md (1)
3-13: LGTM – button 2.2.29 changelog entry is consistentThe new
2.2.29section clearly documents the react‑aria upgrade and dependency bumps, and matches the style and level of detail of prior entries.Please ensure the published
@heroui/button@2.2.29package.json matches these notes (react‑aria versions and dependency versions) before tagging the release.packages/core/react/CHANGELOG.md (1)
3-59: LGTM – core @heroui/react 2.8.7 entry matches dependency bumpsThe 2.8.7 changelog block correctly calls out the react‑aria upgrade and enumerates the updated component versions in a way that’s consistent with earlier 2.8.x releases.
Given the volume of updated dependencies here, it’s worth double‑checking that the actual package.json for
@heroui/reactand each listed component matches these versions before publishing the 2.8.7 tag.packages/components/select/package.json (1)
3-61: LGTM – select manifest updated for new theme and react-aria stackThe version bump,
@heroui/themepeer range, and the updated@react-aria/*dependencies all align with the coordinated RA/theme upgrade across the repo, with no structural changes to the package.Please verify that
@react-aria/focus,form,overlays,interactions, andvisually-hiddenare now on these same versions wherever else they’re used, to avoid mixed RA sub‑versions at runtime.packages/components/progress/package.json (1)
3-47: LGTM – progress dependency and peer range bumpsThe patch version,
@heroui/themepeer, and@react-aria/progressbump are straightforward and consistent with the rest of the v2.8.7 dependency refresh.As a sanity check, run any progress‑specific stories/tests to confirm the new
@react-aria/progresspatch doesn’t alter labeling or value formatting behavior.packages/components/tabs/package.json (1)
3-51: LGTM – tabs package.json synced with new theme and react-aria tabs versionsVersion,
@heroui/themepeer, and the@react-aria/*/@react-stately/tabsbumps look consistent with the broader upgrade and don’t affect the package’s module entrypoints.Given tabs’ sensitivity to focus management and keyboard interaction, please rerun the tabs interaction/a11y tests against these new react‑aria/stately versions.
packages/components/snippet/package.json (1)
3-51: LGTM – snippet manifest kept in step with theme and focus libraryThe snippet package version,
@heroui/themepeer constraint, and@react-aria/focusversion are updated in line with the rest of the ecosystem changes, with no other behavior‑affecting edits here.A quick manual check of keyboard focus behavior on the snippet component in Storybook/docs after this bump would be prudent, since it relies on
@react-aria/focus.packages/components/snippet/CHANGELOG.md (1)
3-12: LGTM! Changelog entry is well-documented.The new release section properly documents the react-aria upgrade to v1.14.0 and lists the updated dependencies. The changelog format is consistent with previous entries.
packages/core/system/CHANGELOG.md (1)
3-11: LGTM! Changelog entry follows proper format.The release section correctly documents the react-aria upgrade and dependency updates in a clear, consistent manner.
packages/components/date-picker/package.json (2)
3-3: Version bump is consistent with the release.The package version increment aligns with the coordinated v2.8.7 release.
38-38: Clarify dependency versions and verify compatibility testing.The review references @react-aria/datepicker v3.15.3 and @react-stately/datepicker v3.15.3, but current npm registry shows latest versions as 3.15.1 and 3.14.0 respectively. Additionally, @react-stately/utils v3.11.0 does not appear to exist (latest is 3.10.8). Verify the actual versions specified in package.json and confirm compatibility testing has been performed for the correct versions.
packages/hooks/use-aria-button/package.json (1)
3-3: Version and dependency updates look good.The hook package has been updated with the latest react-aria versions. The minor version bump of
@react-aria/interactions(3.25.6 -> 3.26.0) appears to be coordinated with the broader upgrade.Also applies to: 40-42
packages/components/button/package.json (1)
3-3: Button package updates are consistent.The version bump and dependency updates align with the coordinated release. The peer dependency constraint for
@heroui/themehas been properly updated.Also applies to: 40-40, 49-50
packages/components/listbox/package.json (1)
3-3: Listbox package updates are properly coordinated.All dependency updates follow the same pattern as other components in this release. The changes maintain consistency across the monorepo.
Also applies to: 39-39, 49-52
packages/components/autocomplete/package.json (2)
3-3: Autocomplete package updates are well-coordinated.The version bump and dependency updates align with the react-aria v1.14.0 upgrade. All runtime dependencies are patch-level updates.
Also applies to: 38-38, 55-58
68-68: Note the minor version bump in devDependency.The
@react-stately/datapackage has been updated from 3.14.1 to 3.15.0 (minor version bump). Since this is a devDependency, it shouldn't affect runtime behavior, but ensure tests still pass.packages/components/accordion/package.json (1)
3-3: Accordion package updates are consistent with the release.The version bump and dependency updates follow the same coordinated pattern as all other components. The react-aria and react-stately dependencies have been properly updated.
Also applies to: 46-46, 58-60
packages/components/accordion/CHANGELOG.md (1)
3-14: LGTM!The changelog entry is well-structured and properly documents the react-aria upgrade to v1.14.0, including all updated dependencies.
packages/components/checkbox/package.json (1)
3-3: LGTM!The version and dependency updates align with the monorepo-wide react-aria v1.14.0 upgrade. All changes are patch-level updates.
Also applies to: 38-38, 48-53
packages/components/navbar/package.json (1)
3-3: LGTM!The dependency updates are consistent with the monorepo-wide upgrade. Note that
@react-stately/utilshas a minor version bump (3.10.8 -> 3.11.0), which should be backward compatible.Also applies to: 40-40, 50-56
packages/components/calendar/CHANGELOG.md (1)
3-13: LGTM!The changelog entry properly documents the react-aria v1.14.0 upgrade and lists all updated dependencies. The format is consistent with other component changelogs in this PR.
packages/components/calendar/package.json (1)
3-3: LGTM – calendar dependencies properly aligned with react-aria v1.14.0 release.All updates are patch-level except
@react-stately/utilswhich receives a minor version bump. The dependency updates are part of the coordinated react-aria v1.14.0 release.packages/components/popover/package.json (1)
3-3: The specified dependency versions do not match the latest available on npm.@react-aria/dialog latest version is 3.5.31, not 3.5.32 as referenced. @react-stately/overlays latest version is 3.6.18, not 3.6.21. @react-aria/focus 3.21.3 is valid and @react-aria/overlays 3.31.0 is valid. Verify the package.json reflects the correct versions currently available on npm.
Likely an incorrect or invalid review comment.
packages/components/navbar/CHANGELOG.md (1)
3-10: LGTM! Changelog entry follows established format.The new version 2.2.27 entry is properly structured with the PR reference, commit hash, author attribution, and dependency updates.
apps/docs/content/docs/components/date-input.mdx (1)
107-110: LGTM! Documentation version references updated consistently.All package installation commands have been updated to reference the new versions (
@internationalized/date@3.10.1and@react-aria/i18n@3.12.14). The versions are consistent across all sections and align with thefixedVersionsmap inparse-dependencies.ts.Also applies to: 132-135, 156-159, 180-183, 203-206, 226-229
apps/docs/content/docs/components/date-picker.mdx (1)
122-125: LGTM! Version references updated consistently across all sections.All PackageManagers commands correctly reference
@internationalized/date@3.10.1and@react-aria/i18n@3.12.14where applicable. The updates are consistent withdate-input.mdxand thefixedVersionsconfiguration.Also applies to: 147-150, 171-174, 195-198, 217-220, 255-258
packages/components/form/CHANGELOG.md (1)
3-9: LGTM! Changelog entry properly documents dependency updates.The version 2.1.29 entry correctly documents the updated dependencies (
@heroui/theme@2.4.25and@heroui/system@2.4.25) with appropriate commit references.apps/docs/components/docs/components/code-demo/parse-dependencies.ts (1)
54-57: LGTM! Version mappings updated correctly.The
fixedVersionsmappings are updated to reflect the new patch versions for @internationalized/date (3.10.1) and @react-aria/i18n (3.12.14).packages/components/date-input/CHANGELOG.md (1)
3-11: LGTM! Changelog entry is consistent and complete.The version 2.3.29 entry properly documents the react-aria v1.14.0 upgrade and the updated
@heroui/formdependency.packages/components/date-picker/CHANGELOG.md (1)
3-16: LGTM! Comprehensive changelog entry.The version 2.3.30 entry properly documents the react-aria v1.14.0 upgrade and all updated dependencies across date-input, aria-utils, calendar, popover, button, and form packages.
packages/components/date-input/package.json (1)
3-3: LGTM! Version and dependency bumps are consistent.The package version bump to 2.3.29 aligns with the changelog, and all React Aria dependencies are updated to newer patch versions. The peer dependency requirement for
@heroui/themeis appropriately bumped to >=2.4.24 to match the coordinated release.Also applies to: 38-38, 46-50
apps/docs/package.json (1)
32-42: LGTM! Docs dependencies are properly aligned.The documentation package dependencies are updated to match the component library versions, ensuring consistency in examples and demos. The updates include:
@internationalized/date(3.10.0 → 3.10.1)- Multiple
@react-aria/*packages with patch/minor bumps@react-types/calendarand@react-types/datepickerupdatesAlso applies to: 93-94
packages/components/table/package.json (1)
3-3: LGTM! Table package updates are consistent.The table package version bump to 2.2.29 includes coordinated React Aria dependency updates. Note that
@react-aria/interactions(3.25.6 → 3.26.0) and@react-stately/data(3.14.1 → 3.15.0) have minor version bumps. The peer dependency for@heroui/themeis appropriately updated to >=2.4.24.Also applies to: 39-39, 47-52, 67-67
packages/core/system/package.json (1)
3-3: System package version update to 2.4.25 with React Aria dependency updates noted.The system package includes updates to React Aria dependencies. The @react-aria/overlays has been updated to 3.31.0. Ensure these updates are compatible with the existing codebase.
packages/components/dropdown/CHANGELOG.md (1)
3-13: Changelog entry is appropriate.The version 2.3.29 entry correctly documents the react-aria v1.14.0 upgrade and updated dependencies. The
onActionproperty is inherited from react-aria'sAriaMenuPropsand is not a new public API introduced in this version, so the changelog requires no additional documentation.packages/core/theme/CHANGELOG.md (1)
3-10: Changelog entry is accurate and change is intentional.The password reveal button hiding (PR #5990, issue #5984) is implemented via CSS
[&::-ms-reveal]:hiddenin the input component styling. This hides Microsoft Edge/IE's native password reveal button, a standard practice when implementing custom password reveal functionality across browsers. The change is CSS-only and does not break accessibility or user workflows—it simply prevents UI conflicts by suppressing the browser's built-in feature in favor of a unified custom implementation. No further verification needed.packages/components/dropdown/__tests__/dropdown.test.tsx (2)
680-722: LGTM! Test properly updated for new centralized action API.The test correctly reflects the API change from per-item
onPressto centralizedonActionon DropdownMenu. The keyboard interaction now usesuser.keyboard("{Enter}")and properly asserts thatonActionis called with the correct item key.
724-766: LGTM! Space key test correctly implements new API.The Space key test mirrors the Enter key test pattern, correctly using the centralized
onActionhandler and verifying the action with the proper key value.packages/components/breadcrumbs/package.json (1)
3-3: LGTM! Standard version and dependency bumps.All changes are patch-level updates consistent with the PR's dependency upgrade objectives.
packages/core/react/src/client.ts (1)
1-51: New client entry point with proper re-exports and no naming conflicts.The
"use client"directive correctly marks this as a client-side module. All 43 re-exported component packages are declared as dependencies in package.json, and verification confirms no export name conflicts exist between packages. The re-export pattern provides a clean unified API surface for consuming applications while maintaining individual package modularity.packages/components/link/__tests__/link.test.tsx (1)
102-114: Good test coverage for button usage.This test properly validates that the Link component can be rendered as a button without an href attribute, which is the correct semantic behavior. The assertions cover the key requirements:
- Correct element type (BUTTON)
- Proper type attribute
- No href attribute present
packages/components/link/package.json (1)
39-39: Dependency versions verified and confirmed available.@react-aria/focus@3.21.3 is the latest version on npm and @heroui/theme@2.4.24 is the latest version on npm. Both have no known security vulnerabilities. A focus behavior regression was reported in v3.21.0 involving visibility:hidden inputs—verify focus behavior works as expected in your link component after upgrading.
3 participants
Closes #
📝 Description
⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Summary by CodeRabbit
Release Notes
New Features
onActionhandler for item selectionas="button"propBug Fixes
Improvements
✏️ Tip: You can customize this high-level summary in your review settings.