Backport 1.16 fix snapshot test#18664
Closed
asheshvidyut wants to merge 9873 commits intorelease/1.6.xfrom
Closed
Conversation
…a snapshot restore occurring (#17566) * Fix up case where subscription is terminated due to ACLs changing or a snapshot restore occurring * Add changelog entry * Switch to use errors.Is
* generate docs
TLDR with many modules the versions included in each diverged quite a bit. Attempting to use Go Workspaces produces a bunch of errors. This commit: 1. Fixes envoy-library-references.sh to work again 2. Ensures we are pulling in go-control-plane@v0.11.0 everywhere (previously it was at that version in some modules and others were much older) 3. Remove one usage of golang/protobuf that caused us to have a direct dependency on it. 4. Remove deprecated usage of the Endpoint field in the grpc resolver.Target struct. The current version of grpc (v1.55.0) has removed that field and recommended replacement with URL.Opaque and calls to the Endpoint() func when needing to consume the previous field. 4. `go work init <all the paths to go.mod files>` && `go work sync`. This syncrhonized versions of dependencies from the main workspace/root module to all submodules 5. Updated .gitignore to ignore the go.work and go.work.sum files. This seems to be standard practice at the moment. 6. Update doc comments in protoc-gen-consul-rate-limit to be go fmt compatible 7. Upgraded makefile infra to perform linting, testing and go mod tidy on all modules in a flexible manner. 8. Updated linter rules to prevent usage of golang/protobuf 9. Updated a leader peering test to account for an extra colon in a grpc error message.
* docs: clarify the behavior of prepending hostname to metrics * Update website/content/docs/agent/config/config-files.mdx Co-authored-by: trujillo-adam <47586768+trujillo-adam@users.noreply.github.com> --------- Co-authored-by: trujillo-adam <47586768+trujillo-adam@users.noreply.github.com>
* Fix subscribing/fetching objects not in the default namespace * add changelog
Ensure that the embedded api struct is properly parsed when deserializing config containing a set ResourceFilter.Services field. Also enhance existing integration test to guard against bugs and exercise this field.
* Add a ReplaceType dep mapper and move them into their own file * Implement the service endpoints controller * Implement a Catalog Controllers Integration Test
Fix some linter warnings before updating the lint-consul-retry code in hashicorp/lint-consul-retry#4
More validation is needed to ensure this behaves as expected; in the meantime, align with docs and disable this proxy type.
Bump api, sdk versions to latest.
Bump api, envoyextensions versions to latest.
Update to new RC submodule versions. These will be updated again for the 1.16.0 release.
Other recent releases have not commented out the replace directives in go.mod. Though it would be ideal to pin our submodules in the release artifacts we produce, we need to tidy up our build pipeline to make this feasible. In the meantime, revert this change to keep the dependency entry updates, but exclude them from the effective dependency tree.
…c mgmt for k8s into release/1.16.x (#17645) * backport of commit e4c2789 * backport of commit c3a2d0b * backport of commit 81f8f7c * backport of commit 63d12fb * backport of commit 73d7179 * backport of commit f887336 --------- Co-authored-by: trujillo-adam <ajosetru@gmail.com> Co-authored-by: trujillo-adam <47586768+trujillo-adam@users.noreply.github.com>
…18449) * backport of commit d6d0450 * backport of commit 39feb99 * backport of commit 8b1398a * backport of commit 47b9c12 * backport of commit db8d974 * backport of commit f64e808 * backport of commit 6b6dbb4 * backport of commit 2e34721 * backport of commit 2d52b0c --------- Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com>
Co-authored-by: Tu Nguyen <im2nguyen@users.noreply.github.com>
backport of commit a9482b0 Co-authored-by: Luke Kysow <1034429+lkysow@users.noreply.github.com>
… file contains BUSL header into release/1.16.x (#18489) Add license-checker action that fails when any backported file contains BUSL header (#18485) * Add license-checker action that fails when any backported file contains BUSL header * Quote echoed variable to retain line breaks * Add ticket to reference for more details Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com>
…to release/1.16.x (#18520) resolve conflict Co-authored-by: temp <temp@hashicorp.com>
…Version / Datacenter into release/1.16.x (#18638) * backport of commit 5e1bae5 * backport of commit 8805feb * backport of commit 99443a2 * backport of commit 37155cd * backport of commit c7971c9 * backport of commit 2b66e28 * backport of commit 2c9f48e * backport of commit 0130674 * backport of commit 171e0a5 * NET 1594 - Snapshot Agent Filename Should Include Consul Version / Datacenter (#18625) * init * tests added and few fixes * revert arg message * changelog added * removed var declaration * fix CI * fix test * added node name and status * updated save.mdx * added example * fix tense * fix description --------- Co-authored-by: absolutelightning <ashesh.vidyut@hashicorp.com> Co-authored-by: Ashesh Vidyut <134911583+absolutelightning@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small fix for this test. This fails in ENT because the version has
1.17.0+ent, but the test agent version does not have the+entsuffix.The original PR is #18625