Backport of [API Gateway] Fix rate limiting for API gateways into release/1.16.x#17635
Merged
hc-github-team-consul-core merged 4 commits intorelease/1.16.xfrom Jun 9, 2023
Conversation
16eeb8e to
d34782d
Compare
edca9f9 to
58ea6f5
Compare
github-team-consul-core-pr-approver
approved these changes
Jun 9, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
cd9e6ab to
edca9f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17631 to be assessed for backporting due to the inclusion of the label backport/1.16.
The below text is copied from the body of the original PR.
Description
We noticed when we were running the Consul Kubernetes conformance tests that we were getting strange rate-limiting errors in Consul. I tracked this down to the fact that the rate limiting code internally is using the service usage metrics code in our state store and noticed that API gateways haven't been added there, so the downstream places where we count and rate limit based on the number of connect-enabled services would never include API gateways in the count. I'm assuming that the reason that we've not noticed up until this point is that:
Testing & Reproduction steps
To reproduce this bug you can run conformance tests against the current Consul Kubernetes code or just register a bunch of services and API Gateways and then watch the Consul rate limiter start throwing errors.
PR Checklist
Overview of commits